| Message ID | 1638547658-22032-10-git-send-email-srivasam@codeaurora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support for audio on SC7280 based targets | expand |
On Fri, 03 Dec 2021 21:37:37 +0530, Srinivasa Rao Mandadapu wrote: > From: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> > > Add bindings for sc7280 lpass cpu driver which supports > audio over i2s based speaker, soundwire based headset, msm dmics > and HDMI Port. > > Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> > Co-developed-by: Venkata Prasad Potturu <potturu@codeaurora.org> > Signed-off-by: Venkata Prasad Potturu <potturu@codeaurora.org> > --- > .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 70 +++++++++++++++++++--- > 1 file changed, 62 insertions(+), 8 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.example.dt.yaml: lpass@62d80000: reg: [[0, 1658351616, 0, 425984], [0, 1659895808, 0, 167936]] is too short From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.example.dt.yaml: lpass@62d80000: reg-names: ['lpass-hdmiif', 'lpass-lpaif'] is too short From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.example.dt.yaml: lpass@62d80000: interrupts: [[0, 160, 1], [0, 268, 1]] is too short From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.example.dt.yaml: lpass@62d80000: interrupt-names: ['lpass-irq-lpaif', 'lpass-irq-hdmi'] is too short From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.example.dt.yaml: lpass@62d80000: iommus: [[4294967295, 4128, 0], [4294967295, 4146, 0]] is too short From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1563323 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Fri, Dec 3, 2021 at 5:34 PM Rob Herring <robh@kernel.org> wrote: > > On Fri, 03 Dec 2021 21:37:37 +0530, Srinivasa Rao Mandadapu wrote: > > From: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> > > > > Add bindings for sc7280 lpass cpu driver which supports > > audio over i2s based speaker, soundwire based headset, msm dmics > > and HDMI Port. > > > > Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> > > Co-developed-by: Venkata Prasad Potturu <potturu@codeaurora.org> > > Signed-off-by: Venkata Prasad Potturu <potturu@codeaurora.org> > > --- > > .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 70 +++++++++++++++++++--- > > 1 file changed, 62 insertions(+), 8 deletions(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.example.dt.yaml: lpass@62d80000: reg: [[0, 1658351616, 0, 425984], [0, 1659895808, 0, 167936]] is too short > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml Are you running the checks before you send out your patches. Because it seems like you keep sending things with the same errors. If there's errors, I'm not going to review this. If you need help getting it to work, then ask. And what's with your email setup? codeaurora.com bounces. Rob
On 12/3/2021 3:38 PM, Rob Herring wrote: > On Fri, Dec 3, 2021 at 5:34 PM Rob Herring <robh@kernel.org> wrote: >> >> On Fri, 03 Dec 2021 21:37:37 +0530, Srinivasa Rao Mandadapu wrote: >>> From: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> >>> >>> Add bindings for sc7280 lpass cpu driver which supports >>> audio over i2s based speaker, soundwire based headset, msm dmics >>> and HDMI Port. >>> >>> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> >>> Co-developed-by: Venkata Prasad Potturu <potturu@codeaurora.org> >>> Signed-off-by: Venkata Prasad Potturu <potturu@codeaurora.org> >>> --- >>> .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 70 +++++++++++++++++++--- >>> 1 file changed, 62 insertions(+), 8 deletions(-) >>> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.example.dt.yaml: lpass@62d80000: reg: [[0, 1658351616, 0, 425984], [0, 1659895808, 0, 167936]] is too short >> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml > > Are you running the checks before you send out your patches. Because > it seems like you keep sending things with the same errors. > > If there's errors, I'm not going to review this. If you need help > getting it to work, then ask. > > And what's with your email setup? codeaurora.com bounces. codeaurora.com is definitely a wrong domain. It should be codeaurora.org instead. > > Rob >
On 12/4/2021 5:08 AM, Rob Herring wrote: Thanks for your time and notifying the issue!!! > On Fri, Dec 3, 2021 at 5:34 PM Rob Herring <robh@kernel.org> wrote: >> On Fri, 03 Dec 2021 21:37:37 +0530, Srinivasa Rao Mandadapu wrote: >>> From: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> >>> >>> Add bindings for sc7280 lpass cpu driver which supports >>> audio over i2s based speaker, soundwire based headset, msm dmics >>> and HDMI Port. >>> >>> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> >>> Co-developed-by: Venkata Prasad Potturu <potturu@codeaurora.org> >>> Signed-off-by: Venkata Prasad Potturu <potturu@codeaurora.org> >>> --- >>> .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 70 +++++++++++++++++++--- >>> 1 file changed, 62 insertions(+), 8 deletions(-) >>> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.example.dt.yaml: lpass@62d80000: reg: [[0, 1658351616, 0, 425984], [0, 1659895808, 0, 167936]] is too short >> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml > Are you running the checks before you send out your patches. Because > it seems like you keep sending things with the same errors. > > If there's errors, I'm not going to review this. If you need help > getting it to work, then ask. Actually, the too short name errors are coming for the existing names also. could you please suggest on how to go ahead? > > And what's with your email setup? codeaurora.com bounces. From December 3 Qualcomm mail domain got changed to quicinc.com from codeaurora.org. May be that's the reason for bouncing. > > Rob
On Sat, Dec 4, 2021 at 1:59 AM Srinivasa Rao Mandadapu <srivasam@codeaurora.org> wrote: > > > On 12/4/2021 5:08 AM, Rob Herring wrote: > Thanks for your time and notifying the issue!!! > > On Fri, Dec 3, 2021 at 5:34 PM Rob Herring <robh@kernel.org> wrote: > >> On Fri, 03 Dec 2021 21:37:37 +0530, Srinivasa Rao Mandadapu wrote: > >>> From: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> > >>> > >>> Add bindings for sc7280 lpass cpu driver which supports > >>> audio over i2s based speaker, soundwire based headset, msm dmics > >>> and HDMI Port. > >>> > >>> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> > >>> Co-developed-by: Venkata Prasad Potturu <potturu@codeaurora.org> > >>> Signed-off-by: Venkata Prasad Potturu <potturu@codeaurora.org> > >>> --- > >>> .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 70 +++++++++++++++++++--- > >>> 1 file changed, 62 insertions(+), 8 deletions(-) > >>> > >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > >> on your patch (DT_CHECKER_FLAGS is new in v5.13): > >> > >> yamllint warnings/errors: > >> > >> dtschema/dtc warnings/errors: > >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.example.dt.yaml: lpass@62d80000: reg: [[0, 1658351616, 0, 425984], [0, 1659895808, 0, 167936]] is too short > >> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml > > Are you running the checks before you send out your patches. Because > > it seems like you keep sending things with the same errors. > > > > If there's errors, I'm not going to review this. If you need help > > getting it to work, then ask. > Actually, the too short name errors are coming for the existing names > also. could you please suggest on how to go ahead? Go read Documentation/devicetree/bindings/example-schema.yaml and the part about default address sizes. > > > > And what's with your email setup? codeaurora.com bounces. > > From December 3 Qualcomm mail domain got changed to quicinc.com from > codeaurora.org. > > May be that's the reason for bouncing. No idea. Just fix it please. I don't think I've seen this problem from anyone else. Rob
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml index 1e23c0e..efaaa8ea 100644 --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml @@ -22,35 +22,36 @@ properties: - qcom,lpass-cpu - qcom,apq8016-lpass-cpu - qcom,sc7180-lpass-cpu + - qcom,sc7280-lpass-cpu reg: - maxItems: 2 + maxItems: 5 description: LPAIF core registers reg-names: - maxItems: 2 + maxItems: 5 clocks: minItems: 3 - maxItems: 6 + maxItems: 7 clock-names: minItems: 3 - maxItems: 6 + maxItems: 7 interrupts: - maxItems: 2 + maxItems: 4 description: LPAIF DMA buffer interrupt interrupt-names: - maxItems: 2 + maxItems: 4 qcom,adsp: $ref: /schemas/types.yaml#/definitions/phandle description: Phandle for the audio DSP node iommus: - maxItems: 2 + maxItems: 3 description: Phandle to apps_smmu node with sid mask power-domains: @@ -69,7 +70,7 @@ patternProperties: "^dai-link@[0-9a-f]$": type: object description: | - LPASS CPU dai node for each I2S device. Bindings of each node + LPASS CPU dai node for each I2S device or Soundwire device. Bindings of each node depends on the specific driver providing the functionality and properties. properties: @@ -174,6 +175,59 @@ allOf: - iommus - power-domains + - if: + properties: + compatible: + contains: + const: qcom,sc7280-lpass-cpu + + then: + properties: + clock-names: + oneOf: + - items: #for I2S + - const: aon_cc_audio_hm_h + - const: core_cc_sysnoc_mport_core + - const: core_cc_ext_if1_ibit + - items: #for Soundwire + - const: aon_cc_audio_hm_h + - const: audio_cc_codec_mem0 + - const: audio_cc_codec_mem1 + - const: audio_cc_codec_mem2 + - items: #for HDMI + - const: aon_cc_audio_hm_h + + reg-names: + anyOf: + - items: #for I2S + - const: lpass-lpaif + - items: #for I2S and HDMI + - const: lpass-hdmiif + - const: lpass-lpaif + - items: #for I2S, soundwire and HDMI + - const: lpass-hdmiif + - const: lpass-lpaif + - const: lpass-rxtx-cdc-dma-lpm + - const: lpass-rxtx-lpaif + - const: lpass-va-lpaif + - const: lpass-va-cdc-dma-lpm + interrupt-names: + anyOf: + - items: #for I2S + - const: lpass-irq-lpaif + - items: #for I2S and HDMI + - const: lpass-irq-lpaif + - const: lpass-irq-hdmi + - items: #for I2S, soundwire and HDMI + - const: lpass-irq-lpaif + - const: lpass-irq-hdmi + - const: lpass-irq-vaif + - const: lpass-irq-rxtxif + + required: + - iommus + - power-domains + examples: - | #include <dt-bindings/sound/sc7180-lpass.h>