| Message ID | 20211205065528.1613881-3-m.chetan.kumar@linux.intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: wwan: iosm: Bug fixes | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Series has a cover letter |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 8 of 8 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 15 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
Hello M Chetan Kumar, On Sun, Dec 5, 2021 at 9:47 AM M Chetan Kumar <m.chetan.kumar@linux.intel.com> wrote: > Set wwan net dev tx queue len to 1000. > > Signed-off-by: M Chetan Kumar <m.chetan.kumar@linux.intel.com> > --- > drivers/net/wwan/iosm/iosm_ipc_wwan.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wwan/iosm/iosm_ipc_wwan.c b/drivers/net/wwan/iosm/iosm_ipc_wwan.c > index b571d9cedba4..e3fb926d2248 100644 > --- a/drivers/net/wwan/iosm/iosm_ipc_wwan.c > +++ b/drivers/net/wwan/iosm/iosm_ipc_wwan.c > @@ -18,6 +18,7 @@ > #define IOSM_IP_TYPE_IPV6 0x60 > > #define IOSM_IF_ID_PAYLOAD 2 > +#define IOSM_QDISC_QUEUE_LEN 1000 Is this 1000 something special for the IOSM driver? If you need just an approximate value for the queue length, then consider using the common DEFAULT_TX_QUEUE_LEN macro, please. > /** > * struct iosm_netdev_priv - netdev WWAN driver specific private data > @@ -159,7 +160,7 @@ static void ipc_wwan_setup(struct net_device *iosm_dev) > { > iosm_dev->header_ops = NULL; > iosm_dev->hard_header_len = 0; > - iosm_dev->priv_flags |= IFF_NO_QUEUE; > + iosm_dev->tx_queue_len = IOSM_QDISC_QUEUE_LEN; > > iosm_dev->type = ARPHRD_NONE; > iosm_dev->mtu = ETH_DATA_LEN;
Hi Sergey, On 12/5/2021 4:46 PM, Sergey Ryazanov wrote: > Hello M Chetan Kumar, > > On Sun, Dec 5, 2021 at 9:47 AM M Chetan Kumar > <m.chetan.kumar@linux.intel.com> wrote: >> Set wwan net dev tx queue len to 1000. >> >> Signed-off-by: M Chetan Kumar <m.chetan.kumar@linux.intel.com> >> --- >> drivers/net/wwan/iosm/iosm_ipc_wwan.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/wwan/iosm/iosm_ipc_wwan.c b/drivers/net/wwan/iosm/iosm_ipc_wwan.c >> index b571d9cedba4..e3fb926d2248 100644 >> --- a/drivers/net/wwan/iosm/iosm_ipc_wwan.c >> +++ b/drivers/net/wwan/iosm/iosm_ipc_wwan.c >> @@ -18,6 +18,7 @@ >> #define IOSM_IP_TYPE_IPV6 0x60 >> >> #define IOSM_IF_ID_PAYLOAD 2 >> +#define IOSM_QDISC_QUEUE_LEN 1000 > > Is this 1000 something special for the IOSM driver? If you need just > an approximate value for the queue length, then consider using the > common DEFAULT_TX_QUEUE_LEN macro, please. We had set an approximate value for the queue length. Sure, will use the common queue length macro (DEFAULT_TX_QUEUE_LEN) instead of defining the new macro. Regards, Chetan
On Sun, Dec 5, 2021 at 4:52 PM Kumar, M Chetan <m.chetan.kumar@linux.intel.com> wrote: > On 12/5/2021 4:46 PM, Sergey Ryazanov wrote: >> On Sun, Dec 5, 2021 at 9:47 AM M Chetan Kumar >> <m.chetan.kumar@linux.intel.com> wrote: >>> Set wwan net dev tx queue len to 1000. >>> >>> Signed-off-by: M Chetan Kumar <m.chetan.kumar@linux.intel.com> >>> --- >>> drivers/net/wwan/iosm/iosm_ipc_wwan.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/wwan/iosm/iosm_ipc_wwan.c b/drivers/net/wwan/iosm/iosm_ipc_wwan.c >>> index b571d9cedba4..e3fb926d2248 100644 >>> --- a/drivers/net/wwan/iosm/iosm_ipc_wwan.c >>> +++ b/drivers/net/wwan/iosm/iosm_ipc_wwan.c >>> @@ -18,6 +18,7 @@ >>> #define IOSM_IP_TYPE_IPV6 0x60 >>> >>> #define IOSM_IF_ID_PAYLOAD 2 >>> +#define IOSM_QDISC_QUEUE_LEN 1000 >> >> Is this 1000 something special for the IOSM driver? If you need just >> an approximate value for the queue length, then consider using the >> common DEFAULT_TX_QUEUE_LEN macro, please. >> We had set an approximate value for the queue length. > Sure, will use the common queue length macro (DEFAULT_TX_QUEUE_LEN) > instead of defining the new macro. Thank you! The series looks good to me, so feel free to add my: Reviewed-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
diff --git a/drivers/net/wwan/iosm/iosm_ipc_wwan.c b/drivers/net/wwan/iosm/iosm_ipc_wwan.c index b571d9cedba4..e3fb926d2248 100644 --- a/drivers/net/wwan/iosm/iosm_ipc_wwan.c +++ b/drivers/net/wwan/iosm/iosm_ipc_wwan.c @@ -18,6 +18,7 @@ #define IOSM_IP_TYPE_IPV6 0x60 #define IOSM_IF_ID_PAYLOAD 2 +#define IOSM_QDISC_QUEUE_LEN 1000 /** * struct iosm_netdev_priv - netdev WWAN driver specific private data @@ -159,7 +160,7 @@ static void ipc_wwan_setup(struct net_device *iosm_dev) { iosm_dev->header_ops = NULL; iosm_dev->hard_header_len = 0; - iosm_dev->priv_flags |= IFF_NO_QUEUE; + iosm_dev->tx_queue_len = IOSM_QDISC_QUEUE_LEN; iosm_dev->type = ARPHRD_NONE; iosm_dev->mtu = ETH_DATA_LEN;
Set wwan net dev tx queue len to 1000. Signed-off-by: M Chetan Kumar <m.chetan.kumar@linux.intel.com> --- drivers/net/wwan/iosm/iosm_ipc_wwan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)