Message ID | 20211204174033.950528-1-arnd@kernel.org (mailing list archive) |
---|---|
State | Accepted |
Commit | 5382911f5d67a5a13815fb6958265b4a11ff7cfd |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | net: wwan: iosm: select CONFIG_RELAY | expand |
On Sat, Dec 4, 2021 at 8:40 PM Arnd Bergmann <arnd@kernel.org> wrote: > The iosm driver started using relayfs, but is missing the Kconfig > logic to ensure it's built into the kernel: > > x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_create_buf_file_handler': > iosm_ipc_trace.c:(.text+0x16): undefined reference to `relay_file_operations' > x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_subbuf_start_handler': > iosm_ipc_trace.c:(.text+0x31): undefined reference to `relay_buf_full' > x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_ctrl_file_write': > iosm_ipc_trace.c:(.text+0xd5): undefined reference to `relay_flush' > x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_port_rx': > > Fixes: 00ef32565b9b ("net: wwan: iosm: device trace collection using relayfs") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
On 12/4/2021 11:10 PM, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The iosm driver started using relayfs, but is missing the Kconfig > logic to ensure it's built into the kernel: > > x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_create_buf_file_handler': > iosm_ipc_trace.c:(.text+0x16): undefined reference to `relay_file_operations' > x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_subbuf_start_handler': > iosm_ipc_trace.c:(.text+0x31): undefined reference to `relay_buf_full' > x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_ctrl_file_write': > iosm_ipc_trace.c:(.text+0xd5): undefined reference to `relay_flush' > x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_port_rx': > > Fixes: 00ef32565b9b ("net: wwan: iosm: device trace collection using relayfs") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: M Chetan Kumar <m.chetan.kumar@linux.intel.com>
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Sat, 4 Dec 2021 18:40:25 +0100 you wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The iosm driver started using relayfs, but is missing the Kconfig > logic to ensure it's built into the kernel: > > x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_create_buf_file_handler': > iosm_ipc_trace.c:(.text+0x16): undefined reference to `relay_file_operations' > x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_subbuf_start_handler': > iosm_ipc_trace.c:(.text+0x31): undefined reference to `relay_buf_full' > x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_ctrl_file_write': > iosm_ipc_trace.c:(.text+0xd5): undefined reference to `relay_flush' > x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_port_rx': > > [...] Here is the summary with links: - net: wwan: iosm: select CONFIG_RELAY https://git.kernel.org/netdev/net-next/c/5382911f5d67 You are awesome, thank you!
diff --git a/drivers/net/wwan/Kconfig b/drivers/net/wwan/Kconfig index bdb2b0e46c12..9f5111a77da9 100644 --- a/drivers/net/wwan/Kconfig +++ b/drivers/net/wwan/Kconfig @@ -85,6 +85,7 @@ config IOSM tristate "IOSM Driver for Intel M.2 WWAN Device" depends on INTEL_IOMMU select NET_DEVLINK + select RELAY help This driver enables Intel M.2 WWAN Device communication.