| Message ID | 20211208145459.9590-1-xiangxia.m.yue@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | fix bpf_redirect to ifb netdev | expand |
From: Tonghao Zhang <xiangxia.m.yue@gmail.com> Date: Wed, 8 Dec 2021 22:54:56 +0800 > From: Tonghao Zhang <xiangxia.m.yue@gmail.com> > > This patchset try to fix bpf_redirect to ifb netdev. > Prevent packets loopback and perfromance drop, add check > in sch egress. Please provide a changelog in the cover letter. With the links to your previous versions ideally. Otherwise it becomes difficult to understand what are the changes between them. > > Tonghao Zhang (3): > net: core: set skb useful vars in __bpf_tx_skb > net: sched: add check tc_skip_classify in sch egress > selftests: bpf: add bpf_redirect to ifb > > net/core/dev.c | 3 + > net/core/filter.c | 12 ++- > tools/testing/selftests/bpf/Makefile | 1 + > .../bpf/progs/test_bpf_redirect_ifb.c | 13 ++++ > .../selftests/bpf/test_bpf_redirect_ifb.sh | 73 +++++++++++++++++++ > 5 files changed, 101 insertions(+), 1 deletion(-) > create mode 100644 tools/testing/selftests/bpf/progs/test_bpf_redirect_ifb.c > create mode 100755 tools/testing/selftests/bpf/test_bpf_redirect_ifb.sh > > -- > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Alexei Starovoitov <ast@kernel.org> > Cc: Daniel Borkmann <daniel@iogearbox.net> > Cc: Andrii Nakryiko <andrii@kernel.org> > Cc: Martin KaFai Lau <kafai@fb.com> > Cc: Song Liu <songliubraving@fb.com> > Cc: Yonghong Song <yhs@fb.com> > Cc: John Fastabend <john.fastabend@gmail.com> > Cc: KP Singh <kpsingh@kernel.org> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Antoine Tenart <atenart@kernel.org> > Cc: Alexander Lobakin <alexandr.lobakin@intel.com> > Cc: Wei Wang <weiwan@google.com> > Cc: Arnd Bergmann <arnd@arndb.de> > -- > 2.27.0 Al
On Wed, Dec 8, 2021 at 11:42 PM Alexander Lobakin <alexandr.lobakin@intel.com> wrote: > > From: Tonghao Zhang <xiangxia.m.yue@gmail.com> > Date: Wed, 8 Dec 2021 22:54:56 +0800 > > > From: Tonghao Zhang <xiangxia.m.yue@gmail.com> > > > > This patchset try to fix bpf_redirect to ifb netdev. > > Prevent packets loopback and perfromance drop, add check > > in sch egress. > > Please provide a changelog in the cover letter. With the links to > your previous versions ideally. > Otherwise it becomes difficult to understand what are the changes > between them. Hi Alexander This version of patchset, 2/3 only updates the commit message. because the example in the commit message is not a usual case. There are no comments, so I sent them again. I will provide a changelog in the next version or resend this version again. Thanks. > > > > Tonghao Zhang (3): > > net: core: set skb useful vars in __bpf_tx_skb > > net: sched: add check tc_skip_classify in sch egress > > selftests: bpf: add bpf_redirect to ifb > > > > net/core/dev.c | 3 + > > net/core/filter.c | 12 ++- > > tools/testing/selftests/bpf/Makefile | 1 + > > .../bpf/progs/test_bpf_redirect_ifb.c | 13 ++++ > > .../selftests/bpf/test_bpf_redirect_ifb.sh | 73 +++++++++++++++++++ > > 5 files changed, 101 insertions(+), 1 deletion(-) > > create mode 100644 tools/testing/selftests/bpf/progs/test_bpf_redirect_ifb.c > > create mode 100755 tools/testing/selftests/bpf/test_bpf_redirect_ifb.sh > > > > -- > > Cc: "David S. Miller" <davem@davemloft.net> > > Cc: Jakub Kicinski <kuba@kernel.org> > > Cc: Alexei Starovoitov <ast@kernel.org> > > Cc: Daniel Borkmann <daniel@iogearbox.net> > > Cc: Andrii Nakryiko <andrii@kernel.org> > > Cc: Martin KaFai Lau <kafai@fb.com> > > Cc: Song Liu <songliubraving@fb.com> > > Cc: Yonghong Song <yhs@fb.com> > > Cc: John Fastabend <john.fastabend@gmail.com> > > Cc: KP Singh <kpsingh@kernel.org> > > Cc: Eric Dumazet <edumazet@google.com> > > Cc: Antoine Tenart <atenart@kernel.org> > > Cc: Alexander Lobakin <alexandr.lobakin@intel.com> > > Cc: Wei Wang <weiwan@google.com> > > Cc: Arnd Bergmann <arnd@arndb.de> > > -- > > 2.27.0 > > Al
From: Tonghao Zhang <xiangxia.m.yue@gmail.com> This patchset try to fix bpf_redirect to ifb netdev. Prevent packets loopback and perfromance drop, add check in sch egress. Tonghao Zhang (3): net: core: set skb useful vars in __bpf_tx_skb net: sched: add check tc_skip_classify in sch egress selftests: bpf: add bpf_redirect to ifb net/core/dev.c | 3 + net/core/filter.c | 12 ++- tools/testing/selftests/bpf/Makefile | 1 + .../bpf/progs/test_bpf_redirect_ifb.c | 13 ++++ .../selftests/bpf/test_bpf_redirect_ifb.sh | 73 +++++++++++++++++++ 5 files changed, 101 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/bpf/progs/test_bpf_redirect_ifb.c create mode 100755 tools/testing/selftests/bpf/test_bpf_redirect_ifb.sh