| Message ID | 20211027162806.2014022-1-markyacoub@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/mediatek: Set the default value of rotation to DRM_MODE_ROTATE_0 | expand |
Hi Mark: Mark Yacoub <markyacoub@chromium.org> 於 2021年10月28日 週四 上午12:28寫道： > > From: Mark Yacoub <markyacoub@google.com> > > At the reset hook, call __drm_atomic_helper_plane_reset which is > called at the initialization of the plane and sets the default value of > rotation on all planes to DRM_MODE_ROTATE_0 which is equal to 1. This patch looks good to me, but please fix this checkpatch warning: WARNING: From:/Signed-off-by: email address mismatch: 'From: Mark Yacoub <markyacoub@google.com>' != 'Signed-off-by: Mark Yacoub <markyacoub@chromium.org>' total: 0 errors, 1 warnings, 11 lines checked Regards, Chun-Kuang. > > Tested on Jacuzzi (MTK). > Resolves IGT@kms_properties@plane-properties-{legacy,atomic} > > Signed-off-by: Mark Yacoub <markyacoub@chromium.org> > --- > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > index e6dcb34d30522..accd26481b9fb 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > @@ -44,9 +44,10 @@ static void mtk_plane_reset(struct drm_plane *plane) > state = kzalloc(sizeof(*state), GFP_KERNEL); > if (!state) > return; > - plane->state = &state->base; > } > > + __drm_atomic_helper_plane_reset(plane, &state->base); > + > state->base.plane = plane; > state->pending.format = DRM_FORMAT_RGB565; > } > -- > 2.33.0.1079.g6e70778dc9-goog >
On Wed, Dec 8, 2021 at 7:16 PM Chun-Kuang Hu <chunkuang.hu@kernel.org> wrote: > > Hi Mark: > > Mark Yacoub <markyacoub@chromium.org> 於 2021年10月28日 週四 上午12:28寫道： > > > > From: Mark Yacoub <markyacoub@google.com> > > > > At the reset hook, call __drm_atomic_helper_plane_reset which is > > called at the initialization of the plane and sets the default value of > > rotation on all planes to DRM_MODE_ROTATE_0 which is equal to 1. > > This patch looks good to me, but please fix this checkpatch warning: Uploaded a new revision. Thanks! > > WARNING: From:/Signed-off-by: email address mismatch: 'From: Mark > Yacoub <markyacoub@google.com>' != 'Signed-off-by: Mark Yacoub > <markyacoub@chromium.org>' > > total: 0 errors, 1 warnings, 11 lines checked > > Regards, > Chun-Kuang. > > > > > Tested on Jacuzzi (MTK). > > Resolves IGT@kms_properties@plane-properties-{legacy,atomic} > > > > Signed-off-by: Mark Yacoub <markyacoub@chromium.org> > > --- > > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > > index e6dcb34d30522..accd26481b9fb 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > > @@ -44,9 +44,10 @@ static void mtk_plane_reset(struct drm_plane *plane) > > state = kzalloc(sizeof(*state), GFP_KERNEL); > > if (!state) > > return; > > - plane->state = &state->base; > > } > > > > + __drm_atomic_helper_plane_reset(plane, &state->base); > > + > > state->base.plane = plane; > > state->pending.format = DRM_FORMAT_RGB565; > > } > > -- > > 2.33.0.1079.g6e70778dc9-goog > >
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c index e6dcb34d30522..accd26481b9fb 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c @@ -44,9 +44,10 @@ static void mtk_plane_reset(struct drm_plane *plane) state = kzalloc(sizeof(*state), GFP_KERNEL); if (!state) return; - plane->state = &state->base; } + __drm_atomic_helper_plane_reset(plane, &state->base); + state->base.plane = plane; state->pending.format = DRM_FORMAT_RGB565; }