diff mbox series

[[PATCH,V2] 2/2] mmc:sdhci-pci-o2micro:Change implementation of setting corresponding PLL frequency according to card mode

Message ID 20211206131507.411-2-fred.ai@bayhubtech.com (mailing list archive)
State New, archived
Headers show
Series [[PATCH,V2] 2/2] mmc:sdhci-pci-o2micro:Change implementation of setting corresponding PLL frequency according to card mode | expand

Commit Message

Fred Ai(WH) Dec. 6, 2021, 1:15 p.m. UTC
From: "fred.ai" <fred.ai@bayhubtech.com>

Driver will set PLL frequency by different card mode
1.SD2.0 and SDR50 card mode base clock frequency is 208MHz
2.SDR104 card mode base clock frequency is 200MHz

Signed-off-by: fred.ai <fred.ai@bayhubtech.com>

Change in V2:
---
After SD2.0 or SDR50 card initlization, driver will select base clock frequency 200MHz
by setting PLL frequency value 0x2510.
---
 drivers/mmc/host/sdhci-pci-o2micro.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Adrian Hunter Dec. 14, 2021, 9:53 a.m. UTC | #1
On 06/12/2021 15:15, fred wrote:
> From: "fred.ai" <fred.ai@bayhubtech.com>
> 
> Driver will set PLL frequency by different card mode
> 1.SD2.0 and SDR50 card mode base clock frequency is 208MHz
> 2.SDR104 card mode base clock frequency is 200MHz

Again the subject needs improvement, should have been like:

[PATCH V2 2/2] mmc: sdhci-pci-o2micro: Change implementation of setting corresponding PLL frequency according to card mode

> 
> Signed-off-by: fred.ai <fred.ai@bayhubtech.com>
> 
> Change in V2:
> ---

This '---' here causes the "Change in V2:" alone to be in the
commit message.  Better to put it after the signed-off line.

> After SD2.0 or SDR50 card initlization, driver will select base clock frequency 200MHz
> by setting PLL frequency value 0x2510.
> ---
>  drivers/mmc/host/sdhci-pci-o2micro.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c b/drivers/mmc/host/sdhci-pci-o2micro.c
> index 98c1a17eb619..4d79fda10dcb 100644
> --- a/drivers/mmc/host/sdhci-pci-o2micro.c
> +++ b/drivers/mmc/host/sdhci-pci-o2micro.c
> @@ -569,8 +569,16 @@ static void sdhci_pci_o2_set_clock(struct sdhci_host *host, unsigned int clock)
>  	if ((host->timing == MMC_TIMING_UHS_SDR104) && (clock == 200000000)) {
>  		pci_read_config_dword(chip->pdev, O2_SD_PLL_SETTING, &scratch_32);
>  
> +		/* SDR104 card mode PLL frequency value is 0x2c28 */
>  		if ((scratch_32 & 0xFFFF0000) != 0x2c280000)
>  			o2_pci_set_baseclk(chip, 0x2c280000);
> +
> +	} else {
> +		pci_read_config_dword(chip->pdev, O2_SD_PLL_SETTING, &scratch_32);
> +
> +		/* SD2.0,SDR50 card mode PLL frequency value is 0X2510 */
> +		if ((scratch_32 & 0xFFFF0000) != 0x2510000)
> +			o2_pci_set_baseclk(chip, 0x25100000);
>  	}
>  
>  	pci_read_config_dword(chip->pdev, O2_SD_OUTPUT_CLK_SOURCE_SWITCH, &scratch_32);
>
diff mbox series

Patch

diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c b/drivers/mmc/host/sdhci-pci-o2micro.c
index 98c1a17eb619..4d79fda10dcb 100644
--- a/drivers/mmc/host/sdhci-pci-o2micro.c
+++ b/drivers/mmc/host/sdhci-pci-o2micro.c
@@ -569,8 +569,16 @@  static void sdhci_pci_o2_set_clock(struct sdhci_host *host, unsigned int clock)
 	if ((host->timing == MMC_TIMING_UHS_SDR104) && (clock == 200000000)) {
 		pci_read_config_dword(chip->pdev, O2_SD_PLL_SETTING, &scratch_32);
 
+		/* SDR104 card mode PLL frequency value is 0x2c28 */
 		if ((scratch_32 & 0xFFFF0000) != 0x2c280000)
 			o2_pci_set_baseclk(chip, 0x2c280000);
+
+	} else {
+		pci_read_config_dword(chip->pdev, O2_SD_PLL_SETTING, &scratch_32);
+
+		/* SD2.0,SDR50 card mode PLL frequency value is 0X2510 */
+		if ((scratch_32 & 0xFFFF0000) != 0x2510000)
+			o2_pci_set_baseclk(chip, 0x25100000);
 	}
 
 	pci_read_config_dword(chip->pdev, O2_SD_OUTPUT_CLK_SOURCE_SWITCH, &scratch_32);