| Message ID | 20211213071407.314309-3-ltykernel@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | x86/Hyper-V: Add Hyper-V Isolation VM support(Second part) | expand |
On Mon, Dec 13, 2021 at 02:14:03AM -0500, Tianyu Lan wrote: > From: Tianyu Lan <Tianyu.Lan@microsoft.com> > > Hyper-V provides Isolation VM for confidential computing support and > guest memory is encrypted in it. Places checking cc_platform_has() > with GUEST_MEM_ENCRYPT attr should return "True" in Isolation vm. e.g, > swiotlb bounce buffer size needs to adjust according to memory size > in the sev_setup_arch(). Add GUEST_MEM_ENCRYPT check for Hyper-V Isolation > VM. > > Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com> x86 maintainers, any comment on this patch? > --- > Change since v6: > * Change the order in the cc_platform_has() and check sev first. > > Change since v3: > * Change code style of checking GUEST_MEM attribute in the > hyperv_cc_platform_has(). > --- > arch/x86/kernel/cc_platform.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/x86/kernel/cc_platform.c b/arch/x86/kernel/cc_platform.c > index 03bb2f343ddb..6cb3a675e686 100644 > --- a/arch/x86/kernel/cc_platform.c > +++ b/arch/x86/kernel/cc_platform.c > @@ -11,6 +11,7 @@ > #include <linux/cc_platform.h> > #include <linux/mem_encrypt.h> > > +#include <asm/mshyperv.h> > #include <asm/processor.h> > > static bool __maybe_unused intel_cc_platform_has(enum cc_attr attr) > @@ -58,12 +59,19 @@ static bool amd_cc_platform_has(enum cc_attr attr) > #endif > } > > +static bool hyperv_cc_platform_has(enum cc_attr attr) > +{ > + return attr == CC_ATTR_GUEST_MEM_ENCRYPT; > +} > > bool cc_platform_has(enum cc_attr attr) > { > if (sme_me_mask) > return amd_cc_platform_has(attr); > > + if (hv_is_isolation_supported()) > + return hyperv_cc_platform_has(attr); > + > return false; > } > EXPORT_SYMBOL_GPL(cc_platform_has); > -- > 2.25.1 >
On Mon, Dec 13, 2021 at 02:14:03AM -0500, Tianyu Lan wrote: > From: Tianyu Lan <Tianyu.Lan@microsoft.com> > > Hyper-V provides Isolation VM for confidential computing support and > guest memory is encrypted in it. Places checking cc_platform_has() > with GUEST_MEM_ENCRYPT attr should return "True" in Isolation vm. e.g, Stick to a single spelling variant: "VM". > swiotlb bounce buffer size needs to adjust according to memory size > in the sev_setup_arch(). So basically you wanna simply say here: "Hyper-V Isolation VMs need to adjust the SWIOTLB size just like SEV guests. Add a hyperv_cc_platform_has() variant which enables that." ? With that addressed you can have my Acked-by: Borislav Petkov <bp@suse.de> Thx.
On Tue, Dec 14, 2021 at 05:05:01PM +0100, Borislav Petkov wrote: > On Mon, Dec 13, 2021 at 02:14:03AM -0500, Tianyu Lan wrote: > > From: Tianyu Lan <Tianyu.Lan@microsoft.com> > > > > Hyper-V provides Isolation VM for confidential computing support and > > guest memory is encrypted in it. Places checking cc_platform_has() > > with GUEST_MEM_ENCRYPT attr should return "True" in Isolation vm. e.g, > > Stick to a single spelling variant: "VM". > > > swiotlb bounce buffer size needs to adjust according to memory size > > in the sev_setup_arch(). > > So basically you wanna simply say here: > > "Hyper-V Isolation VMs need to adjust the SWIOTLB size just like SEV > guests. Add a hyperv_cc_platform_has() variant which enables that." > > ? > > With that addressed you can have my > > Acked-by: Borislav Petkov <bp@suse.de> Thanks. I can address your comments when I pick up this series. Wei. > > Thx. > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette
diff --git a/arch/x86/kernel/cc_platform.c b/arch/x86/kernel/cc_platform.c index 03bb2f343ddb..6cb3a675e686 100644 --- a/arch/x86/kernel/cc_platform.c +++ b/arch/x86/kernel/cc_platform.c @@ -11,6 +11,7 @@ #include <linux/cc_platform.h> #include <linux/mem_encrypt.h> +#include <asm/mshyperv.h> #include <asm/processor.h> static bool __maybe_unused intel_cc_platform_has(enum cc_attr attr) @@ -58,12 +59,19 @@ static bool amd_cc_platform_has(enum cc_attr attr) #endif } +static bool hyperv_cc_platform_has(enum cc_attr attr) +{ + return attr == CC_ATTR_GUEST_MEM_ENCRYPT; +} bool cc_platform_has(enum cc_attr attr) { if (sme_me_mask) return amd_cc_platform_has(attr); + if (hv_is_isolation_supported()) + return hyperv_cc_platform_has(attr); + return false; } EXPORT_SYMBOL_GPL(cc_platform_has);