[v3,net-next,0/4] fib: merge nl policies

Message

Florian Westphal Dec. 15, 2021, 11:32 a.m. UTC

v3: drop first two patches, otherwise unchanged.

This series merges the different (largely identical) nla policies.

v2 also squashed the ->suppress() implementation, I've dropped this.
Problem is that it needs ugly ifdef'ry to avoid build breakage
with CONFIG_INET=n || IPV6=n.

Given that even microbenchmark doesn't show any noticeable improvement
when ->suppress is inlined (it uses INDIRECT_CALLABLE) i decided to toss
the patch instead of adding more ifdefs.

Florian Westphal (2):
  fib: rules: remove duplicated nla policies
  fib: expand fib_rule_policy

 include/net/fib_rules.h | 21 ---------------------
 net/core/fib_rules.c    | 25 +++++++++++++++++++++++--
 net/decnet/dn_rules.c   |  5 -----
 net/ipv4/fib_rules.c    |  6 ------
 net/ipv4/ipmr.c         |  5 -----
 net/ipv6/fib6_rules.c   |  5 -----
 net/ipv6/ip6mr.c        |  5 -----
 7 files changed, 23 insertions(+), 49 deletions(-)

Comments

Jakub Kicinski Dec. 16, 2021, 2:51 a.m. UTC | #1

On Wed, 15 Dec 2021 12:32:40 +0100 Florian Westphal wrote:
> v3: drop first two patches, otherwise unchanged.
> 
> This series merges the different (largely identical) nla policies.
> 
> v2 also squashed the ->suppress() implementation, I've dropped this.
> Problem is that it needs ugly ifdef'ry to avoid build breakage
> with CONFIG_INET=n || IPV6=n.
> 
> Given that even microbenchmark doesn't show any noticeable improvement
> when ->suppress is inlined (it uses INDIRECT_CALLABLE) i decided to toss
> the patch instead of adding more ifdefs.

Would you mind resending? Patchwork thinks the series is incomplete
because the cover letter says 0/4 instead of 0/2.