| Message ID | 20211212181057.20210-1-semen.protsenko@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ac18935d2e5130744b9675f6fb72acb783f86d77 |
| Headers | show |
| Series | i2c: exynos5: Fix getting the optional clock | expand |
On 12/12/2021 19:10, Sam Protsenko wrote: > "hsi2c_pclk" clock is optional and may not be present for some SoCs > supported by this driver. Nevertheless, in case the clock is provided > but some error happens during its getting, that error should be handled > properly. Use devm_clk_get_optional() API for that. Also report possible > errors using dev_err_probe() to handle properly -EPROBE_DEFER error (if > clock provider is not ready by the time I2C probe function is executed). > > Fixes: c93ac09df2a8 ("i2c: exynos5: Add bus clock support") > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > --- > drivers/i2c/busses/i2c-exynos5.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof
> "hsi2c_pclk" clock is optional and may not be present for some SoCs > supported by this driver. Nevertheless, in case the clock is provided but > some error happens during its getting, that error should be handled > properly. Use devm_clk_get_optional() API for that. Also report possible > errors using dev_err_probe() to handle properly -EPROBE_DEFER error (if > clock provider is not ready by the time I2C probe function is executed). > > Fixes: c93ac09df2a8 ("i2c: exynos5: Add bus clock support") > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> Reviewed-by: Chanho Park <chanho61.park@samsung.com>
On Sun, Dec 12, 2021 at 08:10:57PM +0200, Sam Protsenko wrote: > "hsi2c_pclk" clock is optional and may not be present for some SoCs > supported by this driver. Nevertheless, in case the clock is provided > but some error happens during its getting, that error should be handled > properly. Use devm_clk_get_optional() API for that. Also report possible > errors using dev_err_probe() to handle properly -EPROBE_DEFER error (if > clock provider is not ready by the time I2C probe function is executed). > > Fixes: c93ac09df2a8 ("i2c: exynos5: Add bus clock support") > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> Applied to for-next, thanks! But I needed to fix the Fixes tag?
On Thu, 16 Dec 2021 at 23:22, Wolfram Sang <wsa@kernel.org> wrote: > > On Sun, Dec 12, 2021 at 08:10:57PM +0200, Sam Protsenko wrote: > > "hsi2c_pclk" clock is optional and may not be present for some SoCs > > supported by this driver. Nevertheless, in case the clock is provided > > but some error happens during its getting, that error should be handled > > properly. Use devm_clk_get_optional() API for that. Also report possible > > errors using dev_err_probe() to handle properly -EPROBE_DEFER error (if > > clock provider is not ready by the time I2C probe function is executed). > > > > Fixes: c93ac09df2a8 ("i2c: exynos5: Add bus clock support") > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > > Applied to for-next, thanks! But I needed to fix the Fixes tag? > Ah, sorry about that! I probably looked at some other tree. Thanks for applying!
diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c index 693903e80892..b812d1090c0f 100644 --- a/drivers/i2c/busses/i2c-exynos5.c +++ b/drivers/i2c/busses/i2c-exynos5.c @@ -814,9 +814,11 @@ static int exynos5_i2c_probe(struct platform_device *pdev) return -ENOENT; } - i2c->pclk = devm_clk_get(&pdev->dev, "hsi2c_pclk"); - if (IS_ERR(i2c->pclk)) - i2c->pclk = NULL; /* pclk is optional */ + i2c->pclk = devm_clk_get_optional(&pdev->dev, "hsi2c_pclk"); + if (IS_ERR(i2c->pclk)) { + return dev_err_probe(&pdev->dev, PTR_ERR(i2c->pclk), + "cannot get pclk"); + } ret = clk_prepare_enable(i2c->pclk); if (ret)
"hsi2c_pclk" clock is optional and may not be present for some SoCs supported by this driver. Nevertheless, in case the clock is provided but some error happens during its getting, that error should be handled properly. Use devm_clk_get_optional() API for that. Also report possible errors using dev_err_probe() to handle properly -EPROBE_DEFER error (if clock provider is not ready by the time I2C probe function is executed). Fixes: c93ac09df2a8 ("i2c: exynos5: Add bus clock support") Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> --- drivers/i2c/busses/i2c-exynos5.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)