| Message ID | 20211213212650.2067066-1-luiz.dentz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Luiz Von Dentz |
| Headers | show |
| Series | Bluetooth: mgmt: Fix mgmt_device_found panic | expand |
Hi Marcel, On Mon, Dec 13, 2021 at 2:07 PM <bluez.test.bot@gmail.com> wrote: > > This is automated email and please do not reply to this email! > > Dear submitter, > > Thank you for submitting the patches to the linux bluetooth mailing list. > This is a CI test results with your patch series: > PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=595033 > > ---Test result--- > > Test Summary: > CheckPatch FAIL 1.63 seconds > GitLint FAIL 0.92 seconds > BuildKernel PASS 317.18 seconds > Incremental Build with patchesPASS 321.54 seconds > TestRunner: Setup PASS 454.37 seconds > TestRunner: l2cap-tester PASS 11.79 seconds > TestRunner: bnep-tester PASS 5.89 seconds > TestRunner: mgmt-tester PASS 112.27 seconds > TestRunner: rfcomm-tester PASS 7.41 seconds > TestRunner: sco-tester PASS 7.54 seconds > TestRunner: smp-tester PASS 7.34 seconds > TestRunner: userchan-tester PASS 6.14 seconds > > Details > ############################## > Test: CheckPatch - FAIL - 1.63 seconds > Run checkpatch.pl script with rule in .checkpatch.conf > Bluetooth: mgmt: Fix mgmt_device_found panic\WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) > #103: > FS: 0000000000000000(0000) GS:ffffffff8c097000(0000) knlGS:0000000000000000 > > total: 0 errors, 1 warnings, 0 checks, 16 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > /github/workspace/src/12674615.patch has style problems, please review. > > NOTE: Ignored message types: UNKNOWN_COMMIT_ID > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > > ############################## > Test: GitLint - FAIL - 0.92 seconds > Run gitlint with rule in .gitlint > Bluetooth: mgmt: Fix mgmt_device_found panic > 77: B1 Line exceeds max length (97>80): "Fixes: 2023db7e3a343 ("Bluetooth: mgmt: Make use of mgmt_send_event_skb in MGMT_EV_DEVICE_FOUND")" Can you please fixup/squash this one, this is breaking inquiry response processing.
Hi Marcel, On Fri, Dec 17, 2021 at 4:44 PM Manish Mandlik <mmandlik@google.com> wrote: > > > > On Fri, Dec 17, 2021 at 5:43 PM Luiz Augusto von Dentz <luiz.dentz@gmail.com> wrote: >> >> Hi Marcel, >> >> On Mon, Dec 13, 2021 at 2:07 PM <bluez.test.bot@gmail.com> wrote: >> > >> > This is automated email and please do not reply to this email! >> > >> > Dear submitter, >> > >> > Thank you for submitting the patches to the linux bluetooth mailing list. >> > This is a CI test results with your patch series: >> > PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=595033 >> > >> > ---Test result--- >> > >> > Test Summary: >> > CheckPatch FAIL 1.63 seconds >> > GitLint FAIL 0.92 seconds >> > BuildKernel PASS 317.18 seconds >> > Incremental Build with patchesPASS 321.54 seconds >> > TestRunner: Setup PASS 454.37 seconds >> > TestRunner: l2cap-tester PASS 11.79 seconds >> > TestRunner: bnep-tester PASS 5.89 seconds >> > TestRunner: mgmt-tester PASS 112.27 seconds >> > TestRunner: rfcomm-tester PASS 7.41 seconds >> > TestRunner: sco-tester PASS 7.54 seconds >> > TestRunner: smp-tester PASS 7.34 seconds >> > TestRunner: userchan-tester PASS 6.14 seconds >> > >> > Details >> > ############################## >> > Test: CheckPatch - FAIL - 1.63 seconds >> > Run checkpatch.pl script with rule in .checkpatch.conf >> > Bluetooth: mgmt: Fix mgmt_device_found panic\WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) >> > #103: >> > FS: 0000000000000000(0000) GS:ffffffff8c097000(0000) knlGS:0000000000000000 >> > >> > total: 0 errors, 1 warnings, 0 checks, 16 lines checked >> > >> > NOTE: For some of the reported defects, checkpatch may be able to >> > mechanically convert to the typical style using --fix or --fix-inplace. >> > >> > /github/workspace/src/12674615.patch has style problems, please review. >> > >> > NOTE: Ignored message types: UNKNOWN_COMMIT_ID >> > >> > NOTE: If any of the errors are false positives, please report >> > them to the maintainer, see CHECKPATCH in MAINTAINERS. >> > >> > >> > ############################## >> > Test: GitLint - FAIL - 0.92 seconds >> > Run gitlint with rule in .gitlint >> > Bluetooth: mgmt: Fix mgmt_device_found panic >> > 77: B1 Line exceeds max length (97>80): "Fixes: 2023db7e3a343 ("Bluetooth: mgmt: Make use of mgmt_send_event_skb in MGMT_EV_DEVICE_FOUND")" >> >> Can you please fixup/squash this one, this is breaking inquiry >> response processing. >> >> -- >> Luiz Augusto von Dentz > > > Tested-by: Manish Mandlik <mmandlik@google.com> Ping, we really need to fix this up.
Hi Marcel, On Mon, Dec 20, 2021 at 1:07 PM Luiz Augusto von Dentz <luiz.dentz@gmail.com> wrote: > > Hi Marcel, > > On Fri, Dec 17, 2021 at 4:44 PM Manish Mandlik <mmandlik@google.com> wrote: > > > > > > > > On Fri, Dec 17, 2021 at 5:43 PM Luiz Augusto von Dentz <luiz.dentz@gmail.com> wrote: > >> > >> Hi Marcel, > >> > >> On Mon, Dec 13, 2021 at 2:07 PM <bluez.test.bot@gmail.com> wrote: > >> > > >> > This is automated email and please do not reply to this email! > >> > > >> > Dear submitter, > >> > > >> > Thank you for submitting the patches to the linux bluetooth mailing list. > >> > This is a CI test results with your patch series: > >> > PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=595033 > >> > > >> > ---Test result--- > >> > > >> > Test Summary: > >> > CheckPatch FAIL 1.63 seconds > >> > GitLint FAIL 0.92 seconds > >> > BuildKernel PASS 317.18 seconds > >> > Incremental Build with patchesPASS 321.54 seconds > >> > TestRunner: Setup PASS 454.37 seconds > >> > TestRunner: l2cap-tester PASS 11.79 seconds > >> > TestRunner: bnep-tester PASS 5.89 seconds > >> > TestRunner: mgmt-tester PASS 112.27 seconds > >> > TestRunner: rfcomm-tester PASS 7.41 seconds > >> > TestRunner: sco-tester PASS 7.54 seconds > >> > TestRunner: smp-tester PASS 7.34 seconds > >> > TestRunner: userchan-tester PASS 6.14 seconds > >> > > >> > Details > >> > ############################## > >> > Test: CheckPatch - FAIL - 1.63 seconds > >> > Run checkpatch.pl script with rule in .checkpatch.conf > >> > Bluetooth: mgmt: Fix mgmt_device_found panic\WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) > >> > #103: > >> > FS: 0000000000000000(0000) GS:ffffffff8c097000(0000) knlGS:0000000000000000 > >> > > >> > total: 0 errors, 1 warnings, 0 checks, 16 lines checked > >> > > >> > NOTE: For some of the reported defects, checkpatch may be able to > >> > mechanically convert to the typical style using --fix or --fix-inplace. > >> > > >> > /github/workspace/src/12674615.patch has style problems, please review. > >> > > >> > NOTE: Ignored message types: UNKNOWN_COMMIT_ID > >> > > >> > NOTE: If any of the errors are false positives, please report > >> > them to the maintainer, see CHECKPATCH in MAINTAINERS. > >> > > >> > > >> > ############################## > >> > Test: GitLint - FAIL - 0.92 seconds > >> > Run gitlint with rule in .gitlint > >> > Bluetooth: mgmt: Fix mgmt_device_found panic > >> > 77: B1 Line exceeds max length (97>80): "Fixes: 2023db7e3a343 ("Bluetooth: mgmt: Make use of mgmt_send_event_skb in MGMT_EV_DEVICE_FOUND")" > >> > >> Can you please fixup/squash this one, this is breaking inquiry > >> response processing. > >> > >> -- > >> Luiz Augusto von Dentz > > > > > > Tested-by: Manish Mandlik <mmandlik@google.com> > > Ping, we really need to fix this up. > > -- > Luiz Augusto von Dentz Ive fixed the original patch and pushed to bluetooth-next.
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c index 4e1557281956..3326d9459dd3 100644 --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c @@ -9601,7 +9601,7 @@ void mgmt_device_found(struct hci_dev *hdev, bdaddr_t *bdaddr, u8 link_type, /* Allocate skb. The 5 extra bytes are for the potential CoD field */ skb = mgmt_alloc_skb(hdev, MGMT_EV_DEVICE_FOUND, - sizeof(ev) + eir_len + scan_rsp_len + 5); + sizeof(*ev) + eir_len + scan_rsp_len + 5); if (!skb) return; @@ -9633,7 +9633,7 @@ void mgmt_device_found(struct hci_dev *hdev, bdaddr_t *bdaddr, u8 link_type, eir_len += eir_append_data(eir_cod, 0, EIR_CLASS_OF_DEV, dev_class, 3); - skb_put_data(skb, eir_cod, eir_len); + skb_put_data(skb, eir_cod, sizeof(eir_cod)); } if (scan_rsp_len > 0)