| Message ID | 20211216201342.25587-12-luizluca@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: realtek: MDIO interface and RTL8367S | expand |
On Thu, Dec 16, 2021 at 9:14 PM <luizluca@gmail.com> wrote: > From: Luiz Angelo Daros de Luca <luizluca@gmail.com> > > Tested-by: Arınç ÜNAL <arinc.unal@arinc9.com> > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On 12/16/2021 12:13 PM, luizluca@gmail.com wrote: > From: Luiz Angelo Daros de Luca <luizluca@gmail.com> > > Tested-by: Arınç ÜNAL <arinc.unal@arinc9.com> > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> > --- > drivers/net/dsa/realtek/rtl8367c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/realtek/rtl8367c.c b/drivers/net/dsa/realtek/rtl8367c.c > index 6aca48165d1f..f370ea948c59 100644 > --- a/drivers/net/dsa/realtek/rtl8367c.c > +++ b/drivers/net/dsa/realtek/rtl8367c.c > @@ -1955,7 +1955,7 @@ static int rtl8367c_detect(struct realtek_priv *priv) > mb->priv = priv; > mb->chip_id = chip_id; > mb->chip_ver = chip_ver; > - mb->port_mask = BIT(priv->num_ports) - 1; > + mb->port_mask = GENMASK(priv->num_ports-1,0); Missing spaces between priv->num_ports, and -1 here, and the comma before 0 as well: mb->port_mask = GENMASK(priv->num_ports - 1, 0); is what we would expect to see.
> > Missing spaces between priv->num_ports, and -1 here, and the comma > before 0 as well: > mb->port_mask = GENMASK(priv->num_ports - 1, 0); > > is what we would expect to see. v2 fixed that. Did I mess with v2 submission? https://patchwork.kernel.org/project/netdevbpf/patch/20211218081425.18722-11-luizluca@gmail.com/ > -- > Florian
diff --git a/drivers/net/dsa/realtek/rtl8367c.c b/drivers/net/dsa/realtek/rtl8367c.c index 6aca48165d1f..f370ea948c59 100644 --- a/drivers/net/dsa/realtek/rtl8367c.c +++ b/drivers/net/dsa/realtek/rtl8367c.c @@ -1955,7 +1955,7 @@ static int rtl8367c_detect(struct realtek_priv *priv) mb->priv = priv; mb->chip_id = chip_id; mb->chip_ver = chip_ver; - mb->port_mask = BIT(priv->num_ports) - 1; + mb->port_mask = GENMASK(priv->num_ports-1,0); mb->learn_limit_max = RTL8367C_LEARN_LIMIT_MAX; mb->jam_table = rtl8367c_init_jam_8367c; mb->jam_size = ARRAY_SIZE(rtl8367c_init_jam_8367c);