| Message ID | a9453065c2e89d79fc117363fe41fa10986e06d1.1640113138.git.steadmon@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a644f898ce6c9184d8b2f466e22dfed00f668102 |
| Headers | show |
| Series | [v2] l10n: README: call more attention to plural strings | expand |
Josh Steadmon <steadmon@google.com> writes: > In po/README.md, we point core developers to gettext's "Preparing > Strings" documentation for advice on marking strings for translation. > However, this doc doesn't really discuss the issues around plural form > translation, which can make it seem that nothing special needs to be > done in this case. > > Add a specific callout here about marking plural-form strings so that > the advice later on in the README is not overlooked. > > Signed-off-by: Josh Steadmon <steadmon@google.com> > --- > po/README.md | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/po/README.md b/po/README.md > index dcd8436c25..19fabb4acf 100644 > --- a/po/README.md > +++ b/po/README.md > @@ -221,6 +221,10 @@ General advice: > - Adjust the strings so that they're easy to translate. Most of the > advice in `info '(gettext)Preparing Strings'` applies here. > > +- Strings referencing numbers of items may need to be split into singular and > + plural forms; see the Q\_() wrapper in the C sub-section below for an > + example. > + > - If something is unclear or ambiguous you can use a "TRANSLATORS" > comment to tell the translators what to make of it. These will be > extracted by xgettext(1) and put in the "po/\*.po" files, e.g. from > > base-commit: cd3e606211bb1cf8bc57f7d76bab98cc17a150bc Looks sensible to me. I do not mind taking this myself, instead of getting it via our i18n manager, if Jiang is OK with it. Thanks.
On Wed, Dec 22, 2021 at 4:55 AM Junio C Hamano <gitster@pobox.com> wrote: > > Josh Steadmon <steadmon@google.com> writes: > > > In po/README.md, we point core developers to gettext's "Preparing > > Strings" documentation for advice on marking strings for translation. > > However, this doc doesn't really discuss the issues around plural form > > translation, which can make it seem that nothing special needs to be > > done in this case. > > > > Add a specific callout here about marking plural-form strings so that > > the advice later on in the README is not overlooked. > > > > Signed-off-by: Josh Steadmon <steadmon@google.com> > > --- > > po/README.md | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/po/README.md b/po/README.md > > index dcd8436c25..19fabb4acf 100644 > > --- a/po/README.md > > +++ b/po/README.md > > @@ -221,6 +221,10 @@ General advice: > > - Adjust the strings so that they're easy to translate. Most of the > > advice in `info '(gettext)Preparing Strings'` applies here. > > > > +- Strings referencing numbers of items may need to be split into singular and > > + plural forms; see the Q\_() wrapper in the C sub-section below for an > > + example. > > + > > - If something is unclear or ambiguous you can use a "TRANSLATORS" > > comment to tell the translators what to make of it. These will be > > extracted by xgettext(1) and put in the "po/\*.po" files, e.g. from > > > > base-commit: cd3e606211bb1cf8bc57f7d76bab98cc17a150bc > > Looks sensible to me. > > I do not mind taking this myself, instead of getting it via our i18n > manager, if Jiang is OK with it. Look good to me, and please help merge, otherwise the patch will have to wait about 1 month for the next l10n window. -- Jiang Xin
diff --git a/po/README.md b/po/README.md index dcd8436c25..19fabb4acf 100644 --- a/po/README.md +++ b/po/README.md @@ -221,6 +221,10 @@ General advice: - Adjust the strings so that they're easy to translate. Most of the advice in `info '(gettext)Preparing Strings'` applies here. +- Strings referencing numbers of items may need to be split into singular and + plural forms; see the Q\_() wrapper in the C sub-section below for an + example. + - If something is unclear or ambiguous you can use a "TRANSLATORS" comment to tell the translators what to make of it. These will be extracted by xgettext(1) and put in the "po/\*.po" files, e.g. from
In po/README.md, we point core developers to gettext's "Preparing Strings" documentation for advice on marking strings for translation. However, this doc doesn't really discuss the issues around plural form translation, which can make it seem that nothing special needs to be done in this case. Add a specific callout here about marking plural-form strings so that the advice later on in the README is not overlooked. Signed-off-by: Josh Steadmon <steadmon@google.com> --- po/README.md | 4 ++++ 1 file changed, 4 insertions(+) base-commit: cd3e606211bb1cf8bc57f7d76bab98cc17a150bc