| Message ID | 20211222075944.1142953-1-jiasheng@iscas.ac.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Commit | 99d7fbb5cedf598f67e8be106d6c7b8d91366aef |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: ks8851: Check for error irq | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Wed, 22 Dec 2021 15:59:44 +0800 you wrote: > Because platform_get_irq() could fail and return error irq. > Therefore, it might be better to check it if order to avoid the use of > error irq. > > Fixes: 797047f875b5 ("net: ks8851: Implement Parallel bus operations") > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> > > [...] Here is the summary with links: - net: ks8851: Check for error irq https://git.kernel.org/netdev/net/c/99d7fbb5cedf You are awesome, thank you!
diff --git a/drivers/net/ethernet/micrel/ks8851_par.c b/drivers/net/ethernet/micrel/ks8851_par.c index 2e8fcce50f9d..c6f517c07bb9 100644 --- a/drivers/net/ethernet/micrel/ks8851_par.c +++ b/drivers/net/ethernet/micrel/ks8851_par.c @@ -321,6 +321,8 @@ static int ks8851_probe_par(struct platform_device *pdev) return ret; netdev->irq = platform_get_irq(pdev, 0); + if (netdev->irq < 0) + return netdev->irq; return ks8851_probe_common(netdev, dev, msg_enable); }
Because platform_get_irq() could fail and return error irq. Therefore, it might be better to check it if order to avoid the use of error irq. Fixes: 797047f875b5 ("net: ks8851: Implement Parallel bus operations") Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> --- drivers/net/ethernet/micrel/ks8851_par.c | 2 ++ 1 file changed, 2 insertions(+)