| Message ID | 20211222074112.1119564-1-jiasheng@iscas.ac.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Commit | cb93b3e11d405f20a405a07482d01147ef4934a3 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | drivers: net: smc911x: Check for error irq | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Wed, 22 Dec 2021 15:41:12 +0800 you wrote: > Because platform_get_irq() could fail and return error irq. > Therefore, it might be better to check it if order to avoid the use of > error irq. > > Fixes: ae150435b59e ("smsc: Move the SMC (SMSC) drivers") > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> > > [...] Here is the summary with links: - drivers: net: smc911x: Check for error irq https://git.kernel.org/netdev/net/c/cb93b3e11d40 You are awesome, thank you!
diff --git a/drivers/net/ethernet/smsc/smc911x.c b/drivers/net/ethernet/smsc/smc911x.c index 22cdbf12c823..ce05d79528d7 100644 --- a/drivers/net/ethernet/smsc/smc911x.c +++ b/drivers/net/ethernet/smsc/smc911x.c @@ -2070,6 +2070,11 @@ static int smc911x_drv_probe(struct platform_device *pdev) ndev->dma = (unsigned char)-1; ndev->irq = platform_get_irq(pdev, 0); + if (ndev->irq < 0) { + ret = ndev->irq; + goto release_both; + } + lp = netdev_priv(ndev); lp->netdev = ndev; #ifdef SMC_DYNAMIC_BUS_CONFIG
Because platform_get_irq() could fail and return error irq. Therefore, it might be better to check it if order to avoid the use of error irq. Fixes: ae150435b59e ("smsc: Move the SMC (SMSC) drivers") Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> --- drivers/net/ethernet/smsc/smc911x.c | 5 +++++ 1 file changed, 5 insertions(+)