| Message ID | 20210923065500.2284347-1-daniel@0x0f.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | gpio: msc313: Add gpio support for ssd20xd | expand |
Hi Bartosz, On Thu, 23 Sept 2021 at 15:55, Daniel Palmer <daniel@0x0f.com> wrote: > Daniel Palmer (11): > dt-bindings: gpio: msc313: Add compatible for ssd20xd > dt-bindings: gpio: msc313: Add offsets for ssd20xd > gpio: msc313: Code clean ups > gpio: msc313: Add support for SSD201 and SSD202D Would it be possible to get some comment on these commits and/or get them picked up? We (Romain and I) have a few bits that are blocked on this. Thanks, Daniel
On Fri, Nov 19, 2021 at 2:12 PM Daniel Palmer <daniel@0x0f.com> wrote: > On Thu, 23 Sept 2021 at 15:55, Daniel Palmer <daniel@0x0f.com> wrote: > > > Daniel Palmer (11): > > dt-bindings: gpio: msc313: Add compatible for ssd20xd > > dt-bindings: gpio: msc313: Add offsets for ssd20xd > > gpio: msc313: Code clean ups > > gpio: msc313: Add support for SSD201 and SSD202D > > Would it be possible to get some comment on these commits and/or get > them picked up? > We (Romain and I) have a few bits that are blocked on this. I think it is usually easier for the maintainers if you don't include the DTS changes in the series. Then we can just apply the whole series, no need to drop the stuff in the tail. The DT bindings sometimes need some slack so the DT people have time to look at them as well. Yours, Linus Walleij
Hi Linus, On Mon, 22 Nov 2021 at 09:05, Linus Walleij <linus.walleij@linaro.org> wrote: > I think it is usually easier for the maintainers if you don't include > the DTS changes in the series. Ok, I was aiming for a series that added something and then showed how it would be used hence adding the board DTS bits. If needed I'll create a new series with just the relevant bits. The listed commits all got reviewed from what I remember so I was hoping they'd get picked up. Thanks, Daniel
This is a little series to add a compatible string for the Sigmastar SSD201 and SSD202D to the msc313 gpio driver, add the specific offsets for the pins on these chips, and then a bunch of DT wiring stuff so that the LEDs on the M5 stack unitv2 work and it can control the power switch for the USB connected. Changes since v1: - Add a fix for the led binding to squash the warning about the activity trigger in the unitv2 dts. - Fix up the regulator node names so they pass dtb check Daniel Palmer (11): dt-bindings: gpio: msc313: Add compatible for ssd20xd dt-bindings: gpio: msc313: Add offsets for ssd20xd dt-bindings: leds: Document "activity" trigger gpio: msc313: Code clean ups gpio: msc313: Add support for SSD201 and SSD202D ARM: dts: mstar: Set gpio compatible for ssd20xd ARM: dts: mstar: unitv2: Wire up LEDs ARM: dts: mstar: unitv2: Add core regulator ARM: dts: mstar: unitv2: Add io regulator ARM: dts: mstar: unitv2: Add DRAM regulator ARM: dts: mstar: unitv2: Add wifi switch .../bindings/gpio/mstar,msc313-gpio.yaml | 4 +- .../devicetree/bindings/leds/common.yaml | 2 + .../dts/mstar-infinity2m-ssd202d-unitv2.dts | 46 +++ .../boot/dts/mstar-infinity2m-ssd20xd.dtsi | 5 + drivers/gpio/gpio-msc313.c | 266 +++++++++++++++++- include/dt-bindings/gpio/msc313-gpio.h | 71 +++++ 6 files changed, 389 insertions(+), 5 deletions(-)