| Message ID | 20211126151352.1509583-1-john@metanate.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | pinctrl/rockchip: fix gpio device creation | expand |
On Fri, Nov 26, 2021 at 4:14 PM John Keeping <john@metanate.com> wrote: > GPIO nodes are not themselves busses, so passing rockchip_bank_match > here is wrong. Passing NULL instead uses the standard bus match table > which is more appropriate. > > devm_of_platform_populate() shows that this is the normal way to call > of_platform_populate() from a device driver, so in order to match that > more closely also add the pinctrl device as the parent for the newly > created GPIO controllers. > > Specifically, using the wrong match here can break dynamic GPIO hogs as > marking the GPIO bank as a bus means that of_platform_notify() will set > OF_POPULATED on new child nodes and if this happens before > of_gpio_notify() is called then the new hog will be skipped as > OF_POPULATED is already set. > > Fixes: 9ce9a02039de ("pinctrl/rockchip: drop the gpio related codes") > Signed-off-by: John Keeping <john@metanate.com> Patch applied. Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c index 438808a867cf..d8dd8415fa81 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c @@ -2735,7 +2735,7 @@ static int rockchip_pinctrl_probe(struct platform_device *pdev) platform_set_drvdata(pdev, info); - ret = of_platform_populate(np, rockchip_bank_match, NULL, NULL); + ret = of_platform_populate(np, NULL, NULL, &pdev->dev); if (ret) return dev_err_probe(dev, ret, "failed to register gpio device\n");
GPIO nodes are not themselves busses, so passing rockchip_bank_match here is wrong. Passing NULL instead uses the standard bus match table which is more appropriate. devm_of_platform_populate() shows that this is the normal way to call of_platform_populate() from a device driver, so in order to match that more closely also add the pinctrl device as the parent for the newly created GPIO controllers. Specifically, using the wrong match here can break dynamic GPIO hogs as marking the GPIO bank as a bus means that of_platform_notify() will set OF_POPULATED on new child nodes and if this happens before of_gpio_notify() is called then the new hog will be skipped as OF_POPULATED is already set. Fixes: 9ce9a02039de ("pinctrl/rockchip: drop the gpio related codes") Signed-off-by: John Keeping <john@metanate.com> --- drivers/pinctrl/pinctrl-rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)