| Message ID | 20211222213032.7678-2-jbx6244@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add Naneng multi phy support for rk3568 | expand |
Hi Heiko, The file grf.yaml is already pretty full with legacy stuff. Now rockchip,rk3568-usb2phy-grf is added, would you like these two compatible strings also there? Could you give advice to Yifeng? Kind regards, Johan Jonker On 12/22/21 10:30 PM, Johan Jonker wrote: > Add Naneng multi phy register compatible. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com> > Acked-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml > index 5de16388a..9f0c8aa81 100644 > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > @@ -52,6 +52,8 @@ properties: > - rockchip,rk3288-qos > - rockchip,rk3368-qos > - rockchip,rk3399-qos > + - rockchip,rk3568-pipe-grf > + - rockchip,rk3568-pipe-phy-grf > - rockchip,rk3568-qos > - samsung,exynos3-sysreg > - samsung,exynos4-sysreg >
Hi Johan, Yifeng, Am Dienstag, 28. Dezember 2021, 13:08:00 CET schrieb Johan Jonker: > The file grf.yaml is already pretty full with legacy stuff. I wouldn't call that legacy stuff ;-) . The grf as "dumping ground" for more or less unsorted parts will probably stay around in future socs as well. > Now rockchip,rk3568-usb2phy-grf is added, would you like these two > compatible strings also there? I guess that makes sense. The grf.yaml is a better match for grf compatible strings I guess. Heiko > Could you give advice to Yifeng? > > Kind regards, > > Johan Jonker > > > On 12/22/21 10:30 PM, Johan Jonker wrote: > > Add Naneng multi phy register compatible. > > > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > > Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com> > > Acked-by: Rob Herring <robh@kernel.org> > > --- > > Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml > > index 5de16388a..9f0c8aa81 100644 > > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > > @@ -52,6 +52,8 @@ properties: > > - rockchip,rk3288-qos > > - rockchip,rk3368-qos > > - rockchip,rk3399-qos > > + - rockchip,rk3568-pipe-grf > > + - rockchip,rk3568-pipe-phy-grf > > - rockchip,rk3568-qos > > - samsung,exynos3-sysreg > > - samsung,exynos4-sysreg > > >
diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml index 5de16388a..9f0c8aa81 100644 --- a/Documentation/devicetree/bindings/mfd/syscon.yaml +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml @@ -52,6 +52,8 @@ properties: - rockchip,rk3288-qos - rockchip,rk3368-qos - rockchip,rk3399-qos + - rockchip,rk3568-pipe-grf + - rockchip,rk3568-pipe-phy-grf - rockchip,rk3568-qos - samsung,exynos3-sysreg - samsung,exynos4-sysreg