Message ID | 20211227094526.698714-4-u.kleine-koenig@pengutronix.de (mailing list archive) |
---|---|
State | Handled Elsewhere |
Headers | show |
Series | [v2,01/23] counter: Use container_of instead of drvdata to track counter_device | expand |
On Mon, 27 Dec 2021 10:45:06 +0100 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > The driver doesn't ever use platform_get_drvdata, so drop this unused > call. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> FWIW sanity checked it is indeed not used that I can see. Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/counter/microchip-tcb-capture.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c > index 0ab1b2716784..bb69f2e0ba93 100644 > --- a/drivers/counter/microchip-tcb-capture.c > +++ b/drivers/counter/microchip-tcb-capture.c > @@ -307,8 +307,6 @@ static int mchp_tc_probe(struct platform_device *pdev) > if (!priv) > return -ENOMEM; > > - platform_set_drvdata(pdev, priv); > - > match = of_match_node(atmel_tc_of_match, np->parent); > tcb_config = match->data; > if (!tcb_config) {
On Mon, Dec 27, 2021 at 10:45:06AM +0100, Uwe Kleine-König wrote: > The driver doesn't ever use platform_get_drvdata, so drop this unused > call. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com> > --- > drivers/counter/microchip-tcb-capture.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c > index 0ab1b2716784..bb69f2e0ba93 100644 > --- a/drivers/counter/microchip-tcb-capture.c > +++ b/drivers/counter/microchip-tcb-capture.c > @@ -307,8 +307,6 @@ static int mchp_tc_probe(struct platform_device *pdev) > if (!priv) > return -ENOMEM; > > - platform_set_drvdata(pdev, priv); > - > match = of_match_node(atmel_tc_of_match, np->parent); > tcb_config = match->data; > if (!tcb_config) { > -- > 2.33.0 >
diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c index 0ab1b2716784..bb69f2e0ba93 100644 --- a/drivers/counter/microchip-tcb-capture.c +++ b/drivers/counter/microchip-tcb-capture.c @@ -307,8 +307,6 @@ static int mchp_tc_probe(struct platform_device *pdev) if (!priv) return -ENOMEM; - platform_set_drvdata(pdev, priv); - match = of_match_node(atmel_tc_of_match, np->parent); tcb_config = match->data; if (!tcb_config) {
The driver doesn't ever use platform_get_drvdata, so drop this unused call. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/counter/microchip-tcb-capture.c | 2 -- 1 file changed, 2 deletions(-)