diff mbox series

gitlab-ci: Always upload artifacts by default

Message ID 20211229233355.217174-1-philmd@redhat.com (mailing list archive)
State New, archived
Headers show
Series gitlab-ci: Always upload artifacts by default | expand

Commit Message

Philippe Mathieu-Daudé Dec. 29, 2021, 11:33 p.m. UTC
GitLab defaults [1] to upload artifacts only when the job succeeds,
which is not helpful to troubleshoot failing tests. Switch to
always upload artifacts by default for QEMU jobs, by setting the
'artifacts:when' keyword in the global default section [2].

[1] https://docs.gitlab.com/ee/ci/yaml/index.html#artifactswhen
[2] https://docs.gitlab.com/ee/ci/yaml/index.html#default

Reported-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 .gitlab-ci.d/qemu-project.yml | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Philippe Mathieu-Daudé Dec. 30, 2021, 3:51 p.m. UTC | #1
On 12/30/21 00:33, Philippe Mathieu-Daudé wrote:
> GitLab defaults [1] to upload artifacts only when the job succeeds,
> which is not helpful to troubleshoot failing tests. Switch to
> always upload artifacts by default for QEMU jobs, by setting the
> 'artifacts:when' keyword in the global default section [2].
> 
> [1] https://docs.gitlab.com/ee/ci/yaml/index.html#artifactswhen
> [2] https://docs.gitlab.com/ee/ci/yaml/index.html#default
> 
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  .gitlab-ci.d/qemu-project.yml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/.gitlab-ci.d/qemu-project.yml b/.gitlab-ci.d/qemu-project.yml
> index 871262fe0e8..24137c14dc4 100644
> --- a/.gitlab-ci.d/qemu-project.yml
> +++ b/.gitlab-ci.d/qemu-project.yml
> @@ -1,6 +1,10 @@
>  # This file contains the set of jobs run by the QEMU project:
>  # https://gitlab.com/qemu-project/qemu/-/pipelines
>  
> +default:
> +  artifacts:
> +    when: always

Hmm this doesn't work as expected... Please disregard this patch.
diff mbox series

Patch

diff --git a/.gitlab-ci.d/qemu-project.yml b/.gitlab-ci.d/qemu-project.yml
index 871262fe0e8..24137c14dc4 100644
--- a/.gitlab-ci.d/qemu-project.yml
+++ b/.gitlab-ci.d/qemu-project.yml
@@ -1,6 +1,10 @@ 
 # This file contains the set of jobs run by the QEMU project:
 # https://gitlab.com/qemu-project/qemu/-/pipelines
 
+default:
+  artifacts:
+    when: always
+
 include:
   - local: '/.gitlab-ci.d/stages.yml'
   - local: '/.gitlab-ci.d/edk2.yml'