| Message ID | 20220102224803.27463-1-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | bebfa3419a7c064b29e7b0a14ca11d8985a29cbb |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | media: i2c: max9271: Add header include guards to max9271.h | expand |
Hi Laurent, Quoting Laurent Pinchart (2022-01-02 22:48:03) > Protect against multiple inclusions of the max9271.h header with include > guards. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > drivers/media/i2c/max9271.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/media/i2c/max9271.h b/drivers/media/i2c/max9271.h > index dc5e4e70ba6f..0bf1d40811eb 100644 > --- a/drivers/media/i2c/max9271.h > +++ b/drivers/media/i2c/max9271.h > @@ -8,6 +8,9 @@ > * Copyright (C) 2015 Cogent Embedded, Inc. > */ > > +#ifndef __MEDIA_I2C_MAX9271_H__ > +#define __MEDIA_I2C_MAX9271_H__ > + I wonder if we'll ever #pragma once outside of /tools/testing/selftests. Still, these are indeed missing and should be added. Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > #include <linux/i2c.h> > > #define MAX9271_DEFAULT_ADDR 0x40 > @@ -231,3 +234,5 @@ int max9271_set_deserializer_address(struct max9271_device *dev, u8 addr); > * Return 0 on success or a negative error code on failure > */ > int max9271_set_translation(struct max9271_device *dev, u8 source, u8 dest); > + > +#endif /* __MEDIA_I2C_MAX9271_H__ */ > -- > Regards, > > Laurent Pinchart >
Hi Laurent, On Mon, Jan 03, 2022 at 12:48:03AM +0200, Laurent Pinchart wrote: > Protect against multiple inclusions of the max9271.h header with include > guards. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Indeed Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Thanks j > --- > drivers/media/i2c/max9271.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/media/i2c/max9271.h b/drivers/media/i2c/max9271.h > index dc5e4e70ba6f..0bf1d40811eb 100644 > --- a/drivers/media/i2c/max9271.h > +++ b/drivers/media/i2c/max9271.h > @@ -8,6 +8,9 @@ > * Copyright (C) 2015 Cogent Embedded, Inc. > */ > > +#ifndef __MEDIA_I2C_MAX9271_H__ > +#define __MEDIA_I2C_MAX9271_H__ > + > #include <linux/i2c.h> > > #define MAX9271_DEFAULT_ADDR 0x40 > @@ -231,3 +234,5 @@ int max9271_set_deserializer_address(struct max9271_device *dev, u8 addr); > * Return 0 on success or a negative error code on failure > */ > int max9271_set_translation(struct max9271_device *dev, u8 source, u8 dest); > + > +#endif /* __MEDIA_I2C_MAX9271_H__ */ > -- > Regards, > > Laurent Pinchart >
Hi Kieran,
On Mon, Jan 3, 2022 at 8:48 AM Kieran Bingham
<kieran.bingham+renesas@ideasonboard.com> wrote:
> I wonder if we'll ever #pragma once outside of /tools/testing/selftests.
Probably not anytime soon
https://lore.kernel.org/all/CAHk-=wi13+FLcRo4zmnRUmmY=AAns-Yd5NR_mVdcAd6ZrPq2fA@mail.gmail.com/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
diff --git a/drivers/media/i2c/max9271.h b/drivers/media/i2c/max9271.h index dc5e4e70ba6f..0bf1d40811eb 100644 --- a/drivers/media/i2c/max9271.h +++ b/drivers/media/i2c/max9271.h @@ -8,6 +8,9 @@ * Copyright (C) 2015 Cogent Embedded, Inc. */ +#ifndef __MEDIA_I2C_MAX9271_H__ +#define __MEDIA_I2C_MAX9271_H__ + #include <linux/i2c.h> #define MAX9271_DEFAULT_ADDR 0x40 @@ -231,3 +234,5 @@ int max9271_set_deserializer_address(struct max9271_device *dev, u8 addr); * Return 0 on success or a negative error code on failure */ int max9271_set_translation(struct max9271_device *dev, u8 source, u8 dest); + +#endif /* __MEDIA_I2C_MAX9271_H__ */
Protect against multiple inclusions of the max9271.h header with include guards. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- drivers/media/i2c/max9271.h | 5 +++++ 1 file changed, 5 insertions(+)