| Message ID | 20220103153055.50473-2-angelogioacchino.delregno@collabora.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/4] phy: mediatek: phy-mtk-hdmi: Switch to regmap for mmio access | expand |
On Mon, 2022-01-03 at 16:30 +0100, AngeloGioacchino Del Regno wrote: > Forward declarations for mtk_hdmi_power_{on,off} aren't necessary: > move mtk_hdmi_phy_dev_ops down to remove forward declarations. > > Signed-off-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > --- > drivers/phy/mediatek/phy-mtk-hdmi.c | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/drivers/phy/mediatek/phy-mtk-hdmi.c > b/drivers/phy/mediatek/phy-mtk-hdmi.c > index 707e90691e6e..b4193cb4e4e3 100644 > --- a/drivers/phy/mediatek/phy-mtk-hdmi.c > +++ b/drivers/phy/mediatek/phy-mtk-hdmi.c > @@ -6,15 +6,6 @@ > > #include "phy-mtk-hdmi.h" > > -static int mtk_hdmi_phy_power_on(struct phy *phy); > -static int mtk_hdmi_phy_power_off(struct phy *phy); > - > -static const struct phy_ops mtk_hdmi_phy_dev_ops = { > - .power_on = mtk_hdmi_phy_power_on, > - .power_off = mtk_hdmi_phy_power_off, > - .owner = THIS_MODULE, > -}; > - > inline struct mtk_hdmi_phy *to_mtk_hdmi_phy(struct clk_hw *hw) > { > return container_of(hw, struct mtk_hdmi_phy, pll_hw); > @@ -43,6 +34,12 @@ static int mtk_hdmi_phy_power_off(struct phy *phy) > return 0; > } > > +static const struct phy_ops mtk_hdmi_phy_dev_ops = { > + .power_on = mtk_hdmi_phy_power_on, > + .power_off = mtk_hdmi_phy_power_off, > + .owner = THIS_MODULE, > +}; > + > static const struct phy_ops * > mtk_hdmi_phy_dev_get_ops(const struct mtk_hdmi_phy *hdmi_phy) > { Reviewed-by: Chunfeng Yun <chunfeng.yun@mediatek.com> Thanks a lot
diff --git a/drivers/phy/mediatek/phy-mtk-hdmi.c b/drivers/phy/mediatek/phy-mtk-hdmi.c index 707e90691e6e..b4193cb4e4e3 100644 --- a/drivers/phy/mediatek/phy-mtk-hdmi.c +++ b/drivers/phy/mediatek/phy-mtk-hdmi.c @@ -6,15 +6,6 @@ #include "phy-mtk-hdmi.h" -static int mtk_hdmi_phy_power_on(struct phy *phy); -static int mtk_hdmi_phy_power_off(struct phy *phy); - -static const struct phy_ops mtk_hdmi_phy_dev_ops = { - .power_on = mtk_hdmi_phy_power_on, - .power_off = mtk_hdmi_phy_power_off, - .owner = THIS_MODULE, -}; - inline struct mtk_hdmi_phy *to_mtk_hdmi_phy(struct clk_hw *hw) { return container_of(hw, struct mtk_hdmi_phy, pll_hw); @@ -43,6 +34,12 @@ static int mtk_hdmi_phy_power_off(struct phy *phy) return 0; } +static const struct phy_ops mtk_hdmi_phy_dev_ops = { + .power_on = mtk_hdmi_phy_power_on, + .power_off = mtk_hdmi_phy_power_off, + .owner = THIS_MODULE, +}; + static const struct phy_ops * mtk_hdmi_phy_dev_get_ops(const struct mtk_hdmi_phy *hdmi_phy) {
Forward declarations for mtk_hdmi_power_{on,off} aren't necessary: move mtk_hdmi_phy_dev_ops down to remove forward declarations. Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- drivers/phy/mediatek/phy-mtk-hdmi.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-)