| Message ID | b88f25f3d07be92dd75494dc129a85619afb1366.1641500561.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Remove usage of the deprecated "pci-dma-compat.h" API | expand |
On Thu, Jan 6, 2022 at 4:52 PM Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > > In [1], Christoph Hellwig has proposed to remove the wrappers in > include/linux/pci-dma-compat.h. > > Some reasons why this API should be removed have been given by Julia > Lawall in [2]. > > A coccinelle script has been used to perform the needed transformation. > It can be found in [3]. > > [1]: https://lore.kernel.org/kernel-janitors/20200421081257.GA131897@infradead.org/ > [2]: https://lore.kernel.org/kernel-janitors/alpine.DEB.2.22.394.2007120902170.2424@hadrien/ > [3]: https://lore.kernel.org/kernel-janitors/20200716192821.321233-1-christophe.jaillet@wanadoo.fr/ > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Arnd Bergmann <arnd@arndb.de> Vinod, can you apply this one to the dmaengine tree? It has no other dependencies.
On 06-01-22, 19:56, Arnd Bergmann wrote: > On Thu, Jan 6, 2022 at 4:52 PM Christophe JAILLET > <christophe.jaillet@wanadoo.fr> wrote: > > > > In [1], Christoph Hellwig has proposed to remove the wrappers in > > include/linux/pci-dma-compat.h. > > > > Some reasons why this API should be removed have been given by Julia > > Lawall in [2]. > > > > A coccinelle script has been used to perform the needed transformation. > > It can be found in [3]. > > > > [1]: https://lore.kernel.org/kernel-janitors/20200421081257.GA131897@infradead.org/ > > [2]: https://lore.kernel.org/kernel-janitors/alpine.DEB.2.22.394.2007120902170.2424@hadrien/ > > [3]: https://lore.kernel.org/kernel-janitors/20200716192821.321233-1-christophe.jaillet@wanadoo.fr/ > > > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > > Reviewed-by: Arnd Bergmann <arnd@arndb.de> > > Vinod, can you apply this one to the dmaengine tree? It has no other > dependencies. Sure, applied now. Thanks
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c index 1da04112fcdb..c359decc07a3 100644 --- a/drivers/dma/pch_dma.c +++ b/drivers/dma/pch_dma.c @@ -835,7 +835,7 @@ static int pch_dma_probe(struct pci_dev *pdev, goto err_disable_pdev; } - err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32)); + err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32)); if (err) { dev_err(&pdev->dev, "Cannot set proper DMA config\n"); goto err_free_res;
In [1], Christoph Hellwig has proposed to remove the wrappers in include/linux/pci-dma-compat.h. Some reasons why this API should be removed have been given by Julia Lawall in [2]. A coccinelle script has been used to perform the needed transformation. It can be found in [3]. [1]: https://lore.kernel.org/kernel-janitors/20200421081257.GA131897@infradead.org/ [2]: https://lore.kernel.org/kernel-janitors/alpine.DEB.2.22.394.2007120902170.2424@hadrien/ [3]: https://lore.kernel.org/kernel-janitors/20200716192821.321233-1-christophe.jaillet@wanadoo.fr/ Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/dma/pch_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)