| Message ID | 20220107150512.614423-2-narmstrong@baylibre.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | phy: amlogic: Add support for the G12A Analog MIPI D-PHY | expand |
Hi Neil, On Fri, Jan 7, 2022 at 4:05 PM Neil Armstrong <narmstrong@baylibre.com> wrote: [...] > +required: > + - compatible > + - reg > + - "#phy-cells" I also found a "MIPI DSI PHY clock" and "MIPI DSI PHY interrupt" in the datasheet. I'm no expert on this and I'm just asking in case you have missed one of these: Can you confirm that these belong to some other IP? Best regards, Martin
On 07/01/2022 23:13, Martin Blumenstingl wrote: > Hi Neil, > > On Fri, Jan 7, 2022 at 4:05 PM Neil Armstrong <narmstrong@baylibre.com> wrote: > [...] >> +required: >> + - compatible >> + - reg >> + - "#phy-cells" > I also found a "MIPI DSI PHY clock" and "MIPI DSI PHY interrupt" in > the datasheet. > I'm no expert on this and I'm just asking in case you have missed one of these: > Can you confirm that these belong to some other IP? Indeed the name is misleading, both go to the DSI Transceiver IP (dw-mipi-dsi) Neil > > > Best regards, > Martin >
Hi Neil, On Mon, Jan 10, 2022 at 10:25 AM Neil Armstrong <narmstrong@baylibre.com> wrote: > > On 07/01/2022 23:13, Martin Blumenstingl wrote: > > Hi Neil, > > > > On Fri, Jan 7, 2022 at 4:05 PM Neil Armstrong <narmstrong@baylibre.com> wrote: > > [...] > >> +required: > >> + - compatible > >> + - reg > >> + - "#phy-cells" > > I also found a "MIPI DSI PHY clock" and "MIPI DSI PHY interrupt" in > > the datasheet. > > I'm no expert on this and I'm just asking in case you have missed one of these: > > Can you confirm that these belong to some other IP? > > Indeed the name is misleading, both go to the DSI Transceiver IP (dw-mipi-dsi) Thank you for clarifying this! I just found an old comment from Rob on v2 of this series: [0] He mentions: "If this is a child of something else, then put a $ref to this schema and the example in the parent schema." To be honest: I completely forgot about that comment until now. If I had remembered it (and assuming that his comment is still valid) then I would have had to NACK my own Documentation/devicetree/bindings/phy/amlogic,meson8-hdmi-tx-phy.yaml For today it's already late so I'll look into this more tomorrow. Best regards, Martin [0] https://lore.kernel.org/all/20210210165118.GA2311581@robh.at.kernel.org/
diff --git a/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml b/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml new file mode 100644 index 000000000000..7aa0c05d6ce4 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml @@ -0,0 +1,35 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/phy/amlogic,g12a-mipi-dphy-analog.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Amlogic G12A MIPI analog PHY + +maintainers: + - Neil Armstrong <narmstrong@baylibre.com> + +properties: + compatible: + const: amlogic,g12a-mipi-dphy-analog + + "#phy-cells": + const: 0 + + reg: + maxItems: 1 + +required: + - compatible + - reg + - "#phy-cells" + +additionalProperties: false + +examples: + - | + phy@0 { + compatible = "amlogic,g12a-mipi-dphy-analog"; + reg = <0x0 0xc>; + #phy-cells = <0>; + };
The Amlogic G12A SoCs embeds an Analog MIPI D-PHY to communicate with DSI panels, this adds the bindings. This Analog D-PHY works with a separate Digital MIPI D-PHY. Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- .../phy/amlogic,g12a-mipi-dphy-analog.yaml | 35 +++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/amlogic,g12a-mipi-dphy-analog.yaml