| Message ID | 20220107183303.2337676-1-nathan@kernel.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | clk: visconti: Remove pointless NULL check in visconti_pll_add_lookup() | expand |
Quoting Nathan Chancellor (2022-01-07 10:33:03) > Clang warns: > > drivers/clk/visconti/pll.c:292:20: warning: address of array 'ctx->clk_data.hws' will always evaluate to 'true' [-Wpointer-bool-conversion] > if (ctx->clk_data.hws && id) > ~~~~~~~~~~~~~~^~~ ~~ > 1 warning generated. > > This array cannot be NULL if ctx is not NULL, which is allocated in > visconti_init_pll(), so just remove the check, which matches other clk > drivers. > > Fixes: b4cbe606dc36 ("clk: visconti: Add support common clock driver and reset driver") > Link: https://github.com/ClangBuiltLinux/linux/issues/1564 > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Nathan Chancellor <nathan@kernel.org> > --- Applied to clk-next
Hi Nathan, Thanks for your patch. > -----Original Message----- > From: Nathan Chancellor <nathan@kernel.org> > Sent: Saturday, January 8, 2022 3:33 AM > To: Michael Turquette <mturquette@baylibre.com>; Stephen Boyd > <sboyd@kernel.org>; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ) > <nobuhiro1.iwamatsu@toshiba.co.jp> > Cc: Nick Desaulniers <ndesaulniers@google.com>; linux-clk@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > llvm@lists.linux.dev; Nathan Chancellor <nathan@kernel.org>; kernel test > robot <lkp@intel.com> > Subject: [PATCH] clk: visconti: Remove pointless NULL check in > visconti_pll_add_lookup() > > Clang warns: > > drivers/clk/visconti/pll.c:292:20: warning: address of array 'ctx->clk_data.hws' > will always evaluate to 'true' [-Wpointer-bool-conversion] > if (ctx->clk_data.hws && id) > ~~~~~~~~~~~~~~^~~ ~~ > 1 warning generated. > > This array cannot be NULL if ctx is not NULL, which is allocated in > visconti_init_pll(), so just remove the check, which matches other clk drivers. > > Fixes: b4cbe606dc36 ("clk: visconti: Add support common clock driver and > reset driver") > Link: https://github.com/ClangBuiltLinux/linux/issues/1564 > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Nathan Chancellor <nathan@kernel.org> > --- > drivers/clk/visconti/pll.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> Best regards, Nobuhiro
diff --git a/drivers/clk/visconti/pll.c b/drivers/clk/visconti/pll.c index 3b6e88bb73d5..a2398bc6c6e4 100644 --- a/drivers/clk/visconti/pll.c +++ b/drivers/clk/visconti/pll.c @@ -289,7 +289,7 @@ static void visconti_pll_add_lookup(struct visconti_pll_provider *ctx, struct clk_hw *hw_clk, unsigned int id) { - if (ctx->clk_data.hws && id) + if (id) ctx->clk_data.hws[id] = hw_clk; }
Clang warns: drivers/clk/visconti/pll.c:292:20: warning: address of array 'ctx->clk_data.hws' will always evaluate to 'true' [-Wpointer-bool-conversion] if (ctx->clk_data.hws && id) ~~~~~~~~~~~~~~^~~ ~~ 1 warning generated. This array cannot be NULL if ctx is not NULL, which is allocated in visconti_init_pll(), so just remove the check, which matches other clk drivers. Fixes: b4cbe606dc36 ("clk: visconti: Add support common clock driver and reset driver") Link: https://github.com/ClangBuiltLinux/linux/issues/1564 Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org> --- drivers/clk/visconti/pll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 70faf946ad975c64efb2eb809f9139f304a494b0