| Message ID | 20220109163702.6331-1-ap420073@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | dd3ca4c5184ea98e40acb8eb293d85b88ea04ee2 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] amt: fix wrong return type of amt_send_membership_update() | expand |
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Sun, 9 Jan 2022 16:37:02 +0000 you wrote: > amt_send_membership_update() would return -1 but it's return type is bool. > So, it should be used TRUE instead of -1. > > Fixes: cbc21dc1cfe9 ("amt: add data plane of amt interface") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Taehee Yoo <ap420073@gmail.com> > > [...] Here is the summary with links: - [net] amt: fix wrong return type of amt_send_membership_update() https://git.kernel.org/netdev/net/c/dd3ca4c5184e You are awesome, thank you!
diff --git a/drivers/net/amt.c b/drivers/net/amt.c index b732ee9a50ef..d3a9dda6c728 100644 --- a/drivers/net/amt.c +++ b/drivers/net/amt.c @@ -1106,7 +1106,7 @@ static bool amt_send_membership_query(struct amt_dev *amt, rt = ip_route_output_key(amt->net, &fl4); if (IS_ERR(rt)) { netdev_dbg(amt->dev, "no route to %pI4\n", &tunnel->ip4); - return -1; + return true; } amtmq = skb_push(skb, sizeof(*amtmq));
amt_send_membership_update() would return -1 but it's return type is bool. So, it should be used TRUE instead of -1. Fixes: cbc21dc1cfe9 ("amt: add data plane of amt interface") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Taehee Yoo <ap420073@gmail.com> --- drivers/net/amt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)