| Message ID | 20220114151727.2319915-2-conor.dooley@microchip.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Update the Icicle Kit device tree | expand |
> From: Conor Dooley <conor.dooley@microchip.com> > > The Polarfire SoC is currently using two different compatible string > prefixes. Fix this by changing "polarfire-soc-*" strings to "mpfs-*" in > its system controller in order to match the compatible string used in > the soc binding and device tree > > Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > ...larfire-soc-mailbox.yaml => microchip,mpfs-mailbox.yaml} | 6 +++--- > ...s-controller.yaml => microchip,mpfs-sys-controller.yaml} | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > rename Documentation/devicetree/bindings/mailbox/{microchip,polarfire-soc-mailbox.yaml => microchip,mpfs-mailbox.yaml} (82%) > rename Documentation/devicetree/bindings/soc/microchip/{microchip,polarfire-soc-sys-controller.yaml => microchip,mpfs-sys-controller.yaml} (75%) > > diff --git a/Documentation/devicetree/bindings/mailbox/microchip,polarfire-soc-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.yaml > similarity index 82% > rename from Documentation/devicetree/bindings/mailbox/microchip,polarfire-soc-mailbox.yaml > rename to Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.yaml > index bbb173ea483c..9251c2218c68 100644 > --- a/Documentation/devicetree/bindings/mailbox/microchip,polarfire-soc-mailbox.yaml > +++ b/Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.yaml > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > %YAML 1.2 > --- > -$id: "http://devicetree.org/schemas/mailbox/microchip,polarfire-soc-mailbox.yaml#" > +$id: "http://devicetree.org/schemas/mailbox/microchip,mpfs-mailbox.yaml#" > $schema: "http://devicetree.org/meta-schemas/core.yaml#" > > title: Microchip PolarFire SoC (MPFS) MSS (microprocessor subsystem) mailbox controller > @@ -11,7 +11,7 @@ maintainers: > > properties: > compatible: > - const: microchip,polarfire-soc-mailbox > + const: microchip,mpfs-mailbox > > reg: > items: > @@ -38,7 +38,7 @@ examples: > #address-cells = <2>; > #size-cells = <2>; > mbox: mailbox@37020000 { > - compatible = "microchip,polarfire-soc-mailbox"; > + compatible = "mpfs-mailbox"; Example is wrong, should read "microchip,mpfs-mailbox". Will resubmit Monday. > reg = <0x0 0x37020000 0x0 0x1000>, <0x0 0x2000318c 0x0 0x40>; > interrupt-parent = <&L1>; > interrupts = <96>;
On Fri, 14 Jan 2022 15:17:13 +0000, conor.dooley@microchip.com wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > The Polarfire SoC is currently using two different compatible string > prefixes. Fix this by changing "polarfire-soc-*" strings to "mpfs-*" in > its system controller in order to match the compatible string used in > the soc binding and device tree > > Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > ...larfire-soc-mailbox.yaml => microchip,mpfs-mailbox.yaml} | 6 +++--- > ...s-controller.yaml => microchip,mpfs-sys-controller.yaml} | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > rename Documentation/devicetree/bindings/mailbox/{microchip,polarfire-soc-mailbox.yaml => microchip,mpfs-mailbox.yaml} (82%) > rename Documentation/devicetree/bindings/soc/microchip/{microchip,polarfire-soc-sys-controller.yaml => microchip,mpfs-sys-controller.yaml} (75%) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.example.dt.yaml:0:0: /example-0/soc/mailbox@37020000: failed to match any schema with compatible: ['mpfs-mailbox'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1580091 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/mailbox/microchip,polarfire-soc-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.yaml similarity index 82% rename from Documentation/devicetree/bindings/mailbox/microchip,polarfire-soc-mailbox.yaml rename to Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.yaml index bbb173ea483c..9251c2218c68 100644 --- a/Documentation/devicetree/bindings/mailbox/microchip,polarfire-soc-mailbox.yaml +++ b/Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.yaml @@ -1,7 +1,7 @@ # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 --- -$id: "http://devicetree.org/schemas/mailbox/microchip,polarfire-soc-mailbox.yaml#" +$id: "http://devicetree.org/schemas/mailbox/microchip,mpfs-mailbox.yaml#" $schema: "http://devicetree.org/meta-schemas/core.yaml#" title: Microchip PolarFire SoC (MPFS) MSS (microprocessor subsystem) mailbox controller @@ -11,7 +11,7 @@ maintainers: properties: compatible: - const: microchip,polarfire-soc-mailbox + const: microchip,mpfs-mailbox reg: items: @@ -38,7 +38,7 @@ examples: #address-cells = <2>; #size-cells = <2>; mbox: mailbox@37020000 { - compatible = "microchip,polarfire-soc-mailbox"; + compatible = "mpfs-mailbox"; reg = <0x0 0x37020000 0x0 0x1000>, <0x0 0x2000318c 0x0 0x40>; interrupt-parent = <&L1>; interrupts = <96>; diff --git a/Documentation/devicetree/bindings/soc/microchip/microchip,polarfire-soc-sys-controller.yaml b/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-sys-controller.yaml similarity index 75% rename from Documentation/devicetree/bindings/soc/microchip/microchip,polarfire-soc-sys-controller.yaml rename to Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-sys-controller.yaml index 2cd3bc6bd8d6..f699772fedf3 100644 --- a/Documentation/devicetree/bindings/soc/microchip/microchip,polarfire-soc-sys-controller.yaml +++ b/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-sys-controller.yaml @@ -1,7 +1,7 @@ # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 --- -$id: "http://devicetree.org/schemas/soc/microchip/microchip,polarfire-soc-sys-controller.yaml#" +$id: "http://devicetree.org/schemas/soc/microchip/microchip,mpfs-sys-controller.yaml#" $schema: "http://devicetree.org/meta-schemas/core.yaml#" title: Microchip PolarFire SoC (MPFS) MSS (microprocessor subsystem) system controller @@ -19,7 +19,7 @@ properties: maxItems: 1 compatible: - const: microchip,polarfire-soc-sys-controller + const: microchip,mpfs-sys-controller required: - compatible @@ -30,6 +30,6 @@ additionalProperties: false examples: - | syscontroller: syscontroller { - compatible = "microchip,polarfire-soc-sys-controller"; + compatible = "microchip,mpfs-sys-controller"; mboxes = <&mbox 0>; };