| Message ID | 20220113121143.22280-1-alim.akhtar@samsung.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support for Tesla Full Self-Driving (FSD) SoC | expand |
On 13/01/2022 13:11, Alim Akhtar wrote: > This patch set adds basic support for the Tesla Full Self-Driving (FSD) > SoC. This SoC contains three clusters of four Cortex-A72 CPUs, > as well as several IPs. > > Patches 1 to 8 provide support for the clock controller > (which is designed similarly to Exynos SoCs). > > The remaining changes provide pinmux support, initial device tree support, > and SPI, ADC, and MCT IP functionality. Does FSD have some version number? The FDS, especially in compatibles, looks quite generic, so what will happen if a newer SoC comes later? You would have: - tesla,fsd-pinctrl - tesla,fsd-xxxx-pinctrl (where xxxx could be some new version) This will be extra confusing, because fsd-pinctrl looks like the generic one, while it is specific... Best regards, Krzysztof
On Thu, Jan 13, 2022 at 4:32 AM Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > On 13/01/2022 13:11, Alim Akhtar wrote: > > This patch set adds basic support for the Tesla Full Self-Driving (FSD) > > SoC. This SoC contains three clusters of four Cortex-A72 CPUs, > > as well as several IPs. > > > > Patches 1 to 8 provide support for the clock controller > > (which is designed similarly to Exynos SoCs). > > > > The remaining changes provide pinmux support, initial device tree support, > > and SPI, ADC, and MCT IP functionality. > > Does FSD have some version number? The FDS, especially in compatibles, > looks quite generic, so what will happen if a newer SoC comes later? You > would have: > - tesla,fsd-pinctrl > - tesla,fsd-xxxx-pinctrl (where xxxx could be some new version) > > This will be extra confusing, because fsd-pinctrl looks like the generic > one, while it is specific... The public sources from Tesla on github uses "turbo,trav" here, but that's also not a versioned name. The platform itself (hw3/hw31 -- 3.1 I presume?) has numbering, but that's system and not SoC: https://github.com/teslamotors/linux/tree/tesla-4.14-hw3/arch/arm64/boot/dts/turbo It would be easy to do "fsd2" for naming/numbering if needed for future versions, for example. I'm not so worried about this, especially if there's no corresponding internal version numbering that this would map naturally to. -Olof
Hi Krzysztof, >-----Original Message----- >From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com] >Sent: Thursday, January 13, 2022 6:02 PM >To: Alim Akhtar <alim.akhtar@samsung.com>; linux-arm- >kernel@lists.infradead.org; linux-kernel@vger.kernel.org >Cc: soc@kernel.org; linux-clk@vger.kernel.org; devicetree@vger.kernel.org; >olof@lixom.net; linus.walleij@linaro.org; catalin.marinas@arm.com; >robh+dt@kernel.org; s.nawrocki@samsung.com; linux-samsung- >soc@vger.kernel.org; pankaj.dubey@samsung.com >Subject: Re: [PATCH 00/23] Add support for Tesla Full Self-Driving (FSD) SoC > >On 13/01/2022 13:11, Alim Akhtar wrote: >> This patch set adds basic support for the Tesla Full Self-Driving >> (FSD) SoC. This SoC contains three clusters of four Cortex-A72 CPUs, >> as well as several IPs. >> >> Patches 1 to 8 provide support for the clock controller (which is >> designed similarly to Exynos SoCs). >> >> The remaining changes provide pinmux support, initial device tree >> support, and SPI, ADC, and MCT IP functionality. > >Does FSD have some version number? The FDS, especially in compatibles, >looks quite generic, so what will happen if a newer SoC comes later? You >would have: > - tesla,fsd-pinctrl > - tesla,fsd-xxxx-pinctrl (where xxxx could be some new version) > >This will be extra confusing, because fsd-pinctrl looks like the generic one, >while it is specific... > AFAIK, there is no version for FSD SoC (like we see on Exynos or any other SoC) In case something comes in future, may be just adopt as Olof suggested in the other thread like fsd2 etc.. >Best regards, >Krzysztof
On 14/01/2022 06:41, Alim Akhtar wrote: > Hi Krzysztof, > >> -----Original Message----- >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com] >> Sent: Thursday, January 13, 2022 6:02 PM >> To: Alim Akhtar <alim.akhtar@samsung.com>; linux-arm- >> kernel@lists.infradead.org; linux-kernel@vger.kernel.org >> Cc: soc@kernel.org; linux-clk@vger.kernel.org; devicetree@vger.kernel.org; >> olof@lixom.net; linus.walleij@linaro.org; catalin.marinas@arm.com; >> robh+dt@kernel.org; s.nawrocki@samsung.com; linux-samsung- >> soc@vger.kernel.org; pankaj.dubey@samsung.com >> Subject: Re: [PATCH 00/23] Add support for Tesla Full Self-Driving (FSD) SoC >> >> On 13/01/2022 13:11, Alim Akhtar wrote: >>> This patch set adds basic support for the Tesla Full Self-Driving >>> (FSD) SoC. This SoC contains three clusters of four Cortex-A72 CPUs, >>> as well as several IPs. >>> >>> Patches 1 to 8 provide support for the clock controller (which is >>> designed similarly to Exynos SoCs). >>> >>> The remaining changes provide pinmux support, initial device tree >>> support, and SPI, ADC, and MCT IP functionality. >> >> Does FSD have some version number? The FDS, especially in compatibles, >> looks quite generic, so what will happen if a newer SoC comes later? You >> would have: >> - tesla,fsd-pinctrl >> - tesla,fsd-xxxx-pinctrl (where xxxx could be some new version) >> >> This will be extra confusing, because fsd-pinctrl looks like the generic one, >> while it is specific... >> > AFAIK, there is no version for FSD SoC (like we see on Exynos or any other SoC) > In case something comes in future, may be just adopt as Olof suggested in the other thread like fsd2 etc.. >> Best regards, >> Krzysztof The naming is still confusing. The SoC is FSD, compatible is "fsd" but entire sub-architecture is also FSD called. Therefore it looks like creating entire sub-architecture for only one SoC, which actually in multiple pieces is or looks like Samsung Exynos (designed by Samsung, using several blocks from Exynos SoC). Best regards, Krzysztof
Hi! > This patch set adds basic support for the Tesla Full Self-Driving (FSD) > SoC. This SoC contains three clusters of four Cortex-A72 CPUs, > as well as several IPs. I'm not thrilled by their naming. Intel does not produce "Intel Fastest in world SoC", and this chip is not actually suitable for autonomous driving :-(. Pavel
On Sun, Jan 16, 2022 at 1:23 AM Pavel Machek <pavel@ucw.cz> wrote: > > Hi! > > > This patch set adds basic support for the Tesla Full Self-Driving (FSD) > > SoC. This SoC contains three clusters of four Cortex-A72 CPUs, > > as well as several IPs. > > I'm not thrilled by their naming. Intel does not produce "Intel > Fastest in world SoC" If you say so. :) > , and this chip is not actually suitable for > autonomous driving :-(. And AMD's Infinity Fabric isn't.... infinite. Things have names. That discussion seems off-topic for this patchset. It references a marketing name used by the company, and as such it makes sense to be able to cross-reference: https://www.tesla.com/support/full-self-driving-computer Tesla seems to have moved away from the initial "Hardware 3" naming scheme, so using this naming seems as good as any. -Olof
On Mon 2022-01-17 12:53:48, Olof Johansson wrote: > On Sun, Jan 16, 2022 at 1:23 AM Pavel Machek <pavel@ucw.cz> wrote: > > > > Hi! > > > > > This patch set adds basic support for the Tesla Full Self-Driving (FSD) > > > SoC. This SoC contains three clusters of four Cortex-A72 CPUs, > > > as well as several IPs. > > > > I'm not thrilled by their naming. Intel does not produce "Intel > > Fastest in world SoC" > > If you say so. :) > > > , and this chip is not actually suitable for > > autonomous driving :-(. > > And AMD's Infinity Fabric isn't.... infinite. Things have names. > > That discussion seems off-topic for this patchset. It references a > marketing name used by the company, and as such it makes sense to be > able to cross-reference: > https://www.tesla.com/support/full-self-driving-computer > > Tesla seems to have moved away from the initial "Hardware 3" naming > scheme, so using this naming seems as good as any. I'd prefer to call it Tesla HW3. Even wikipedia has that name, no need to do false advertising for Tesla, and we'll have good names for HW2.5 and HW4 if it comes out. We normally use codenames, not marketing names. Best regards, Pavel
This patch set adds basic support for the Tesla Full Self-Driving (FSD) SoC. This SoC contains three clusters of four Cortex-A72 CPUs, as well as several IPs. Patches 1 to 8 provide support for the clock controller (which is designed similarly to Exynos SoCs). The remaining changes provide pinmux support, initial device tree support, and SPI, ADC, and MCT IP functionality. Alim Akhtar (21): dt-bindings: clock: Document FSD CMU bindings dt-bindings: clock: Add bindings definitions for FSD CMU blocks clk: samsung: fsd: Add initial clock support clk: samsung: fsd: Add cmu_peric block clock information clk: samsung: fsd: Add cmu_fsys0 clock information clk: samsung: fsd: Add cmu_fsys1 clock information clk: samsung: fsd: Add cmu_imem block clock information clk: samsung: fsd: Add cmu_mfc block clock information clk: samsung: fsd: Add cam_csi block clock information dt-bindings: pinctrl: samsung: Add compatible for Tesla FSD SoC pinctrl: samsung: add FSD SoC specific data dt-bindings: add vendor prefix for Tesla dt-bindings: arm: add Tesla FSD ARM SoC arm64: dts: fsd: Add initial device tree support arm64: dts: fsd: Add initial pinctrl support arm64: defconfig: Enable Tesla FSD SoC Documentation: bindings: Add fsd spi compatible in dt-bindings document spi: s3c64xx: Add spi port configuration for Tesla FSD SoC dt-bindings: iio: adc: exynos-adc: Add ADC-V3 variant iio: adc: exynos-adc: Add support for ADC V3 controller arm64: dts: fsd: Add ADC device tree node Aswani Reddy (2): arm64: dts: fsd: Add SPI device nodes clocksource: exynos_mct: Add support for handling three clusters .../devicetree/bindings/arm/tesla.yaml | 25 + .../bindings/clock/tesla,fsd-clock.yaml | 212 ++ .../bindings/iio/adc/samsung,exynos-adc.yaml | 1 + .../bindings/pinctrl/samsung-pinctrl.txt | 1 + .../devicetree/bindings/spi/spi-samsung.txt | 1 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + MAINTAINERS | 8 + arch/arm64/Kconfig.platforms | 6 + arch/arm64/boot/dts/Makefile | 1 + arch/arm64/boot/dts/tesla/Makefile | 3 + arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 338 +++ arch/arm64/boot/dts/tesla/fsd.dts | 156 ++ arch/arm64/boot/dts/tesla/fsd.dtsi | 805 +++++++ arch/arm64/configs/defconfig | 1 + drivers/clk/samsung/Makefile | 1 + drivers/clk/samsung/clk-fsd.c | 1858 +++++++++++++++++ drivers/clk/samsung/clk-pll.c | 1 + drivers/clk/samsung/clk-pll.h | 1 + drivers/clocksource/exynos_mct.c | 6 +- drivers/iio/adc/exynos_adc.c | 74 +- .../pinctrl/samsung/pinctrl-exynos-arm64.c | 71 + drivers/pinctrl/samsung/pinctrl-samsung.c | 2 + drivers/pinctrl/samsung/pinctrl-samsung.h | 1 + drivers/spi/spi-s3c64xx.c | 13 + include/dt-bindings/clock/fsd-clk.h | 146 ++ 25 files changed, 3731 insertions(+), 3 deletions(-) create mode 100644 Documentation/devicetree/bindings/arm/tesla.yaml create mode 100644 Documentation/devicetree/bindings/clock/tesla,fsd-clock.yaml create mode 100644 arch/arm64/boot/dts/tesla/Makefile create mode 100644 arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi create mode 100644 arch/arm64/boot/dts/tesla/fsd.dts create mode 100644 arch/arm64/boot/dts/tesla/fsd.dtsi create mode 100644 drivers/clk/samsung/clk-fsd.c create mode 100644 include/dt-bindings/clock/fsd-clk.h base-commit: c9e6606c7fe92b50a02ce51dda82586ebdf99b48