diff mbox series

[v1,1/4] dt-bindings: spi: add mt8186-nor compatible string

Message ID 20220114062408.9077-2-guochun.mao@mediatek.com (mailing list archive)
State New, archived
Headers show
Series mainly add a new SoC support for spi-mtk-nor | expand

Commit Message

Guochun Mao Jan. 14, 2022, 6:24 a.m. UTC
From: Guochun Mao <guochun.mao@mediatek.com>

Add MT8186 spi-nor controller support.
MT8186 needs a new clock name, axi_s, for spi nor axi slave bus clock.

Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
Signed-off-by: Zhen Zhang <zhen.zhang@mediatek.com>
---
 .../devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml         | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Rob Herring Jan. 14, 2022, 2:54 p.m. UTC | #1
On Fri, Jan 14, 2022 at 12:24 AM <guochun.mao@mediatek.com> wrote:
>
> From: Guochun Mao <guochun.mao@mediatek.com>

Use get_maintainers.pl and send to the right lists.

> Add MT8186 spi-nor controller support.
> MT8186 needs a new clock name, axi_s, for spi nor axi slave bus clock.
>
> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
> Signed-off-by: Zhen Zhang <zhen.zhang@mediatek.com>
> ---
>  .../devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml         | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml
> index 4e4694e3d539..1a678751bcca 100644
> --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml
> +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml
> @@ -30,6 +30,7 @@ properties:
>                - mediatek,mt7622-nor
>                - mediatek,mt7623-nor
>                - mediatek,mt7629-nor
> +              - mediatek,mt8186-nor
>                - mediatek,mt8192-nor
>                - mediatek,mt8195-nor
>            - enum:
> @@ -49,6 +50,8 @@ properties:
>        - description: clock used for controller
>        - description: clock used for nor dma bus. this depends on hardware
>                       design, so this is optional.
> +      - description: clock used for controller axi slave bus. this depens
> +                     on hardwre design, so this is optional.

typos.

>
>    clock-names:
>      minItems: 2
> @@ -56,6 +59,7 @@ properties:
>        - const: spi
>        - const: sf
>        - const: axi
> +      - const: axi_s
>
>  required:
>    - compatible
> --
> 2.25.1
>
Guochun Mao Jan. 17, 2022, 2:08 a.m. UTC | #2
Hi Rob,

Thanks for your comments.


On Fri, 2022-01-14 at 08:54 -0600, Rob Herring wrote:
> On Fri, Jan 14, 2022 at 12:24 AM <guochun.mao@mediatek.com> wrote:
> > 
> > From: Guochun Mao <guochun.mao@mediatek.com>
> 
> Use get_maintainers.pl and send to the right lists.
> 

I have already used get_maintainers.pl to get maintainers list.
It shows like this,

./scripts/get_maintainer.pl 00*

Mark Brown <broonie@kernel.org> (maintainer:SPI SUBSYSTEM)
Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND
FLATTENED DEVICE TREE BINDINGS)
Matthias Brugger <matthias.bgg@gmail.com> (maintainer:ARM/Mediatek SoC
support)
Bayi Cheng <bayi.cheng@mediatek.com> (in file)
Chuanhong Guo <gch981213@gmail.com> (in file)
linux-spi@vger.kernel.org (open list:SPI SUBSYSTEM)
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED
DEVICE TREE BINDINGS)
linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC
support)
linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC
support)
linux-kernel@vger.kernel.org (open list)

If you think I need add more reviewers,
could you give me the names who I need to add to these mails?
thanks.

> > Add MT8186 spi-nor controller support.
> > MT8186 needs a new clock name, axi_s, for spi nor axi slave bus
> > clock.
> > 
> > Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
> > Signed-off-by: Zhen Zhang <zhen.zhang@mediatek.com>
> > ---
> >  .../devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml         | 4
> > ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mtk-nor.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mtk-nor.yaml
> > index 4e4694e3d539..1a678751bcca 100644
> > --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-
> > nor.yaml
> > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-
> > nor.yaml
> > @@ -30,6 +30,7 @@ properties:
> >                - mediatek,mt7622-nor
> >                - mediatek,mt7623-nor
> >                - mediatek,mt7629-nor
> > +              - mediatek,mt8186-nor
> >                - mediatek,mt8192-nor
> >                - mediatek,mt8195-nor
> >            - enum:
> > @@ -49,6 +50,8 @@ properties:
> >        - description: clock used for controller
> >        - description: clock used for nor dma bus. this depends on
> > hardware
> >                       design, so this is optional.
> > +      - description: clock used for controller axi slave bus. this
> > depens
> > +                     on hardwre design, so this is optional.
> 
> typos.
> 

I'll fix it next version.

thanks.


> > 
> >    clock-names:
> >      minItems: 2
> > @@ -56,6 +59,7 @@ properties:
> >        - const: spi
> >        - const: sf
> >        - const: axi
> > +      - const: axi_s
> > 
> >  required:
> >    - compatible
> > --
> > 2.25.1
> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml
index 4e4694e3d539..1a678751bcca 100644
--- a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml
+++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml
@@ -30,6 +30,7 @@  properties:
               - mediatek,mt7622-nor
               - mediatek,mt7623-nor
               - mediatek,mt7629-nor
+              - mediatek,mt8186-nor
               - mediatek,mt8192-nor
               - mediatek,mt8195-nor
           - enum:
@@ -49,6 +50,8 @@  properties:
       - description: clock used for controller
       - description: clock used for nor dma bus. this depends on hardware
                      design, so this is optional.
+      - description: clock used for controller axi slave bus. this depens
+                     on hardwre design, so this is optional.
 
   clock-names:
     minItems: 2
@@ -56,6 +59,7 @@  properties:
       - const: spi
       - const: sf
       - const: axi
+      - const: axi_s
 
 required:
   - compatible