| Message ID | 20220113111057.29918-6-yong.wu@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | MT8186 SMI SUPPORT | expand |
On 13/01/2022 12:10, Yong Wu wrote: > Function clk_bulk_prepare_enable() returns 0 for success or a negative > number for error. Fix this code style issue. The message does not really make sense. If negative is returned, then the check (ret < 0) was correct. I guess you wanted to say that common code style is to check for any non-zero return value, just like it's implementation in clk.h does. I'll adjust the commit msg when applying. > > Signed-off-by: Yong Wu <yong.wu@mediatek.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > drivers/memory/mtk-smi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > index b883dcc0bbfa..e7b1a22b12ea 100644 > --- a/drivers/memory/mtk-smi.c > +++ b/drivers/memory/mtk-smi.c > @@ -480,7 +480,7 @@ static int __maybe_unused mtk_smi_larb_resume(struct device *dev) > int ret; > > ret = clk_bulk_prepare_enable(larb->smi.clk_num, larb->smi.clks); > - if (ret < 0) > + if (ret) > return ret; > > /* Configure the basic setting for this larb */ > Best regards, Krzysztof
On Mon, 2022-01-17 at 13:01 +0100, Krzysztof Kozlowski wrote: > On 13/01/2022 12:10, Yong Wu wrote: > > Function clk_bulk_prepare_enable() returns 0 for success or a > > negative > > number for error. Fix this code style issue. > > The message does not really make sense. If negative is returned, then > the check (ret < 0) was correct. > > I guess you wanted to say that common code style is to check for any > non-zero return value, just like it's implementation in clk.h does. > > I'll adjust the commit msg when applying. Thanks for the help. > > > > > Signed-off-by: Yong Wu <yong.wu@mediatek.com> > > Reviewed-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > --- > > drivers/memory/mtk-smi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > > index b883dcc0bbfa..e7b1a22b12ea 100644 > > --- a/drivers/memory/mtk-smi.c > > +++ b/drivers/memory/mtk-smi.c > > @@ -480,7 +480,7 @@ static int __maybe_unused > > mtk_smi_larb_resume(struct device *dev) > > int ret; > > > > ret = clk_bulk_prepare_enable(larb->smi.clk_num, larb- > > >smi.clks); > > - if (ret < 0) > > + if (ret) > > return ret; > > > > /* Configure the basic setting for this larb */ > > Best regards, > Krzysztof
diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c index b883dcc0bbfa..e7b1a22b12ea 100644 --- a/drivers/memory/mtk-smi.c +++ b/drivers/memory/mtk-smi.c @@ -480,7 +480,7 @@ static int __maybe_unused mtk_smi_larb_resume(struct device *dev) int ret; ret = clk_bulk_prepare_enable(larb->smi.clk_num, larb->smi.clks); - if (ret < 0) + if (ret) return ret; /* Configure the basic setting for this larb */