| Message ID | 20220120012553.23295-1-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | [v2] media: dt-bindings: media: renesas,csi2: Update data-lanes property | expand |
Hello Prabhakar On Thu, Jan 20, 2022 at 01:25:53AM +0000, Lad Prabhakar wrote: > CSI-2 (CSI4LNK0) on R-Car and RZ/G2 supports 4-lane mode which is already > handled by rcar-csi2.c driver. This patch updates the data-lanes property > to describe the same. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > Hi All, > > Instead of adding uniqueItems:true into SoC binding doc's I think we could > add this in video-interfaces.yaml for data-lanes property. Any thoughts on this? > As repeating items are not allowed I think it's a good idea. In the meantime this patch looks good to me Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Thanks j > Cheers, > Prabhakar > > v1->v2 > * Dropped const items > * Added uniqueItems > > v1: > https://lore.kernel.org/lkml/20220118163413.ge2b4g75yhfqvq3x@uno.localdomain/T/ > --- > Documentation/devicetree/bindings/media/renesas,csi2.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/renesas,csi2.yaml b/Documentation/devicetree/bindings/media/renesas,csi2.yaml > index e6a036721082..a5a1b570025a 100644 > --- a/Documentation/devicetree/bindings/media/renesas,csi2.yaml > +++ b/Documentation/devicetree/bindings/media/renesas,csi2.yaml > @@ -67,7 +67,11 @@ properties: > maxItems: 1 > > data-lanes: > - maxItems: 1 > + minItems: 1 > + maxItems: 4 > + uniqueItems: true > + items: > + maximum: 4 > > required: > - clock-lanes > -- > 2.17.1 >
On Thu, Jan 20, 2022 at 11:40:29AM +0100, Jacopo Mondi wrote: > Hello Prabhakar > > On Thu, Jan 20, 2022 at 01:25:53AM +0000, Lad Prabhakar wrote: > > CSI-2 (CSI4LNK0) on R-Car and RZ/G2 supports 4-lane mode which is already > > handled by rcar-csi2.c driver. This patch updates the data-lanes property > > to describe the same. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > --- > > Hi All, > > > > Instead of adding uniqueItems:true into SoC binding doc's I think we could > > add this in video-interfaces.yaml for data-lanes property. Any thoughts on this? > > > > As repeating items are not allowed I think it's a good idea. Could this be put into the schema instead? The same holds true for all devices.
Hi Sakari and Jacopo, On Thu, Jan 20, 2022 at 10:41 AM Sakari Ailus <sakari.ailus@linux.intel.com> wrote: > > On Thu, Jan 20, 2022 at 11:40:29AM +0100, Jacopo Mondi wrote: > > Hello Prabhakar > > > > On Thu, Jan 20, 2022 at 01:25:53AM +0000, Lad Prabhakar wrote: > > > CSI-2 (CSI4LNK0) on R-Car and RZ/G2 supports 4-lane mode which is already > > > handled by rcar-csi2.c driver. This patch updates the data-lanes property > > > to describe the same. > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > --- > > > Hi All, > > > > > > Instead of adding uniqueItems:true into SoC binding doc's I think we could > > > add this in video-interfaces.yaml for data-lanes property. Any thoughts on this? > > > > > > > As repeating items are not allowed I think it's a good idea. > > Could this be put into the schema instead? The same holds true for all > devices. > I just came across this patch [0] which does this! Hopefully this will get merged soon. I'll resend a v3 dropping uniqueItems from renesas,csi2.yaml. [0] https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20211223191615.17803-13-p.yadav@ti.com/ Cheers, Prabhakar
diff --git a/Documentation/devicetree/bindings/media/renesas,csi2.yaml b/Documentation/devicetree/bindings/media/renesas,csi2.yaml index e6a036721082..a5a1b570025a 100644 --- a/Documentation/devicetree/bindings/media/renesas,csi2.yaml +++ b/Documentation/devicetree/bindings/media/renesas,csi2.yaml @@ -67,7 +67,11 @@ properties: maxItems: 1 data-lanes: - maxItems: 1 + minItems: 1 + maxItems: 4 + uniqueItems: true + items: + maximum: 4 required: - clock-lanes
CSI-2 (CSI4LNK0) on R-Car and RZ/G2 supports 4-lane mode which is already handled by rcar-csi2.c driver. This patch updates the data-lanes property to describe the same. Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- Hi All, Instead of adding uniqueItems:true into SoC binding doc's I think we could add this in video-interfaces.yaml for data-lanes property. Any thoughts on this? Cheers, Prabhakar v1->v2 * Dropped const items * Added uniqueItems v1: https://lore.kernel.org/lkml/20220118163413.ge2b4g75yhfqvq3x@uno.localdomain/T/ --- Documentation/devicetree/bindings/media/renesas,csi2.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)