[0/1,v2] Patch to adjust coroutine pool size adaptively

Message

成川 弘樹 Jan. 11, 2022, 9:19 a.m. UTC

Resending patch with fixing atomic access method to use qatomic_read().

We encountered random disk IO performance drop since qemu-5.0.0, and this patch fixes it.

Commit message in c740ad92 implied to adjust coroutine pool size adaptively, so I tried to implement this.

Could you review this patch?


Hiroki Narukawa (1):
  util: adjust coroutine pool size to virtio block queue

 hw/block/virtio-blk.c    |  3 +++
 include/qemu/coroutine.h |  5 +++++
 util/qemu-coroutine.c    | 15 +++++++++++----
 3 files changed, 19 insertions(+), 4 deletions(-)

Comments

成川 弘樹 Jan. 24, 2022, 10:01 a.m. UTC | #1

ping, how is the status of this patch?

Link for this patch v2 on patchew is this one: https://patchew.org/QEMU/[e-mail]/
The last message on patch v1 is this one: https://lore.kernel.org/qemu-devel/[e-mail]/T/#u

The difference from v1 is use of qatomic_read().


> Resending patch with fixing atomic access method to use qatomic_read().
> 
> We encountered random disk IO performance drop since qemu-5.0.0, and this
> patch fixes it.
> 
> Commit message in c740ad92 implied to adjust coroutine pool size adaptively, so I
> tried to implement this.
> 
> Could you review this patch?
> 
> 
> Hiroki Narukawa (1):
>   util: adjust coroutine pool size to virtio block queue
> 
>  hw/block/virtio-blk.c    |  3 +++
>  include/qemu/coroutine.h |  5 +++++
>  util/qemu-coroutine.c    | 15 +++++++++++----
>  3 files changed, 19 insertions(+), 4 deletions(-)
> 
> --
> 2.17.1

Stefan Hajnoczi Jan. 26, 2022, 3:38 p.m. UTC | #2

On Mon, Jan 24, 2022 at 10:01:30AM +0000, Hiroki Narukawa wrote:
> ping, how is the status of this patch?
> 
> Link for this patch v2 on patchew is this one: https://patchew.org/QEMU/[e-mail]/
> The last message on patch v1 is this one: https://lore.kernel.org/qemu-devel/[e-mail]/T/#u
> 
> The difference from v1 is use of qatomic_read().

Hi,
Sorry for the slow response. I will review this tomorrow (Thursday)!

Stefan