| Message ID | 20220126165215.1921-1-jszhang@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9e0db41e7a0b6f1271cbcfb16dbf5b8641b4e440 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: stmmac: dwmac-sun8i: use return val of readl_poll_timeout() | expand |
Hi! Dne sreda, 26. januar 2022 ob 17:52:15 CET je Jisheng Zhang napisal(a): > When readl_poll_timeout() timeout, we'd better directly use its return > value. > > Before this patch: > [ 2.145528] dwmac-sun8i: probe of 4500000.ethernet failed with error -14 > > After this patch: > [ 2.138520] dwmac-sun8i: probe of 4500000.ethernet failed with error -110 > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ ethernet/stmicro/stmmac/dwmac-sun8i.c > index 617d0e4c6495..09644ab0d87a 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > @@ -756,7 +756,7 @@ static int sun8i_dwmac_reset(struct stmmac_priv *priv) > > if (err) { > dev_err(priv->device, "EMAC reset timeout\n"); > - return -EFAULT; > + return err; > } > return 0; > } > -- > 2.34.1 > >
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Thu, 27 Jan 2022 00:52:15 +0800 you wrote: > When readl_poll_timeout() timeout, we'd better directly use its return > value. > > Before this patch: > [ 2.145528] dwmac-sun8i: probe of 4500000.ethernet failed with error -14 > > After this patch: > [ 2.138520] dwmac-sun8i: probe of 4500000.ethernet failed with error -110 > > [...] Here is the summary with links: - net: stmmac: dwmac-sun8i: use return val of readl_poll_timeout() https://git.kernel.org/netdev/net/c/9e0db41e7a0b You are awesome, thank you!
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c index 617d0e4c6495..09644ab0d87a 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c @@ -756,7 +756,7 @@ static int sun8i_dwmac_reset(struct stmmac_priv *priv) if (err) { dev_err(priv->device, "EMAC reset timeout\n"); - return -EFAULT; + return err; } return 0; }
When readl_poll_timeout() timeout, we'd better directly use its return value. Before this patch: [ 2.145528] dwmac-sun8i: probe of 4500000.ethernet failed with error -14 After this patch: [ 2.138520] dwmac-sun8i: probe of 4500000.ethernet failed with error -110 Signed-off-by: Jisheng Zhang <jszhang@kernel.org> --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)