| Message ID | 20220120070226.1492-3-biao.huang@mediatek.com (mailing list archive) |
|---|---|
| State | Deferred |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | add more features support for mtk-star-emac | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Series has a cover letter |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 10 of 10 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On Thu, Jan 20, 2022 at 8:02 AM Biao Huang <biao.huang@mediatek.com> wrote: > > If the flags in request_irq() is IRQF_TRIGGER_NONE, the trigger method > is determined by "interrupt" property in dts. > So, modify the flag from IRQF_TRIGGER_FALLING to IRQF_TRIGGER_NONE. > > Signed-off-by: Biao Huang <biao.huang@mediatek.com> > Signed-off-by: Yinghua Pan <ot_yinghua.pan@mediatek.com> > --- > drivers/net/ethernet/mediatek/mtk_star_emac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c > index 26f5020f2e9c..7c2af775d601 100644 > --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c > +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c > @@ -959,7 +959,7 @@ static int mtk_star_enable(struct net_device *ndev) > > /* Request the interrupt */ > ret = request_irq(ndev->irq, mtk_star_handle_irq, > - IRQF_TRIGGER_FALLING, ndev->name, ndev); > + IRQF_TRIGGER_NONE, ndev->name, ndev); > if (ret) > goto err_free_skbs; > > -- > 2.25.1 > Reviewed-by: Bartosz Golaszewski <brgl@bgdev.pl>
Dear Bartosz, Thanks for your comments! On Tue, 2022-01-25 at 11:22 +0100, Bartosz Golaszewski wrote: > On Thu, Jan 20, 2022 at 8:02 AM Biao Huang <biao.huang@mediatek.com> > wrote: > > > > If the flags in request_irq() is IRQF_TRIGGER_NONE, the trigger > > method > > is determined by "interrupt" property in dts. > > So, modify the flag from IRQF_TRIGGER_FALLING to IRQF_TRIGGER_NONE. > > > > Signed-off-by: Biao Huang <biao.huang@mediatek.com> > > Signed-off-by: Yinghua Pan <ot_yinghua.pan@mediatek.com> > > --- > > drivers/net/ethernet/mediatek/mtk_star_emac.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c > > b/drivers/net/ethernet/mediatek/mtk_star_emac.c > > index 26f5020f2e9c..7c2af775d601 100644 > > --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c > > +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c > > @@ -959,7 +959,7 @@ static int mtk_star_enable(struct net_device > > *ndev) > > > > /* Request the interrupt */ > > ret = request_irq(ndev->irq, mtk_star_handle_irq, > > - IRQF_TRIGGER_FALLING, ndev->name, ndev); > > + IRQF_TRIGGER_NONE, ndev->name, ndev); > > if (ret) > > goto err_free_skbs; > > > > -- > > 2.25.1 > > > > Reviewed-by: Bartosz Golaszewski <brgl@bgdev.pl> I'll add reviewd-by in next send.
diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c index 26f5020f2e9c..7c2af775d601 100644 --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c @@ -959,7 +959,7 @@ static int mtk_star_enable(struct net_device *ndev) /* Request the interrupt */ ret = request_irq(ndev->irq, mtk_star_handle_irq, - IRQF_TRIGGER_FALLING, ndev->name, ndev); + IRQF_TRIGGER_NONE, ndev->name, ndev); if (ret) goto err_free_skbs;