| Message ID | 20220126121426.53799-2-greg@hurrell.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7838d9c2a9c246b6e59bcb4d48f70b919fe1f2c0 |
| Headers | show |
| Series | Apply minor fixes to Documentation/config/pgp.txt | expand |
Greg Hurrell <greg@hurrell.net> writes: > Specifically, replace the tab between "the" and "first" with a space. Good eyes. Does it have ANY practical downside to leave it unfixed? In other words, how did you spot it (e.g. "asciidoctor passes tab as-is and screwed up an alignment of the text, which was how I noticed it")? Thanks. > > Signed-off-by: Greg Hurrell <greg@hurrell.net> > --- > Documentation/config/gpg.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/config/gpg.txt b/Documentation/config/gpg.txt > index 0cb189a077..abfabd6d62 100644 > --- a/Documentation/config/gpg.txt > +++ b/Documentation/config/gpg.txt > @@ -37,7 +37,7 @@ gpg.minTrustLevel:: > gpg.ssh.defaultKeyCommand:: > This command that will be run when user.signingkey is not set and a ssh > signature is requested. On successful exit a valid ssh public key is > - expected in the first line of its output. To automatically use the first > + expected in the first line of its output. To automatically use the first > available key from your ssh-agent set this to "ssh-add -L". > > gpg.ssh.allowedSignersFile::
On Thu, Jan 27, 2022, at 3:30 AM, Junio C Hamano wrote: > Greg Hurrell <greg@hurrell.net> writes: > > > Specifically, replace the tab between "the" and "first" with a space. > > Good eyes. Does it have ANY practical downside to leave it unfixed? > > In other words, how did you spot it (e.g. "asciidoctor passes tab as-is > and screwed up an alignment of the text, which was how I noticed it")? The nearby fix (the apostrophe) in the other commit was what had me looking at this file in the first place. But my editor (Neovim) made the mid-line tab visually obvious, so I figured may as well clean it up along the way; on my screen it looked something like this: ▷┅┅┅signature is requested. On successful exit a valid ssh public key is ▷┅┅┅expected in the▷┅┅┅first line of its output. To automatically use the first ▷┅┅┅available key from your ssh-agent set this to "ssh-add -L". Vim's "listchars" setting is responsible for making tabs visible like that: :set listchars=extends:»,nbsp:⦸,precedes:«,tab:▷⋯,trail:• Greg
"Greg Hurrell" <greg@hurrell.net> writes: > On Thu, Jan 27, 2022, at 3:30 AM, Junio C Hamano wrote: >> Greg Hurrell <greg@hurrell.net> writes: >> >> > Specifically, replace the tab between "the" and "first" with a space. >> >> Good eyes. Does it have ANY practical downside to leave it unfixed? >> >> In other words, how did you spot it (e.g. "asciidoctor passes tab as-is >> and screwed up an alignment of the text, which was how I noticed it")? > > The nearby fix (the apostrophe) in the other commit was what had me > looking at this file in the first place. But my editor (Neovim) > made the mid-line tab visually obvious, so I figured may as well clean Ah, yes, highlighting editors and pagers. I forgot about them. In any case, thanks for the fixes. Queued.
diff --git a/Documentation/config/gpg.txt b/Documentation/config/gpg.txt index 0cb189a077..abfabd6d62 100644 --- a/Documentation/config/gpg.txt +++ b/Documentation/config/gpg.txt @@ -37,7 +37,7 @@ gpg.minTrustLevel:: gpg.ssh.defaultKeyCommand:: This command that will be run when user.signingkey is not set and a ssh signature is requested. On successful exit a valid ssh public key is - expected in the first line of its output. To automatically use the first + expected in the first line of its output. To automatically use the first available key from your ssh-agent set this to "ssh-add -L". gpg.ssh.allowedSignersFile::
Specifically, replace the tab between "the" and "first" with a space. Signed-off-by: Greg Hurrell <greg@hurrell.net> --- Documentation/config/gpg.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)