diff mbox series

phy: stm32: fix a refcount leak in stm32_usbphyc_pll_enable()

Message ID 20220112111724.GB3019@kili
State Accepted
Commit cfc826c88a79e22ba5d8001556eb2c7efd8a01b6
Headers show
Series phy: stm32: fix a refcount leak in stm32_usbphyc_pll_enable() | expand

Commit Message

Dan Carpenter Jan. 12, 2022, 11:17 a.m. UTC 
This error path needs to decrement "usbphyc->n_pll_cons.counter" before
returning.

Fixes: 5b1af71280ab ("phy: stm32: rework PLL Lock detection")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/phy/st/phy-stm32-usbphyc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Vinod Koul Jan. 27, 2022, 5:34 a.m. UTC | #1 
On 12-01-22, 14:17, Dan Carpenter wrote:
> This error path needs to decrement "usbphyc->n_pll_cons.counter" before
> returning.

Applied, thanks
diff mbox series

Patch

diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
index 2ce9bfd783d4..007a23c78d56 100644
--- a/drivers/phy/st/phy-stm32-usbphyc.c
+++ b/drivers/phy/st/phy-stm32-usbphyc.c
@@ -304,7 +304,7 @@  static int stm32_usbphyc_pll_enable(struct stm32_usbphyc *usbphyc)
 
 		ret = __stm32_usbphyc_pll_disable(usbphyc);
 		if (ret)
-			return ret;
+			goto dec_n_pll_cons;
 	}
 
 	ret = stm32_usbphyc_regulators_enable(usbphyc);