| Message ID | 20220111071806.GD11243@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto: qat - fix a signedness bug in get_service_enabled() | expand |
On Tue, Jan 11, 2022 at 10:18:06AM +0300, Dan Carpenter wrote: > The "ret" variable needs to be signed or there is an error message which > will not be printed correctly. > > Fixes: 0cec19c761e5 ("crypto: qat - add support for compression for 4xxx") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Thanks Dan. Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com> @Herbert, there are 2 other (identical) patches in the list that fix the same issue: https://patchwork.kernel.org/project/linux-crypto/patch/YdWZm6QJAYbYTKAR@debian-BULLSEYE-live-builder-AMD64/ https://patchwork.kernel.org/project/linux-crypto/patch/20220105152005.43305-1-jiapeng.chong@linux.alibaba.com/ Since none of them made into the pull request for 5.17, I'm fine with taking this one as it is the only one which contains the Fixes tag. Regards,
On Tue, Jan 11, 2022 at 10:18:06AM +0300, Dan Carpenter wrote: > The "ret" variable needs to be signed or there is an error message which > will not be printed correctly. > > Fixes: 0cec19c761e5 ("crypto: qat - add support for compression for 4xxx") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks.
diff --git a/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c b/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c index 6d10edc40aca..68d39c833332 100644 --- a/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c +++ b/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c @@ -52,7 +52,7 @@ static const char *const dev_cfg_services[] = { static int get_service_enabled(struct adf_accel_dev *accel_dev) { char services[ADF_CFG_MAX_VAL_LEN_IN_BYTES] = {0}; - u32 ret; + int ret; ret = adf_cfg_get_param_value(accel_dev, ADF_GENERAL_SEC, ADF_SERVICES_ENABLED, services);
The "ret" variable needs to be signed or there is an error message which will not be printed correctly. Fixes: 0cec19c761e5 ("crypto: qat - add support for compression for 4xxx") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)