| Message ID | 20220127101609.3646316-1-josephsih@chromium.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [BlueZ,v2,1/4] doc: Add Bluetooth quality report event | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/checkpatch | success | Checkpatch PASS |
| tedd_an/gitlint | success | Gitlint PASS |
| tedd_an/setupell | success | Setup ELL PASS |
| tedd_an/buildprep | success | Build Prep PASS |
| tedd_an/build | success | Build Configuration PASS |
| tedd_an/makecheck | success | Make Check PASS |
| tedd_an/makecheckvalgrind | success | Make Check PASS |
| tedd_an/makedistcheck | success | Make Distcheck PASS |
| tedd_an/build_extell | success | Build External ELL PASS |
| tedd_an/build_extell_make | success | Build Make with External ELL PASS |
| tedd_an/incremental_build | success | Pass |
Hi Joseph, > Add the Bluetooth quality report event in doc/mgmt-api.txt. > > Signed-off-by: Joseph Hwang <josephsih@chromium.org> > --- > > Changes in v2: > - This is a new patch for adding the event in doc/mgmt-api.txt > > doc/mgmt-api.txt | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt > index ebe56afa4..a0e71a732 100644 > --- a/doc/mgmt-api.txt > +++ b/doc/mgmt-api.txt > @@ -4978,3 +4978,23 @@ Advertisement Monitor Device Lost Event > 2 LE Random > > This event will be sent to all management sockets. > + > + > +Bluetooth Quality Report Event > +============================== > + > + Event code: 0x0031 > + Controller Index: <controller_id> > + Event Parameters: Quality_Spec (1 Octet) > + Report_Len (2 Octets) > + Report (0-65535 Octets) > + > + This event carries the Bluetooth quality report sent by the > + controller. > + > + Possible values for the Quality_Spec parameter: > + 0 Not Available > + 1 Intel Telemetry Event > + 2 AOSP Bluetooth Quality Report Event can we swap this around please: 0 AOSP Bluetooth Quality Report Event 1 Intel Telemetry Event Regards Marcel
Hi Marcel, Joseph, On Thu, Jan 27, 2022 at 12:02 PM Marcel Holtmann <marcel@holtmann.org> wrote: > > Hi Joseph, > > > Add the Bluetooth quality report event in doc/mgmt-api.txt. > > > > Signed-off-by: Joseph Hwang <josephsih@chromium.org> > > --- > > > > Changes in v2: > > - This is a new patch for adding the event in doc/mgmt-api.txt > > > > doc/mgmt-api.txt | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt > > index ebe56afa4..a0e71a732 100644 > > --- a/doc/mgmt-api.txt > > +++ b/doc/mgmt-api.txt > > @@ -4978,3 +4978,23 @@ Advertisement Monitor Device Lost Event > > 2 LE Random > > > > This event will be sent to all management sockets. > > + > > + > > +Bluetooth Quality Report Event > > +============================== > > + > > + Event code: 0x0031 > > + Controller Index: <controller_id> > > + Event Parameters: Quality_Spec (1 Octet) > > + Report_Len (2 Octets) > > + Report (0-65535 Octets) > > + > > + This event carries the Bluetooth quality report sent by the > > + controller. > > + > > + Possible values for the Quality_Spec parameter: > > + 0 Not Available > > + 1 Intel Telemetry Event > > + 2 AOSP Bluetooth Quality Report Event > > can we swap this around please: > > 0 AOSP Bluetooth Quality Report Event > 1 Intel Telemetry Event > > Regards > > Marcel I wonder if we shouldn't have these as bit fields though, so one can select multiple reports if available.
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=609026 ---Test result--- Test Summary: CheckPatch PASS 6.62 seconds GitLint PASS 4.23 seconds Prep - Setup ELL PASS 53.22 seconds Build - Prep PASS 0.74 seconds Build - Configure PASS 10.74 seconds Build - Make PASS 1519.99 seconds Make Check PASS 13.07 seconds Make Check w/Valgrind PASS 547.72 seconds Make Distcheck PASS 310.18 seconds Build w/ext ELL - Configure PASS 12.03 seconds Build w/ext ELL - Make PASS 1530.38 seconds Incremental Build with patchesPASS 6168.51 seconds --- Regards, Linux Bluetooth
Hi Luiz, >>> Add the Bluetooth quality report event in doc/mgmt-api.txt. >>> >>> Signed-off-by: Joseph Hwang <josephsih@chromium.org> >>> --- >>> >>> Changes in v2: >>> - This is a new patch for adding the event in doc/mgmt-api.txt >>> >>> doc/mgmt-api.txt | 20 ++++++++++++++++++++ >>> 1 file changed, 20 insertions(+) >>> >>> diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt >>> index ebe56afa4..a0e71a732 100644 >>> --- a/doc/mgmt-api.txt >>> +++ b/doc/mgmt-api.txt >>> @@ -4978,3 +4978,23 @@ Advertisement Monitor Device Lost Event >>> 2 LE Random >>> >>> This event will be sent to all management sockets. >>> + >>> + >>> +Bluetooth Quality Report Event >>> +============================== >>> + >>> + Event code: 0x0031 >>> + Controller Index: <controller_id> >>> + Event Parameters: Quality_Spec (1 Octet) >>> + Report_Len (2 Octets) >>> + Report (0-65535 Octets) >>> + >>> + This event carries the Bluetooth quality report sent by the >>> + controller. >>> + >>> + Possible values for the Quality_Spec parameter: >>> + 0 Not Available >>> + 1 Intel Telemetry Event >>> + 2 AOSP Bluetooth Quality Report Event >> >> can we swap this around please: >> >> 0 AOSP Bluetooth Quality Report Event >> 1 Intel Telemetry Event >> >> Regards >> >> Marcel > > I wonder if we shouldn't have these as bit fields though, so one can > select multiple reports if available. the current code only allows for enabling one of these. If a driver specific one is specified, it takes precedence over the AOSP one, other AOSP is chosen (if supported). Reality is that all major vendors are settling on the AOSP extension since they already have that in their firmwares. So actually I don’t expect to see any other than AOSP or Intel. Regards Marcel
Hi Jospeh, > Add the Bluetooth quality report event in doc/mgmt-api.txt. > > Signed-off-by: Joseph Hwang <josephsih@chromium.org> > --- > > Changes in v2: > - This is a new patch for adding the event in doc/mgmt-api.txt > > doc/mgmt-api.txt | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt > index ebe56afa4..a0e71a732 100644 > --- a/doc/mgmt-api.txt > +++ b/doc/mgmt-api.txt > @@ -4978,3 +4978,23 @@ Advertisement Monitor Device Lost Event > 2 LE Random > > This event will be sent to all management sockets. > + > + > +Bluetooth Quality Report Event > +============================== > + > + Event code: 0x0031 > + Controller Index: <controller_id> > + Event Parameters: Quality_Spec (1 Octet) > + Report_Len (2 Octets) > + Report (0-65535 Octets) > + > + This event carries the Bluetooth quality report sent by the > + controller. > + > + Possible values for the Quality_Spec parameter: > + 0 Not Available > + 1 Intel Telemetry Event > + 2 AOSP Bluetooth Quality Report Event > + > + This event will be sent to all management sockets. > -- and since you are now adding a mgmt event, we can no longer use debug setting to enable this feature. diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt index ebe56afa4494..ff7d81af2f90 100644 --- a/doc/mgmt-api.txt +++ b/doc/mgmt-api.txt @@ -332,6 +332,7 @@ Read Controller Information Command 15 Static Address 16 PHY Configuration 17 Wideband Speech + 18 Quality Report This command generates a Command Complete event on success or a Command Status event on failure. @@ -2924,6 +2925,7 @@ Read Extended Controller Information Command 15 Static Address 16 PHY Configuration 17 Wideband Speech + 18 Quality Report The EIR_Data field contains information about class of device, local name and other values. Not all of them might be present. For @@ -3858,6 +3860,15 @@ Add Advertisement Patterns Monitor With RSSI Threshold Command Invalid Parameters +Set Quality Report Command +========================== + + Command Code: 0x0057 + Controller Index: <controller id> + Command Parameters: Quality_Report (1 Octet) + Return Parameters: Current_Settings (4 Octets) + + Command Complete Event ====================== Please add a Set Quality Report command for this as well. You need to fill in the description, but you get the idea. Regards Marcel
diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt index ebe56afa4..a0e71a732 100644 --- a/doc/mgmt-api.txt +++ b/doc/mgmt-api.txt @@ -4978,3 +4978,23 @@ Advertisement Monitor Device Lost Event 2 LE Random This event will be sent to all management sockets. + + +Bluetooth Quality Report Event +============================== + + Event code: 0x0031 + Controller Index: <controller_id> + Event Parameters: Quality_Spec (1 Octet) + Report_Len (2 Octets) + Report (0-65535 Octets) + + This event carries the Bluetooth quality report sent by the + controller. + + Possible values for the Quality_Spec parameter: + 0 Not Available + 1 Intel Telemetry Event + 2 AOSP Bluetooth Quality Report Event + + This event will be sent to all management sockets.
Add the Bluetooth quality report event in doc/mgmt-api.txt. Signed-off-by: Joseph Hwang <josephsih@chromium.org> --- Changes in v2: - This is a new patch for adding the event in doc/mgmt-api.txt doc/mgmt-api.txt | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)