[net-next,v6,00/13] net: dsa: realtek: MDIO interface and RTL8367S,RTL8367RB-VB

Message

Luiz Angelo Daros de Luca Jan. 28, 2022, 6:04 a.m. UTC

The old realtek-smi driver was linking subdrivers into a single
realtek-smi.ko After this series, each subdriver will be an independent
module required by either realtek-smi (platform driver) or the new
realtek-mdio (mdio driver). Both interface drivers (SMI or MDIO) are
independent, and they might even work side-by-side, although it will be
difficult to find such device. The subdriver can be individually
selected but only at buildtime, saving some storage space for custom
embedded systems.

Existing realtek-smi devices continue to work untouched during the
tests. The realtek-smi was moved into a realtek subdirectory, but it
normally does not break things.

I couldn't identify a fixed relation between port numbers (0..9) and
external interfaces (0..2), and I'm not sure if it is fixed for each
chip version or a device configuration. Until there is more info about
it, there is a new port property "realtek,ext-int" that can inform the
external interface.

The rtl8365mb might now handle multiple CPU ports and extint ports not
used as CPU ports. RTL8367S has an SGMII external interface, but my test
device (TP-Link Archer C5v4) uses only the second RGMII interface. We
need a test device with more external ports to test these features.
The driver still cannot handle SGMII ports.

RTL8367RB-VB support was added using information from Frank Wunderlich
<[e-mail]> but I didn't test it myself.

The rtl8365mb was tested with a MDIO-connected RTL8367S (TP-Link Acher
C5v4) and a SMI-connected RTL8365MB-VC switch (Asus RT-AC88U)

The rtl8366rb subdriver was not tested with this patch series, but it
was only slightly touched. It would be nice to test it, especially in an
MDIO-connected switch.

Best,

Luiz

Changelog:

v1-v2)
- formatting fixes
- dropped the rtl8365mb->rtl8367c rename
- other suggestions

v2-v3)
* realtek-mdio.c:
  - cleanup realtek-mdio.c (BUG_ON, comments and includes)   
  - check devm_regmap_init return code
  - removed realtek,rtl8366s string from realtek-mdio
* realtek-smi.c:
  - removed void* type cast
* rtl8365mb.c:
  - using macros to identify EXT interfaces
  - rename some extra extport->extint cases
  - allow extint as non cpu (not tested)
  - allow multple cpu ports (not tested)
  - dropped cpu info from struct rtl8365mb
* dropped dt-bindings changes (dealing outside this series)
* formatting issues fixed

v3-v4)
* fix cover message numbering 0/13 -> 0/11
* use static for realtek_mdio_read_reg
  - Reported-by: kernel test robot <[e-mail]>
* use dsa_switch_for_each_cpu_port
* mention realtek_smi_{variant,ops} to realtek_{variant,ops}
  in commit message

v5) sent again v4 branch. Sorry

v4-v6)
- added support for RTL8367RB-VB
- cleanup mdio_{read,write}, removing misterious START_OP, checking and
  returning errors
- renamed priv->phy_id to priv->mdio_addr
- duplicated priv->ds_ops into ds_ops_{smi,mdio}. ds_ops_smi must not
  set
  phy_read or else both dsa and this driver might free slave_mii.
Dropped
  401fd75c92f37
- Map port to extint using code instead of device-tree property. Added
  comment 
  about port number, port description and external interfaces. Dropped
  'realtek,ext-int' device-tree property
- Redacted the non-cpu ext port commit message, not highlighting the
  possibility of using multiple CPU ports as it was just a byproduct.
- In a possible case of multiple cpu ports, use the first one as the
  trap port.
  Dropped 'realtek,trap-port' device-tree property
- Some formatting fixes
- BUG: rtl8365mb_phy_mode_supported was still checking for a cpu port
  and not
  an external interface
- BUG: fix trapdoor masking for port>7. Got a compiler error with a
  bigger
  constant value
- WARN: completed kdoc for rtl8366rb_drop_untagged()
- WARN: removed marks from incomplete kdoc

Comments

[e-mail] Jan. 28, 2022, 3:10 p.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <[e-mail]>:

On Fri, 28 Jan 2022 03:04:56 -0300 you wrote:
> The old realtek-smi driver was linking subdrivers into a single
> realtek-smi.ko After this series, each subdriver will be an independent
> module required by either realtek-smi (platform driver) or the new
> realtek-mdio (mdio driver). Both interface drivers (SMI or MDIO) are
> independent, and they might even work side-by-side, although it will be
> difficult to find such device. The subdriver can be individually
> selected but only at buildtime, saving some storage space for custom
> embedded systems.
> 
> [...]

Here is the summary with links:
  - [net-next,v6,01/13] net: dsa: realtek-smi: fix kdoc warnings
    https://git.kernel.org/netdev/net-next/c/0f0c6da03ba3
  - [net-next,v6,02/13] net: dsa: realtek-smi: move to subdirectory
    https://git.kernel.org/netdev/net-next/c/319a70a5fea9
  - [net-next,v6,03/13] net: dsa: realtek: rename realtek_smi to realtek_priv
    https://git.kernel.org/netdev/net-next/c/f5f119077b1c
  - [net-next,v6,04/13] net: dsa: realtek: remove direct calls to realtek-smi
    https://git.kernel.org/netdev/net-next/c/cd645dc556e2
  - [net-next,v6,05/13] net: dsa: realtek: convert subdrivers into modules
    https://git.kernel.org/netdev/net-next/c/765c39a4fafe
  - [net-next,v6,06/13] net: dsa: realtek: add new mdio interface for drivers
    https://git.kernel.org/netdev/net-next/c/aac94001067d
  - [net-next,v6,07/13] net: dsa: realtek: rtl8365mb: rename extport to extint
    https://git.kernel.org/netdev/net-next/c/d18b59f48b31
  - [net-next,v6,08/13] net: dsa: realtek: rtl8365mb: use GENMASK(n-1,0) instead of BIT(n)-1
    https://git.kernel.org/netdev/net-next/c/c45e0fef9f89
  - [net-next,v6,09/13] net: dsa: realtek: rtl8365mb: use DSA CPU port
    https://git.kernel.org/netdev/net-next/c/7fa8af30ecdf
  - [net-next,v6,10/13] net: dsa: realtek: rtl8365mb: add RTL8367S support
    https://git.kernel.org/netdev/net-next/c/d40f607c181f
  - [net-next,v6,11/13] net: dsa: realtek: rtl8365mb: add RTL8367RB-VB support
    https://git.kernel.org/netdev/net-next/c/84a10aecdcc0
  - [net-next,v6,12/13] net: dsa: realtek: rtl8365mb: allow non-cpu extint ports
    https://git.kernel.org/netdev/net-next/c/6147631c079f
  - [net-next,v6,13/13] net: dsa: realtek: rtl8365mb: fix trap_door > 7
    https://git.kernel.org/netdev/net-next/c/078ae1bdd32d

You are awesome, thank you!