mbox series

[0/3] SoC: SOF: ipc: Optimizations for tx message

Message ID 20220128133620.9411-1-peter.ujfalusi@linux.intel.com (mailing list archive)
Headers show
Series SoC: SOF: ipc: Optimizations for tx message | expand

Message

Peter Ujfalusi Jan. 28, 2022, 1:36 p.m. UTC
Hi,

The series will drop the internal use of 'header' parameter which is always
set to hdr->cmd.

The other simplification is to use the provided message directly as it is
guarantied to be valid throughout the message sending and we can save memory
by not allocating a temporary buffer, also saving on needles memcpy()
operations.

Regards,
Peter
---
Peter Ujfalusi (3):
  ASoC: SOF: Intel: cnl: Use pm_gate->hdr.cmd in
    cnl_compact_ipc_compress()
  ASoC: SOF: ipc: Drop header parameter from
    sof_ipc_tx_message_unlocked()
  ASoC: SOF: ipc: Do not allocate buffer for msg_data

 sound/soc/sof/intel/cnl.c |  6 ++----
 sound/soc/sof/ipc.c       | 24 ++++++++++++------------
 2 files changed, 14 insertions(+), 16 deletions(-)

Comments

Mark Brown Jan. 28, 2022, 11:47 p.m. UTC | #1
On Fri, 28 Jan 2022 15:36:17 +0200, Peter Ujfalusi wrote:
> The series will drop the internal use of 'header' parameter which is always
> set to hdr->cmd.
> 
> The other simplification is to use the provided message directly as it is
> guarantied to be valid throughout the message sending and we can save memory
> by not allocating a temporary buffer, also saving on needles memcpy()
> operations.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] ASoC: SOF: Intel: cnl: Use pm_gate->hdr.cmd in cnl_compact_ipc_compress()
      commit: 5b6988fe844a298263821beef5fcc41286a048dc
[2/3] ASoC: SOF: ipc: Drop header parameter from sof_ipc_tx_message_unlocked()
      commit: 73a548bd1fa3cbe5d18026230a34c1f058257536
[3/3] ASoC: SOF: ipc: Do not allocate buffer for msg_data
      commit: 2acfab7101140e93928a61ca48d7e442aa538dd7

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark