diff mbox series

net: dsa: mt7530: make NET_DSA_MT7530 select MEDIATEK_GE_PHY

Message ID 20220128170544.4131-1-arinc.unal@arinc9.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series net: dsa: mt7530: make NET_DSA_MT7530 select MEDIATEK_GE_PHY | expand

Checks

Context Check Description
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers warning 1 maintainers not CCed: kuba@kernel.org
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/tree_selection success Guessing tree name failed - patch did not apply

Commit Message

Arınç ÜNAL Jan. 28, 2022, 5:05 p.m. UTC
Make MediaTek MT753x DSA driver enable MediaTek Gigabit PHYs driver to
properly control MT7530 and MT7531 switch PHYs.

A noticeable change is that the behaviour of switchport interfaces going
up-down-up-down is no longer there.

Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
---
 drivers/net/dsa/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Andrew Lunn Jan. 28, 2022, 5:18 p.m. UTC | #1
On Fri, Jan 28, 2022 at 08:05:45PM +0300, Arınç ÜNAL wrote:
> Make MediaTek MT753x DSA driver enable MediaTek Gigabit PHYs driver to
> properly control MT7530 and MT7531 switch PHYs.
> 
> A noticeable change is that the behaviour of switchport interfaces going
> up-down-up-down is no longer there.
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Florian Fainelli Jan. 28, 2022, 5:30 p.m. UTC | #2
On 1/28/2022 9:05 AM, Arınç ÜNAL wrote:
> Make MediaTek MT753x DSA driver enable MediaTek Gigabit PHYs driver to
> properly control MT7530 and MT7531 switch PHYs.
> 
> A noticeable change is that the behaviour of switchport interfaces going
> up-down-up-down is no longer there.
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Jakub Kicinski Jan. 28, 2022, 10:31 p.m. UTC | #3
On Fri, 28 Jan 2022 20:05:45 +0300 Arınç ÜNAL wrote:
> Make MediaTek MT753x DSA driver enable MediaTek Gigabit PHYs driver to
> properly control MT7530 and MT7531 switch PHYs.
> 
> A noticeable change is that the behaviour of switchport interfaces going
> up-down-up-down is no longer there.
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>

Sounds like a fix, can we get a Fixes tag?
Arınç ÜNAL Jan. 29, 2022, 6:31 a.m. UTC | #4
On 29/01/2022 01:31, Jakub Kicinski wrote:
> On Fri, 28 Jan 2022 20:05:45 +0300 Arınç ÜNAL wrote:
>> Make MediaTek MT753x DSA driver enable MediaTek Gigabit PHYs driver to
>> properly control MT7530 and MT7531 switch PHYs.
>>
>> A noticeable change is that the behaviour of switchport interfaces going
>> up-down-up-down is no longer there.
>>
>> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> 
> Sounds like a fix, can we get a Fixes tag?

Sent v2. I didn't realise you weren't in the recipients, sorry.

https://lore.kernel.org/netdev/20220129062703.595-1-arinc.unal@arinc9.com/T/#u

Arınç
diff mbox series

Patch

diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig
index 7b1457a6e327..c0c91440340a 100644
--- a/drivers/net/dsa/Kconfig
+++ b/drivers/net/dsa/Kconfig
@@ -36,6 +36,7 @@  config NET_DSA_LANTIQ_GSWIP
 config NET_DSA_MT7530
 	tristate "MediaTek MT753x and MT7621 Ethernet switch support"
 	select NET_DSA_TAG_MTK
+	select MEDIATEK_GE_PHY
 	help
 	  This enables support for the MediaTek MT7530, MT7531, and MT7621
 	  Ethernet switch chips.