diff mbox series

[v2,4/4] ARM: dts: suniv: Enable mmc for f1c100s.

Message ID 20220130220325.1983918-4-Mr.Bossman075@gmail.com (mailing list archive)
State New, archived
Headers show
Series [v2,1/4] ARM: dtsi: suniv: F1c100s add clock and reset macros | expand

Commit Message

Jesse Taube Jan. 30, 2022, 10:03 p.m. UTC
Enable mmc0 in f1c100s-licheepi-nano device tree.

Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
---
V1 -> V2:
* New patch
---
 arch/arm/boot/dts/suniv-f1c100s-licheepi-nano.dts | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Maxime Ripard Jan. 31, 2022, 9:46 a.m. UTC | #1
On Sun, Jan 30, 2022 at 05:03:25PM -0500, Jesse Taube wrote:
> Enable mmc0 in f1c100s-licheepi-nano device tree.
> 
> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
> ---
> V1 -> V2:
> * New patch
> ---
>  arch/arm/boot/dts/suniv-f1c100s-licheepi-nano.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/suniv-f1c100s-licheepi-nano.dts b/arch/arm/boot/dts/suniv-f1c100s-licheepi-nano.dts
> index a1154e6c7cb5..c856a6a20dc8 100644
> --- a/arch/arm/boot/dts/suniv-f1c100s-licheepi-nano.dts
> +++ b/arch/arm/boot/dts/suniv-f1c100s-licheepi-nano.dts
> @@ -24,3 +24,9 @@ &uart0 {
>  	pinctrl-0 = <&uart0_pe_pins>;
>  	status = "okay";
>  };
> +
> +&mmc0 {
> +	bus-width = <4>;
> +	broken-cd;
> +	status = "okay";
> +};

The labels are ordered alphabetically

Maxime
Andre Przywara Jan. 31, 2022, 10:17 a.m. UTC | #2
On Sun, 30 Jan 2022 17:03:25 -0500
Jesse Taube <mr.bossman075@gmail.com> wrote:

> Enable mmc0 in f1c100s-licheepi-nano device tree.
> 
> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
> ---
> V1 -> V2:
> * New patch
> ---
>  arch/arm/boot/dts/suniv-f1c100s-licheepi-nano.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/suniv-f1c100s-licheepi-nano.dts b/arch/arm/boot/dts/suniv-f1c100s-licheepi-nano.dts
> index a1154e6c7cb5..c856a6a20dc8 100644
> --- a/arch/arm/boot/dts/suniv-f1c100s-licheepi-nano.dts
> +++ b/arch/arm/boot/dts/suniv-f1c100s-licheepi-nano.dts
> @@ -24,3 +24,9 @@ &uart0 {
>  	pinctrl-0 = <&uart0_pe_pins>;
>  	status = "okay";
>  };
> +
> +&mmc0 {
> +	bus-width = <4>;
> +	broken-cd;
> +	status = "okay";

Do we need a vmmc-supply?
Otherwise looks alright.

Cheers,
Andre

> +};
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/suniv-f1c100s-licheepi-nano.dts b/arch/arm/boot/dts/suniv-f1c100s-licheepi-nano.dts
index a1154e6c7cb5..c856a6a20dc8 100644
--- a/arch/arm/boot/dts/suniv-f1c100s-licheepi-nano.dts
+++ b/arch/arm/boot/dts/suniv-f1c100s-licheepi-nano.dts
@@ -24,3 +24,9 @@  &uart0 {
 	pinctrl-0 = <&uart0_pe_pins>;
 	status = "okay";
 };
+
+&mmc0 {
+	bus-width = <4>;
+	broken-cd;
+	status = "okay";
+};