| Message ID | 20220202083039.3774851-1-steen.hegelund@microchip.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 81eb8b0b18789e647e65579303529fd52d861cc2 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v2] net: sparx5: do not refer to skb after passing it on | expand |
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Wed, 2 Feb 2022 09:30:39 +0100 you wrote: > Do not try to use any SKB fields after the packet has been passed up in the > receive stack. > > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com> > > [...] Here is the summary with links: - [net,v2] net: sparx5: do not refer to skb after passing it on https://git.kernel.org/netdev/net/c/81eb8b0b1878 You are awesome, thank you!
diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c b/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c index dc7e5ea6ec15..148d431fcde4 100644 --- a/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c @@ -145,9 +145,9 @@ static void sparx5_xtr_grp(struct sparx5 *sparx5, u8 grp, bool byte_swap) skb_put(skb, byte_cnt - ETH_FCS_LEN); eth_skb_pad(skb); skb->protocol = eth_type_trans(skb, netdev); - netif_rx(skb); netdev->stats.rx_bytes += skb->len; netdev->stats.rx_packets++; + netif_rx(skb); } static int sparx5_inject(struct sparx5 *sparx5,
Do not try to use any SKB fields after the packet has been passed up in the receive stack. Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com> --- drivers/net/ethernet/microchip/sparx5/sparx5_packet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.35.1