| Message ID | 20220124015658.687309-1-eugene.shalygin@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | [ASUS,EC,Sensors,v8,1/3] hwmon: (asus-ec-sensors) add driver for ASUS EC | expand |
On Mon, 24 Jan 2022 at 02:57, Eugene Shalygin <eugene.shalygin@gmail.com> wrote: > > This patchset replaces the HWMON asus_wmi_ec_sensors driver with > an implementation that does not use WMI but queries the embedded > controller directly. Günter, I would like to add support for one more board model. What should I do? Another version update or could you, please, merge this patchset already? Thank you, Eugene
On 2/2/22 15:58, Eugene Shalygin wrote: > On Mon, 24 Jan 2022 at 02:57, Eugene Shalygin <eugene.shalygin@gmail.com> wrote: >> >> This patchset replaces the HWMON asus_wmi_ec_sensors driver with >> an implementation that does not use WMI but queries the embedded >> controller directly. > > Günter, I would like to add support for one more board model. What > should I do? Another version update or could you, please, merge this > patchset already? > > Thank you, > Eugene I was waiting for someone to send me a Tested-by: for the series, since you dropped the previous feedback. Presumably that means that the changes from previous versions warrants another round of testing and/or review. Guenter
> I was waiting for someone to send me a Tested-by: for the series, Oleksandr sent an informal one already. > since you dropped the previous feedback. Does it mean it is possible to update patches while keeping it? Eugene
On 2/2/22 17:16, Eugene Shalygin wrote: >> I was waiting for someone to send me a Tested-by: for the series, > > Oleksandr sent an informal one already. > He wrote: "Given minor changes against v7, I think my "Tested-by:" should have been preserved." which doesn't mean he tested again, only that in his opinion the tags should have been preserved. >> since you dropped the previous feedback. > > Does it mean it is possible to update patches while keeping it? > See above. You are the one to make the call, and you made the call that the series should be re-tested. That means that I am left with either accepting the series without any Tested-by: and/or Reviewed-by: tags, or I have to wait for some. I guess you are telling me that I won't get any additional tags, so I'll have to go in myself and have a closer look. I'll try to do that in the next week or two. Guenter
> > Oleksandr sent an informal one already. > > > > He wrote: > > "Given minor changes against v7, I think my "Tested-by:" should have been preserved." > > which doesn't mean he tested again, only that in his opinion > the tags should have been preserved. Oleksandre, could you, please, let us know did you actually test the v8 code and if so provide us with the Tested-by: tag? > That means that I am left with either accepting the series without any > Tested-by: and/or Reviewed-by: tags, or I have to wait for some. I guess > you are telling me that I won't get any additional tags, so I'll have to > go in myself and have a closer look. I'll try to do that in the next week > or two. Thank you, I understand now. If Oleksandr does not reply in a few days I will send the update with another board (fully duplicating information for its base variant), tested by a Libre Hardware Monitor user. Best regards, Eugene
Hello. On čtvrtek 3. února 2022 4:48:53 CET Eugene Shalygin wrote: > > > Oleksandr sent an informal one already. > > > > > > > He wrote: > > > > "Given minor changes against v7, I think my "Tested-by:" should have been preserved." > > > > which doesn't mean he tested again, only that in his opinion > > the tags should have been preserved. This is not what I meant, but my wording could be better, yes. BTW, the changes were not of that kind to drop Tested-by: tag, really. > Oleksandre, could you, please, let us know did you actually test the > v8 code and if so provide us with the Tested-by: tag? Yes, I do run this version now, and it works fine for me. Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name> > > That means that I am left with either accepting the series without any > > Tested-by: and/or Reviewed-by: tags, or I have to wait for some. I guess > > you are telling me that I won't get any additional tags, so I'll have to > > go in myself and have a closer look. I'll try to do that in the next week > > or two. > > Thank you, I understand now. If Oleksandr does not reply in a few days > I will send the update with another board > (fully duplicating information for its base variant), tested by a > Libre Hardware Monitor user. Thanks. > Best regards, > Eugene >
On 2/2/22 23:09, Oleksandr Natalenko wrote: > Hello. > > On čtvrtek 3. února 2022 4:48:53 CET Eugene Shalygin wrote: >>>> Oleksandr sent an informal one already. >>>> >>> >>> He wrote: >>> >>> "Given minor changes against v7, I think my "Tested-by:" should have been preserved." >>> >>> which doesn't mean he tested again, only that in his opinion >>> the tags should have been preserved. > > This is not what I meant, but my wording could be better, yes. > > BTW, the changes were not of that kind to drop Tested-by: tag, really. > >> Oleksandre, could you, please, let us know did you actually test the >> v8 code and if so provide us with the Tested-by: tag? > > Yes, I do run this version now, and it works fine for me. > > Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name> > Ok, based on that I'll apply the series on top of hwmon-next with your Tested-by:. Guenter >>> That means that I am left with either accepting the series without any >>> Tested-by: and/or Reviewed-by: tags, or I have to wait for some. I guess >>> you are telling me that I won't get any additional tags, so I'll have to >>> go in myself and have a closer look. I'll try to do that in the next week >>> or two. >> >> Thank you, I understand now. If Oleksandr does not reply in a few days >> I will send the update with another board >> (fully duplicating information for its base variant), tested by a >> Libre Hardware Monitor user. > > Thanks. > >> Best regards, >> Eugene >> >
> >> Oleksandre, could you, please, let us know did you actually test the > >> v8 code and if so provide us with the Tested-by: tag? > > > > Yes, I do run this version now, and it works fine for me. > > > > Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name> > > > > Ok, based on that I'll apply the series on top of hwmon-next with your > Tested-by:. > Great! Thank you both! Eugene
On Thu, 3 Feb 2022 21:01:32 +0100 Eugene Shalygin <eugene.shalygin@gmail.com> wrote: > > >> Oleksandre, could you, please, let us know did you actually test > > >> the v8 code and if so provide us with the Tested-by: tag? > > > > > > Yes, I do run this version now, and it works fine for me. > > > > > > Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name> > > > > > > > Ok, based on that I'll apply the series on top of hwmon-next with > > your Tested-by:. > > > > Great! Thank you both! > > Eugene I have also retested code, it works for my case. Tested-by: Denis Pauk <pauk.denis@gmail.com> What about other B550/X570 boards? We have such candidates with same WMI methods in nct6775: "ROG STRIX B550-A GAMING", "ROG STRIX B550-E GAMING", "ROG STRIX B550-F GAMING", "ROG STRIX B550-F GAMING (WI-FI)", "ROG STRIX B550-I GAMING", B550-A does not support asus-wmi-ec-interface("ERROR: Can't get value of subfeature fan1_input: I/O error"), but what about others? Best regards, Denis.
> I have also retested code, it works for my case. > > Tested-by: Denis Pauk <pauk.denis@gmail.com> Thanks! > What about other B550/X570 boards? > > We have such candidates with same WMI methods in nct6775: > "ROG STRIX B550-A GAMING", > "ROG STRIX B550-E GAMING", > "ROG STRIX B550-F GAMING", > "ROG STRIX B550-F GAMING (WI-FI)", > "ROG STRIX B550-I GAMING", > > B550-A does not support asus-wmi-ec-interface("ERROR: Can't get value > of subfeature fan1_input: I/O error"), but what about others? I don't have DSDT for these boards, but most of them have the T_Sensor, according to the specs at the ASUS web-site, so, probably, their EC should report something, because most of their boards report T_Sensor reading via the EC. Best regards, Eugene
> What about other B550/X570 boards? My previous reply is incorrect, in fact we already have information for some of them, it is just me who can't remember or distinguish those board names. > We have such candidates with same WMI methods in nct6775: > "ROG STRIX B550-A GAMING", No data. > "ROG STRIX B550-E GAMING", Already included. > "ROG STRIX B550-F GAMING", No data, the X570-F differs significantly from X570-E, maybe this one is not like other B550 models too. > "ROG STRIX B550-F GAMING (WI-FI)", Probably is identical to the non-wifi model. > "ROG STRIX B550-I GAMING", Already included. Best regards, Eugene