| Message ID | 20220204100336.GA12539@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c3664d913dc115cab4a5fdb5634df4887048000e |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: dsa: qca8k: check correct variable in qca8k_phy_eth_command() | expand |
On 2/4/2022 2:03 AM, Dan Carpenter wrote: > This is a copy and paste bug. It was supposed to check "clear_skb" > instead of "write_skb". > > Fixes: 2cd548566384 ("net: dsa: qca8k: add support for phy read/write with mgmt Ethernet") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Fri, 4 Feb 2022 13:03:36 +0300 you wrote: > This is a copy and paste bug. It was supposed to check "clear_skb" > instead of "write_skb". > > Fixes: 2cd548566384 ("net: dsa: qca8k: add support for phy read/write with mgmt Ethernet") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/net/dsa/qca8k.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net-next] net: dsa: qca8k: check correct variable in qca8k_phy_eth_command() https://git.kernel.org/netdev/net-next/c/c3664d913dc1 You are awesome, thank you!
diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index 52ec2800dd89..35bb568b1df5 100644 --- a/drivers/net/dsa/qca8k.c +++ b/drivers/net/dsa/qca8k.c @@ -1018,7 +1018,7 @@ qca8k_phy_eth_command(struct qca8k_priv *priv, bool read, int phy, clear_skb = qca8k_alloc_mdio_header(MDIO_WRITE, QCA8K_MDIO_MASTER_CTRL, &clear_val, QCA8K_ETHERNET_PHY_PRIORITY, sizeof(clear_val)); - if (!write_skb) { + if (!clear_skb) { ret = -ENOMEM; goto err_clear_skb; }
This is a copy and paste bug. It was supposed to check "clear_skb" instead of "write_skb". Fixes: 2cd548566384 ("net: dsa: qca8k: add support for phy read/write with mgmt Ethernet") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/net/dsa/qca8k.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)