| Message ID | 20220205005232.772726-3-j.neuschaefer@gmx.net (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | clk drivers: Terminate clk_div_table with sentinel element | expand |
On 5/2/22 01:52, Jonathan Neuschäfer wrote: > In order that the end of a clk_div_table can be detected, it must be > terminated with a sentinel element (.div = 0). > > Fixes: b4626a7f4892 ("CLK: Add Loongson1C clock support") > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > > v3: > - no changes > > v2: > - Add Fixes and R-b tags > --- > drivers/clk/loongson1/clk-loongson1c.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/loongson1/clk-loongson1c.c b/drivers/clk/loongson1/clk-loongson1c.c > index 703f87622cf5f..a6f9f20fc8b99 100644 > --- a/drivers/clk/loongson1/clk-loongson1c.c > +++ b/drivers/clk/loongson1/clk-loongson1c.c > @@ -37,6 +37,7 @@ static const struct clk_div_table ahb_div_table[] = { > [1] = { .val = 1, .div = 4 }, > [2] = { .val = 2, .div = 3 }, > [3] = { .val = 3, .div = 3 }, > + [4] = { /* sentinel */ }, Sorry for being nitpicky here, but we don't need the trailing comma, since this is the last entry. > }; > > void __init ls1x_clk_init(void) > -- > 2.34.1 >
On Sat, Feb 05, 2022 at 01:17:10PM +0100, Philippe Mathieu-Daudé wrote: > On 5/2/22 01:52, Jonathan Neuschäfer wrote: > > In order that the end of a clk_div_table can be detected, it must be > > terminated with a sentinel element (.div = 0). > > > > Fixes: b4626a7f4892 ("CLK: Add Loongson1C clock support") > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > > --- > > > > v3: > > - no changes > > > > v2: > > - Add Fixes and R-b tags > > --- > > drivers/clk/loongson1/clk-loongson1c.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/clk/loongson1/clk-loongson1c.c b/drivers/clk/loongson1/clk-loongson1c.c > > index 703f87622cf5f..a6f9f20fc8b99 100644 > > --- a/drivers/clk/loongson1/clk-loongson1c.c > > +++ b/drivers/clk/loongson1/clk-loongson1c.c > > @@ -37,6 +37,7 @@ static const struct clk_div_table ahb_div_table[] = { > > [1] = { .val = 1, .div = 4 }, > > [2] = { .val = 2, .div = 3 }, > > [3] = { .val = 3, .div = 3 }, > > + [4] = { /* sentinel */ }, > > Sorry for being nitpicky here, but we don't need the trailing comma, > since this is the last entry. Good point. Thanks, Jonathan
diff --git a/drivers/clk/loongson1/clk-loongson1c.c b/drivers/clk/loongson1/clk-loongson1c.c index 703f87622cf5f..a6f9f20fc8b99 100644 --- a/drivers/clk/loongson1/clk-loongson1c.c +++ b/drivers/clk/loongson1/clk-loongson1c.c @@ -37,6 +37,7 @@ static const struct clk_div_table ahb_div_table[] = { [1] = { .val = 1, .div = 4 }, [2] = { .val = 2, .div = 3 }, [3] = { .val = 3, .div = 3 }, + [4] = { /* sentinel */ }, }; void __init ls1x_clk_init(void)
In order that the end of a clk_div_table can be detected, it must be terminated with a sentinel element (.div = 0). Fixes: b4626a7f4892 ("CLK: Add Loongson1C clock support") Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- v3: - no changes v2: - Add Fixes and R-b tags --- drivers/clk/loongson1/clk-loongson1c.c | 1 + 1 file changed, 1 insertion(+) -- 2.34.1