| Message ID | 20220207140617.341172-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ALSA: usb-audio: remove redundant assignment to variable c | expand |
On Mon, 07 Feb 2022 15:06:17 +0100, Colin Ian King wrote: > > The variable c is being initialized in an outer for-loop and also > re-initialized inside an inner for-loop. The first initialization > is redundant and can be removed. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> The code change looks OK, but when I apply your patch now, git-am converts the Author address to your new @intel.com, and this mismatches with the address in Signed-off-by. Should I keep the original gmail address, or would you fix up your Signed-off-by (and From) for avoiding those inconsistency? thanks, Takashi
diff --git a/sound/usb/mixer_s1810c.c b/sound/usb/mixer_s1810c.c index 0255089c9efb..fac4bbc6b275 100644 --- a/sound/usb/mixer_s1810c.c +++ b/sound/usb/mixer_s1810c.c @@ -221,7 +221,7 @@ static int snd_s1810c_init_mixer_maps(struct snd_usb_audio *chip) e = 0xbc; for (n = 0; n < 2; n++) { off = n * 18; - for (b = off, c = 0; b < 18 + off; b++) { + for (b = off; b < 18 + off; b++) { /* This channel to all outputs ? */ for (c = 0; c <= 8; c++) { snd_s1810c_send_ctl_packet(dev, a, b, c, 0, e);
The variable c is being initialized in an outer for-loop and also re-initialized inside an inner for-loop. The first initialization is redundant and can be removed. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- sound/usb/mixer_s1810c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)