| Message ID | 20220126145549.617165-1-s.hauer@pengutronix.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/rockchip: RK356x VOP2 support | expand |
Hello Sascha, On 1/26/22 15:55, Sascha Hauer wrote: > This is v4 of adding RK356x VOP2 support. Due to popular demand I added > a changelog to each patch, at least starting with changes to v3, I > didn't care to add the older changes as well. I hopefully integrated all > feedback I received to v3. Additionally I added some patches to the HDMI > driver to support resolutions up to 4k@60Hz. The patches are mostly > taken from the downstream kernel. Some have been send to public lists, > but were never applied upstream for reasons I do not know. The patches > are a bit more intrusive than needed for my case, but are present in the > downstream kernel for a long time, so I decided just to take them > instead of stripping them down to my needs. With these patches I > successfully used the driver with 4k@30Hz. 4k@60Hz doesn't work for me, > I hope this is due to my low quality cable. The cable might be the issue indeed, at least in my tests 4k@60Hz worked just fine. On a RK3568 EVB1, using $ modetest -M rockchip -s 69:{1920x1080,3840x2160}-{30,60} and a HP 27f 4K monitor: Tested-by: Michael Riesch <michael.riesch@wolfvision.net> Thanks for your work and best regards, Michael > > Sascha > > Changes since v3: > - added changelog to each patch > - Add 4k support to hdmi driver > - rebase on v5.17-rc1 > > Changes since v2: > - Add pin names to HDMI supply pin description > - Add hclk support to HDMI driver > - Dual license rockchip-vop2 binding, update binding > - Add HDMI connector to board dts files > - drop unnecessary gamma_lut registers from vop2 > - Update dclk_vop[012] clock handling, no longer hacks needed > - Complete regmap conversion > > Changes since v1: > - drop all unnecessary waiting for frames within atomic modeset and plane update > - Cluster subwin support removed > - gamma support removed > - unnecessary irq_lock removed > - interrupt handling simplified > - simplified zpos handling > - drop is_alpha_support(), use fb->format->has_alpha instead > - use devm_regulator_get() rather than devm_regulator_get_optional() for hdmi regulators > - Use fixed number of planes per video port > - Drop homegrown regmap code from vop2 driver (not complete yet) > - Add separate include file for vop2 driver to not pollute the vop include > > Andy Yan (1): > drm: rockchip: Add VOP2 driver > > Benjamin Gaignard (1): > dt-bindings: display: rockchip: dw-hdmi: Add compatible for rk3568 > HDMI > > Douglas Anderson (2): > drm/rockchip: dw_hdmi: Use auto-generated tables > drm/rockchip: dw_hdmi: Set cur_ctr to 0 always > > Michael Riesch (1): > arm64: dts: rockchip: enable vop2 and hdmi tx on quartz64a > > Nickey Yang (1): > drm/rockchip: dw_hdmi: add default 594Mhz clk for 4K@60hz > > Sascha Hauer (21): > drm/encoder: Add of_graph port to struct drm_encoder > drm/rockchip: dw_hdmi: Do not leave clock enabled in error case > drm/rockchip: dw_hdmi: rename vpll clock to reference clock > drm/rockchip: dw_hdmi: add rk3568 support > drm/rockchip: dw_hdmi: add regulator support > drm/rockchip: dw_hdmi: Add support for hclk > drm/rockchip: dw_hdmi: drop mode_valid hook > clk: rockchip: rk3568: Add more PLL rates > dt-bindings: display: rockchip: dw-hdmi: Make unwedge pinctrl optional > dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name > dt-bindings: display: rockchip: dw-hdmi: Add regulator support > dt-bindings: display: rockchip: dw-hdmi: Add additional clock > dt-bindings: display: rockchip: Add binding for VOP2 > arm64: dts: rockchip: rk3399: reorder hmdi clocks > arm64: dts: rockchip: rk3399: rename HDMI ref clock to 'ref' > arm64: dts: rockchip: rk356x: Add VOP2 nodes > arm64: dts: rockchip: rk356x: Add HDMI nodes > arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi > clk: rk3568: drop CLK_SET_RATE_PARENT from dclk_vop* > clk: rk3568: Add CLK_SET_RATE_PARENT to the HDMI reference clock > drm/rockchip: Make VOP driver optional > > .../display/rockchip/rockchip,dw-hdmi.yaml | 29 +- > .../display/rockchip/rockchip-vop2.yaml | 146 + > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 +- > .../boot/dts/rockchip/rk3566-quartz64-a.dts | 48 + > arch/arm64/boot/dts/rockchip/rk3566.dtsi | 4 + > .../boot/dts/rockchip/rk3568-evb1-v10.dts | 48 + > arch/arm64/boot/dts/rockchip/rk3568.dtsi | 4 + > arch/arm64/boot/dts/rockchip/rk356x.dtsi | 86 + > drivers/clk/rockchip/clk-rk3568.c | 14 +- > drivers/gpu/drm/rockchip/Kconfig | 14 + > drivers/gpu/drm/rockchip/Makefile | 4 +- > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 293 +- > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 3 +- > drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 7 +- > drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 2 + > drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 15 + > drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2665 +++++++++++++++++ > drivers/gpu/drm/rockchip/rockchip_drm_vop2.h | 480 +++ > drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 285 ++ > include/drm/drm_encoder.h | 2 + > include/dt-bindings/soc/rockchip,vop2.h | 14 + > 21 files changed, 4039 insertions(+), 130 deletions(-) > create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > create mode 100644 drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > create mode 100644 drivers/gpu/drm/rockchip/rockchip_drm_vop2.h > create mode 100644 drivers/gpu/drm/rockchip/rockchip_vop2_reg.c > create mode 100644 include/dt-bindings/soc/rockchip,vop2.h >
On Wed, 26 Jan 2022 15:55:22 +0100, Sascha Hauer wrote: > This is v4 of adding RK356x VOP2 support. Due to popular demand I added > a changelog to each patch, at least starting with changes to v3, I > didn't care to add the older changes as well. I hopefully integrated all > feedback I received to v3. Additionally I added some patches to the HDMI > driver to support resolutions up to 4k@60Hz. The patches are mostly > taken from the downstream kernel. Some have been send to public lists, > but were never applied upstream for reasons I do not know. The patches > are a bit more intrusive than needed for my case, but are present in the > downstream kernel for a long time, so I decided just to take them > instead of stripping them down to my needs. With these patches I > successfully used the driver with 4k@30Hz. 4k@60Hz doesn't work for me, > I hope this is due to my low quality cable. > > [...] Applied, thanks! [11/27] clk: rockchip: rk3568: Add more PLL rates commit: 842f4cb7263953020f4e2f2f0005fc3e6fc56144 [24/27] clk: rk3568: drop CLK_SET_RATE_PARENT from dclk_vop* commit: ff3187eabb5ce478d15b6ed62eb286756adefac3 [25/27] clk: rk3568: Add CLK_SET_RATE_PARENT to the HDMI reference clock commit: 6e69052f01d9131388cfcfaee929120118a267f4 Best regards,
On Wed, 26 Jan 2022 15:55:22 +0100, Sascha Hauer wrote: > This is v4 of adding RK356x VOP2 support. Due to popular demand I added > a changelog to each patch, at least starting with changes to v3, I > didn't care to add the older changes as well. I hopefully integrated all > feedback I received to v3. Additionally I added some patches to the HDMI > driver to support resolutions up to 4k@60Hz. The patches are mostly > taken from the downstream kernel. Some have been send to public lists, > but were never applied upstream for reasons I do not know. The patches > are a bit more intrusive than needed for my case, but are present in the > downstream kernel for a long time, so I decided just to take them > instead of stripping them down to my needs. With these patches I > successfully used the driver with 4k@30Hz. 4k@60Hz doesn't work for me, > I hope this is due to my low quality cable. > > [...] Applied, thanks! [18/27] arm64: dts: rockchip: rk3399: reorder hmdi clocks commit: 2e8a8b5955a000cc655f7e368670518cbb77fe58 Best regards,
This is v4 of adding RK356x VOP2 support. Due to popular demand I added a changelog to each patch, at least starting with changes to v3, I didn't care to add the older changes as well. I hopefully integrated all feedback I received to v3. Additionally I added some patches to the HDMI driver to support resolutions up to 4k@60Hz. The patches are mostly taken from the downstream kernel. Some have been send to public lists, but were never applied upstream for reasons I do not know. The patches are a bit more intrusive than needed for my case, but are present in the downstream kernel for a long time, so I decided just to take them instead of stripping them down to my needs. With these patches I successfully used the driver with 4k@30Hz. 4k@60Hz doesn't work for me, I hope this is due to my low quality cable. Sascha Changes since v3: - added changelog to each patch - Add 4k support to hdmi driver - rebase on v5.17-rc1 Changes since v2: - Add pin names to HDMI supply pin description - Add hclk support to HDMI driver - Dual license rockchip-vop2 binding, update binding - Add HDMI connector to board dts files - drop unnecessary gamma_lut registers from vop2 - Update dclk_vop[012] clock handling, no longer hacks needed - Complete regmap conversion Changes since v1: - drop all unnecessary waiting for frames within atomic modeset and plane update - Cluster subwin support removed - gamma support removed - unnecessary irq_lock removed - interrupt handling simplified - simplified zpos handling - drop is_alpha_support(), use fb->format->has_alpha instead - use devm_regulator_get() rather than devm_regulator_get_optional() for hdmi regulators - Use fixed number of planes per video port - Drop homegrown regmap code from vop2 driver (not complete yet) - Add separate include file for vop2 driver to not pollute the vop include Andy Yan (1): drm: rockchip: Add VOP2 driver Benjamin Gaignard (1): dt-bindings: display: rockchip: dw-hdmi: Add compatible for rk3568 HDMI Douglas Anderson (2): drm/rockchip: dw_hdmi: Use auto-generated tables drm/rockchip: dw_hdmi: Set cur_ctr to 0 always Michael Riesch (1): arm64: dts: rockchip: enable vop2 and hdmi tx on quartz64a Nickey Yang (1): drm/rockchip: dw_hdmi: add default 594Mhz clk for 4K@60hz Sascha Hauer (21): drm/encoder: Add of_graph port to struct drm_encoder drm/rockchip: dw_hdmi: Do not leave clock enabled in error case drm/rockchip: dw_hdmi: rename vpll clock to reference clock drm/rockchip: dw_hdmi: add rk3568 support drm/rockchip: dw_hdmi: add regulator support drm/rockchip: dw_hdmi: Add support for hclk drm/rockchip: dw_hdmi: drop mode_valid hook clk: rockchip: rk3568: Add more PLL rates dt-bindings: display: rockchip: dw-hdmi: Make unwedge pinctrl optional dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name dt-bindings: display: rockchip: dw-hdmi: Add regulator support dt-bindings: display: rockchip: dw-hdmi: Add additional clock dt-bindings: display: rockchip: Add binding for VOP2 arm64: dts: rockchip: rk3399: reorder hmdi clocks arm64: dts: rockchip: rk3399: rename HDMI ref clock to 'ref' arm64: dts: rockchip: rk356x: Add VOP2 nodes arm64: dts: rockchip: rk356x: Add HDMI nodes arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi clk: rk3568: drop CLK_SET_RATE_PARENT from dclk_vop* clk: rk3568: Add CLK_SET_RATE_PARENT to the HDMI reference clock drm/rockchip: Make VOP driver optional .../display/rockchip/rockchip,dw-hdmi.yaml | 29 +- .../display/rockchip/rockchip-vop2.yaml | 146 + arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 +- .../boot/dts/rockchip/rk3566-quartz64-a.dts | 48 + arch/arm64/boot/dts/rockchip/rk3566.dtsi | 4 + .../boot/dts/rockchip/rk3568-evb1-v10.dts | 48 + arch/arm64/boot/dts/rockchip/rk3568.dtsi | 4 + arch/arm64/boot/dts/rockchip/rk356x.dtsi | 86 + drivers/clk/rockchip/clk-rk3568.c | 14 +- drivers/gpu/drm/rockchip/Kconfig | 14 + drivers/gpu/drm/rockchip/Makefile | 4 +- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 293 +- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 3 +- drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 7 +- drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 2 + drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 15 + drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2665 +++++++++++++++++ drivers/gpu/drm/rockchip/rockchip_drm_vop2.h | 480 +++ drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 285 ++ include/drm/drm_encoder.h | 2 + include/dt-bindings/soc/rockchip,vop2.h | 14 + 21 files changed, 4039 insertions(+), 130 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml create mode 100644 drivers/gpu/drm/rockchip/rockchip_drm_vop2.c create mode 100644 drivers/gpu/drm/rockchip/rockchip_drm_vop2.h create mode 100644 drivers/gpu/drm/rockchip/rockchip_vop2_reg.c create mode 100644 include/dt-bindings/soc/rockchip,vop2.h