[v5,0/4] tests for btrfs fsverity

Message

Boris Burkov Sept. 13, 2021, 6:44 p.m. UTC

This patchset provides tests for fsverity support in btrfs.

It includes modifications for generic tests to pass with btrfs as well
as new tests.

--
v5:
- more idiomatic requires structure for making efbig test generic
- make efbig test use truncate instead of pwrite for making a big file
- improve documentation for efbig test approximation
- fix underscores vs dashes in btrfs_requires_corrupt_block
- improvements in missing/redundant requires invocations
- move orphan test image file to $TEST_DIR
- make orphan test replay/snapshot device size depend on log device
  instead of hard-coding it.
- rebase (signicant: no more "groups" file; use preamble)
v4:
- mark local variables
- get rid of redundant mounts and syncs
- use '_' in function names correctly
- add a test for the EFBIG case
- reduce usage of requires_btrfs_corrupt_block
- handle variable input when corrupting merkle tree
v3: rebase onto xfstests master branch
v2: pass generic tests, add logwrites test

Boris Burkov (4):
  btrfs: test btrfs specific fsverity corruption
  generic/574: corrupt btrfs merkle tree data
  btrfs: test verity orphans with dmlogwrites
  generic: test fs-verity EFBIG scenarios

 common/btrfs          |   5 ++
 common/config         |   1 +
 common/verity         |  38 ++++++++++
 tests/btrfs/290       | 165 ++++++++++++++++++++++++++++++++++++++++++
 tests/btrfs/290.out   |  25 +++++++
 tests/btrfs/291       | 161 +++++++++++++++++++++++++++++++++++++++++
 tests/btrfs/291.out   |   2 +
 tests/generic/690     |  86 ++++++++++++++++++++++
 tests/generic/690.out |   7 ++
 9 files changed, 490 insertions(+)
 create mode 100755 tests/btrfs/290
 create mode 100644 tests/btrfs/290.out
 create mode 100755 tests/btrfs/291
 create mode 100644 tests/btrfs/291.out
 create mode 100755 tests/generic/690
 create mode 100644 tests/generic/690.out

Comments

Eric Biggers Feb. 8, 2022, 2:20 a.m. UTC | #1

On Mon, Sep 13, 2021 at 11:44:33AM -0700, Boris Burkov wrote:
> This patchset provides tests for fsverity support in btrfs.
> 
> It includes modifications for generic tests to pass with btrfs as well
> as new tests.
> 

Hi Boris, there's been no activity on this patchset in a while.  Are you
planning to keep working on it?  I'd like to see it finished so that I can start
including btrfs in the fs-verity testing I do.

- Eric

Boris Burkov Feb. 8, 2022, 10:34 p.m. UTC | #2

On Mon, Feb 07, 2022 at 06:20:40PM -0800, Eric Biggers wrote:
> On Mon, Sep 13, 2021 at 11:44:33AM -0700, Boris Burkov wrote:
> > This patchset provides tests for fsverity support in btrfs.
> > 
> > It includes modifications for generic tests to pass with btrfs as well
> > as new tests.
> > 
> 
> Hi Boris, there's been no activity on this patchset in a while.  Are you
> planning to keep working on it?  I'd like to see it finished so that I can start
> including btrfs in the fs-verity testing I do.

Hi Eric,

Sorry for not following through on this. I just lost momentum and got
carried off focusing on other more pressing things. I do want to get
this (and the verity kill-switch I started and abandoned...) in, and
will make time to do so soon.

Hopefully this week, but if not, then definitely next week.

Thanks for following up,
Boris

> 
> - Eric