| Message ID | 20220208184721.1697194-5-pmalani@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b579f139e47037cf98808ccf7511a6deb02f3b18 |
| Headers | show |
| Series | platform/chrome: cros_ec_typec: Reorganize mux configuration | expand |
On Tue, Feb 08, 2022 at 06:47:24PM +0000, Prashant Malani wrote: > In cros_typec_remove_partner(), we call > cros_typec_usb_disconnect_state() which sets the switches/muxes to be in > a disconnected state. This also happens in cros_typec_configure_mux(). > However, unlike there, here the mux_flags variable hasn't been updated > to reflect that a disconnection has occurred. Update the flag here > accordingly. > > Signed-off-by: Prashant Malani <pmalani@chromium.org> Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c index 3019e29f200d..4bd2752c0823 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -228,6 +228,7 @@ static void cros_typec_remove_partner(struct cros_typec_data *typec, cros_typec_unregister_altmodes(typec, port_num, true); cros_typec_usb_disconnect_state(port); + port->mux_flags = USB_PD_MUX_NONE; typec_unregister_partner(port->partner); port->partner = NULL;
In cros_typec_remove_partner(), we call cros_typec_usb_disconnect_state() which sets the switches/muxes to be in a disconnected state. This also happens in cros_typec_configure_mux(). However, unlike there, here the mux_flags variable hasn't been updated to reflect that a disconnection has occurred. Update the flag here accordingly. Signed-off-by: Prashant Malani <pmalani@chromium.org> --- Changes in v2: - No changes. drivers/platform/chrome/cros_ec_typec.c | 1 + 1 file changed, 1 insertion(+)