| Message ID | 20220209024312.2218-1-jammy_huang@aspeedtech.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1] media: aspeed: Fix incorrect color | expand |
Dear Jammy, Am 09.02.22 um 03:43 schrieb Jammy Huang: > Current settings for rgb-2-yuv is BT.601(studio swing), but JFIF > uses BT.601(full swing). Could you please describe the problem in a little more detail? On an attached monitor to the BMC (which one) what incorrect colors are seen? Maybe use: > media: aspeed: Use full swing for JFIF to fix incorrect color > Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com> > --- > drivers/media/platform/aspeed-video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c > index eb9c17ac0e14..08b63b8297f0 100644 > --- a/drivers/media/platform/aspeed-video.c > +++ b/drivers/media/platform/aspeed-video.c > @@ -1089,7 +1089,7 @@ static void aspeed_video_init_regs(struct aspeed_video *video) > u32 comp_ctrl = VE_COMP_CTRL_RSVD | > FIELD_PREP(VE_COMP_CTRL_DCT_LUM, video->jpeg_quality) | > FIELD_PREP(VE_COMP_CTRL_DCT_CHR, video->jpeg_quality | 0x10); > - u32 ctrl = VE_CTRL_AUTO_OR_CURSOR; > + u32 ctrl = VE_CTRL_AUTO_OR_CURSOR | VE_CTRL_YUV; Excuse my ignorance, but reading [1][2] YUV can be represented by studio and full swing. How is the register/bit described in the datasheet, and can the macro name be improved? > u32 seq_ctrl = video->jpeg_mode; > > if (video->frame_rate) Kind regards, Paul [1]: https://mymusing.co/bt601-yuv-to-rgb-conversion-color/ [2]: https://www.hisour.com/yuv-color-system-25916/
Dear Paul, Thanks for your review and suggestion. On 2022/2/9 下午 02:23, Paul Menzel wrote: > Dear Jammy, > > > Am 09.02.22 um 03:43 schrieb Jammy Huang: >> Current settings for rgb-2-yuv is BT.601(studio swing), but JFIF >> uses BT.601(full swing). > Could you please describe the problem in a little more detail? On an > attached monitor to the BMC (which one) what incorrect colors are seen? Aspeed video 's input is gfx' output which is ARGB format. To generate jpg, video engine will transform ARGB into YUV first. Previously, aspeed video's default settings is studio swing (16~235), but jpg is full swing (0~255) as you can see in 'Conversion to and from RGB' of https://www.w3.org/Graphics/JPEG/jfif3.pdf. This will lead to incorrect color. For example, a RGB color on gfx, blue(0, 0, 255) will become (16, 16, 235) after we see the output jpg of aspeed video. > Maybe use: > >> media: aspeed: Use full swing for JFIF to fix incorrect color Thanks, I will update a more suitable subject for this patch. >> Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com> >> --- >> drivers/media/platform/aspeed-video.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c >> index eb9c17ac0e14..08b63b8297f0 100644 >> --- a/drivers/media/platform/aspeed-video.c >> +++ b/drivers/media/platform/aspeed-video.c >> @@ -1089,7 +1089,7 @@ static void aspeed_video_init_regs(struct aspeed_video *video) >> u32 comp_ctrl = VE_COMP_CTRL_RSVD | >> FIELD_PREP(VE_COMP_CTRL_DCT_LUM, video->jpeg_quality) | >> FIELD_PREP(VE_COMP_CTRL_DCT_CHR, video->jpeg_quality | 0x10); >> - u32 ctrl = VE_CTRL_AUTO_OR_CURSOR; >> + u32 ctrl = VE_CTRL_AUTO_OR_CURSOR | VE_CTRL_YUV; > Excuse my ignorance, but reading [1][2] YUV can be represented by studio > and full swing. How is the register/bit described in the datasheet, and > can the macro name be improved? VR008[7:6] will decide the data format for video capture: 00: CCIR601 studio swing compliant YUV format 01: CCIR601 full swing compliant YUV format 10: RGB format 11: Gray color mode I will update this part as well. > >> u32 seq_ctrl = video->jpeg_mode; >> >> if (video->frame_rate) > > Kind regards, > > Paul > > > [1]: https://mymusing.co/bt601-yuv-to-rgb-conversion-color/ > [2]: https://www.hisour.com/yuv-color-system-25916/
diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c index eb9c17ac0e14..08b63b8297f0 100644 --- a/drivers/media/platform/aspeed-video.c +++ b/drivers/media/platform/aspeed-video.c @@ -1089,7 +1089,7 @@ static void aspeed_video_init_regs(struct aspeed_video *video) u32 comp_ctrl = VE_COMP_CTRL_RSVD | FIELD_PREP(VE_COMP_CTRL_DCT_LUM, video->jpeg_quality) | FIELD_PREP(VE_COMP_CTRL_DCT_CHR, video->jpeg_quality | 0x10); - u32 ctrl = VE_CTRL_AUTO_OR_CURSOR; + u32 ctrl = VE_CTRL_AUTO_OR_CURSOR | VE_CTRL_YUV; u32 seq_ctrl = video->jpeg_mode; if (video->frame_rate)
Current settings for rgb-2-yuv is BT.601(studio swing), but JFIF uses BT.601(full swing). Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com> --- drivers/media/platform/aspeed-video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)